From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Chris Co <Christopher.Co@microsoft.com>
Subject: Re: [PATCH v1 0/2] add DwMmcHcDxe driver
Date: Tue, 14 Aug 2018 17:32:11 +0100 [thread overview]
Message-ID: <20180814163211.etfac2lrin4eecyu@bivouac.eciton.net> (raw)
In-Reply-To: <1533890955-13005-1-git-send-email-haojian.zhuang@linaro.org>
Haojian,
This is kind of massive.
Is there any way it could be broken into more patches?
The NonDiscoverableDeviceDxe patch is OK, but the changes to
DwMmcHcDxe are gargantuan.
Chris - does any of this turn into something you could use for your
platforms?
/
Leis
On Fri, Aug 10, 2018 at 04:49:13PM +0800, Haojian Zhuang wrote:
> Changelog:
> v1:
> *Add NonDiscoverableDeviceDxe for embedded platform. Make DwMmcHcDxe driver
> to support both eMMC and SD controller.
>
> Haojian Zhuang (2):
> EmbeddedPkg: add NonDiscoverableDeviceDxe driver
> EmbeddedPkg: add DwMmcHcDxe driver
>
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 +
> EmbeddedPkg/EmbeddedPkg.dec | 1 +
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 +
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.inf | 52 +
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 +++++++
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 ++++++++
> EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 +
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.h | 92 +
> EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c | 214 ++
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 +++++++++++
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 ++++++++++++++++++++
> EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 +++++++++
> EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 +++++++++
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c | 124 +
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c | 243 ++
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c | 972 ++++++++
> 16 files changed, 9491 insertions(+)
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf
> create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.inf
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h
> create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h
> create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.h
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c
> create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c
> create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c
> create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c
> create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-08-14 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 8:49 [PATCH v1 0/2] add DwMmcHcDxe driver Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 1/2] EmbeddedPkg: add NonDiscoverableDeviceDxe driver Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 2/2] EmbeddedPkg: add DwMmcHcDxe driver Haojian Zhuang
2018-08-14 16:32 ` Leif Lindholm [this message]
2018-08-15 3:10 ` [PATCH v1 0/2] " Chris Co
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814163211.etfac2lrin4eecyu@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox