From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9D31D210D97AF for ; Tue, 14 Aug 2018 09:32:15 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id g1-v6so17763689wru.2 for ; Tue, 14 Aug 2018 09:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8ViLoB6PmK4MENsJQTMpIE8PX64mVKFIl+TldlB1sJk=; b=ej1HCVO5GhSOD/+RNI3qybfXmWw1z3lx5a169724p73huxkYK3HwbkZnNTFiwDuHd/ bl5okbT4rqe1aEKllcaZXXeRUk/8mPIU4HMZw9b/RELFhpJZgiawIJ4/VnlDrYfmoiT9 mRH67xJaffa09R0OHb4ga8DfWePAq/sHC/X38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8ViLoB6PmK4MENsJQTMpIE8PX64mVKFIl+TldlB1sJk=; b=Jbs+SdRQWdGowvLG1o9tDfk99F/I33741g2zkCiIIxJAXayqzgHfs0C69nb3JsqH1j kzECgl3bvMgupn40mgTxLKMnwiMYSBY/0e04t0njafd9ZbMFhkodVHuZAMnpheM65gXj /bf9wdZ03jupF3PrcKkR4fKdCdRsPJKba41HxbnAkXOqoP82QAT44oHeKhgjXhsmoqH3 5CFzzEKfwt+cnjFCxGY5oQ4Ijm6X8SdTzswBhxPs87TuHGuH9fdMHY04S2SHKoysfn5Y qZ5M4pgp6h2G/IWiI8t+616gjO/ywIKq4UezAOeGnimVRINGsV5PfkOXQCQTa6VtgXZs ualQ== X-Gm-Message-State: AOUpUlFULqlKZlEFKnNLA5Faq2mOn0Aveb/8y/USmhseVzdyG9Azi7Lq w1xlKL4y3YebPVjHGLNSMX12gU7L2GQ= X-Google-Smtp-Source: AA+uWPxkmpawQrRU4fNxoE6XnYRZV+Z1giZtWFm7QulQyXU+kYNRjBYfsXraZ2j473k/676jn4ZPqA== X-Received: by 2002:adf:fe8f:: with SMTP id l15-v6mr13557984wrr.165.1534264334025; Tue, 14 Aug 2018 09:32:14 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q11-v6sm22171082wrp.58.2018.08.14.09.32.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Aug 2018 09:32:12 -0700 (PDT) Date: Tue, 14 Aug 2018 17:32:11 +0100 From: Leif Lindholm To: Haojian Zhuang Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Chris Co Message-ID: <20180814163211.etfac2lrin4eecyu@bivouac.eciton.net> References: <1533890955-13005-1-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1533890955-13005-1-git-send-email-haojian.zhuang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1 0/2] add DwMmcHcDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 16:32:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Haojian, This is kind of massive. Is there any way it could be broken into more patches? The NonDiscoverableDeviceDxe patch is OK, but the changes to DwMmcHcDxe are gargantuan. Chris - does any of this turn into something you could use for your platforms? / Leis On Fri, Aug 10, 2018 at 04:49:13PM +0800, Haojian Zhuang wrote: > Changelog: > v1: > *Add NonDiscoverableDeviceDxe for embedded platform. Make DwMmcHcDxe driver > to support both eMMC and SD controller. > > Haojian Zhuang (2): > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > EmbeddedPkg: add DwMmcHcDxe driver > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > EmbeddedPkg/EmbeddedPkg.dec | 1 + > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.inf | 52 + > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 +++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 ++++++++ > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.h | 92 + > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 +++++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 ++++++++++++++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 +++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 +++++++++ > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c | 124 + > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c | 243 ++ > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c | 972 ++++++++ > 16 files changed, 9491 insertions(+) > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.inf > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.h > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > -- > 2.7.4 >