From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::544; helo=mail-ed1-x544.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A193A210DA79D for ; Tue, 14 Aug 2018 09:42:34 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id s16-v6so10430096edq.12 for ; Tue, 14 Aug 2018 09:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NcRz3x9SPoFRmxZfDkrz8cQq9nB5O/fqS+eg2/QCCi8=; b=MwwPRKRLsmrTdrFkafPsMoV7VbhTayYOtzXWM4jtrEzgiTKwgnnB0B9PghLsy9gNEi YhTd7rPZ48Z1XDHvoIk7m1BjA+D7oX+kb9kiOOhSpkvyIrvQ+GgGeIhAEBIg68jfl+u0 lJE48JIbMLyCGAbIpdojEcVGd22LcZc51RWeY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NcRz3x9SPoFRmxZfDkrz8cQq9nB5O/fqS+eg2/QCCi8=; b=qouWXqSqf+Kc2r8Rl7q78+6GrCZwM8eTNfNh7UMaK+vuNPPgSJYetncWbCGcWjwtpm sihgBl7DjWsKve3vUU7NZ6th2XWJm+UIgePG3tnRBYg15T3cA93QzVnYf6Kpv7LlW+dM LDZfhbj6Kaqm+MZ7F6hfkqz42zssyORS+KJVZu+eJ7lbyuybAypAYSaaRbgwjkJiFKI4 fQ+MgdCoXr0uCWpvzEaD70EL5Jh2B+iL9zcZelHRzsCBrHSgPBmpg1pNyHdfLesyAmL8 NVgoLwuh3BiVy3zARc8TDDKAsRYUPDKrLkc0emHsgbv6kjfasv66qugldefaUubbBQ6g D6NQ== X-Gm-Message-State: AOUpUlEoob/xZkJalpBFjKN328fjzDQ21mwRwf2bu1ys18+m7GssrRjn 6WdsFJwgYDLegg7fy0ngI/pjuH5IgII= X-Google-Smtp-Source: AA+uWPzmTyikWiWkUZDygQiFyFBNyDf0rWjCd+B++7xuzbAeCKkKmZkbh6VCSprHnpWuCRCxr9jWug== X-Received: by 2002:a50:e885:: with SMTP id f5-v6mr28355259edn.39.1534264952783; Tue, 14 Aug 2018 09:42:32 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h10-v6sm10718139edb.51.2018.08.14.09.42.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Aug 2018 09:42:31 -0700 (PDT) Date: Tue, 14 Aug 2018 17:42:29 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, michael.d.kinney@intel.com, liming.gao@intel.com, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, huangdaode@hisilicon.com Message-ID: <20180814164229.obh5rx3ecbk6su6z@bivouac.eciton.net> References: <20180812140148.31669-1-ming.huang@linaro.org> <20180812140148.31669-2-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180812140148.31669-2-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2/MdePkg v1 1/1] MdePkg Cper.h: Add generic error macros for ARM platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 16:42:35 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Aug 12, 2018 at 10:01:48PM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Mike, Liming. Could we merge this during the quiet period? It's basically an omission - these are defined since (at least) UEFI 2.6. > --- > MdePkg/Include/Guid/Cper.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h > index 5ddd4c715ebc..525bfe57b21b 100644 > --- a/MdePkg/Include/Guid/Cper.h > +++ b/MdePkg/Include/Guid/Cper.h > @@ -256,6 +256,7 @@ typedef struct { > ///@{ > #define EFI_GENERIC_ERROR_PROC_TYPE_IA32_X64 0x00 > #define EFI_GENERIC_ERROR_PROC_TYPE_IA64 0x01 > +#define EFI_GENERIC_ERROR_PROC_TYPE_ARM 0x02 > ///@} > > /// > @@ -265,6 +266,8 @@ typedef struct { > #define EFI_GENERIC_ERROR_PROC_ISA_IA32 0x00 > #define EFI_GENERIC_ERROR_PROC_ISA_IA64 0x01 > #define EFI_GENERIC_ERROR_PROC_ISA_X64 0x02 > +#define EFI_GENERIC_ERROR_PROC_ISA_ARM32 0x03 > +#define EFI_GENERIC_ERROR_PROC_ISA_ARM64 0x04 Looking at the spec though, these are called: ARM A32/T32 and ARM A64 For architectural correctness, I think the names should be EFI_GENERIC_ERROR_PROC_ISA_A32_T32 EFI_GENERIC_ERROR_PROC_ISA_A64 or EFI_GENERIC_ERROR_PROC_ISA_ARM_A32_T32 EFI_GENERIC_ERROR_PROC_ISA_ARM_A64 which gives some form of glorious symmetry against the EFI_GENERIC_ERROR_PROC_TYPE_IA32_X64 above :) With either change, as preferred by the package maintainers: Reviewed-by: Leif Lindholm > ///@} > > /// > -- > 2.17.0 >