From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EE5B3210F2007 for ; Tue, 14 Aug 2018 18:47:22 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 18:47:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,241,1531810800"; d="scan'208";a="81435139" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga001.fm.intel.com with ESMTP; 14 Aug 2018 18:47:22 -0700 From: shenglei To: edk2-devel@lists.01.org Cc: Star Zeng , Eric Dong Date: Wed, 15 Aug 2018 09:45:54 +0800 Message-Id: <20180815014609.19948-13-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180815014609.19948-1-shenglei.zhang@intel.com> References: <20180815014609.19948-1-shenglei.zhang@intel.com> Subject: [PATCH v2 12/27] MdeModulePkg UfsPassThruDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 01:47:23 -0000 The functions that are never called have been removed. They are UfsClearFlag and UfsFindAvailableSlotInTmrl. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Hao Wu Reviewed-by: Star Zeng --- .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 49 ------------------- 1 file changed, 49 deletions(-) diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c index e868c8c07e..5756f637fd 100644 --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c @@ -753,31 +753,6 @@ UfsFindAvailableSlotInTrl ( return EFI_NOT_READY; } -/** - Find out available slot in task management transfer list of a UFS device. - - @param[in] Private The pointer to the UFS_PASS_THRU_PRIVATE_DATA data structure. - @param[out] Slot The available slot. - - @retval EFI_SUCCESS The available slot was found successfully. - -**/ -EFI_STATUS -UfsFindAvailableSlotInTmrl ( - IN UFS_PASS_THRU_PRIVATE_DATA *Private, - OUT UINT8 *Slot - ) -{ - ASSERT ((Private != NULL) && (Slot != NULL)); - - // - // The simplest algo to always use slot 0. - // TODO: enhance it to support async transfer with multiple slot. - // - *Slot = 0; - - return EFI_SUCCESS; -} /** Start specified slot in transfer list of a UFS device. @@ -1229,31 +1204,7 @@ UfsSetFlag ( return Status; } -/** - Clear specified flag to 0 on a UFS device. - - @param[in] Private The pointer to the UFS_PASS_THRU_PRIVATE_DATA data structure. - @param[in] FlagId The ID of flag to be cleared. - - @retval EFI_SUCCESS The flag was cleared successfully. - @retval EFI_DEVICE_ERROR A device error occurred while attempting to clear the flag. - @retval EFI_TIMEOUT A timeout occurred while waiting for the completion of clearing the flag. - -**/ -EFI_STATUS -UfsClearFlag ( - IN UFS_PASS_THRU_PRIVATE_DATA *Private, - IN UINT8 FlagId - ) -{ - EFI_STATUS Status; - UINT8 Value; - - Value = 0; - Status = UfsRwFlags (Private, FALSE, FlagId, &Value); - return Status; -} /** Read specified flag from a UFS device. -- 2.18.0.windows.1