From: shenglei <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [PATCH v2 15/27] MdeModulePkg UsbBusPei: Remove redundant functions
Date: Wed, 15 Aug 2018 09:45:57 +0800 [thread overview]
Message-ID: <20180815014609.19948-16-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20180815014609.19948-1-shenglei.zhang@intel.com>
The functions that are never called have been removed.
They are PeiHubSetHubFeature,IsPortConnectChange and
PeiUsbClearDeviceFeature.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni at intel.com>
Reviewed-by: Star Zeng <star.zeng at intel.com>
---
MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c | 39 -----------
MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 18 -----
MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 77 ----------------------
MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 35 ----------
4 files changed, 169 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c
index 806602511c..5607c65b13 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c
@@ -193,46 +193,7 @@ PeiHubGetHubStatus (
);
}
-/**
- Set specified feature to a given hub.
-
- @param PeiServices General-purpose services that are available to every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param Value New feature value.
-
- @retval EFI_SUCCESS Port feature is set successfully.
- @retval EFI_DEVICE_ERROR Cannot set the port feature due to a hardware error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiHubSetHubFeature (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN UINT8 Value
- )
-{
- EFI_USB_DEVICE_REQUEST DeviceRequest;
- ZeroMem (&DeviceRequest, sizeof (EFI_USB_DEVICE_REQUEST));
-
- //
- // Fill Device request packet
- //
- DeviceRequest.RequestType = USB_HUB_SET_HUB_FEATURE_REQ_TYPE;
- DeviceRequest.Request = USB_HUB_SET_HUB_FEATURE;
- DeviceRequest.Value = Value;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- &DeviceRequest,
- EfiUsbNoData,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- NULL,
- 0
- );
-}
/**
Clear specified feature on a given hub.
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
index 385a14ec0d..d21057c349 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
@@ -145,24 +145,6 @@ PeiHubSetPortFeature (
IN UINT8 Value
);
-/**
- Set specified feature to a given hub.
-
- @param PeiServices General-purpose services that are available to every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param Value New feature value.
-
- @retval EFI_SUCCESS Port feature is set successfully.
- @retval EFI_DEVICE_ERROR Cannot set the port feature due to a hardware error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiHubSetHubFeature (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN UINT8 Value
- );
/**
Get a given hub status.
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c
index c5e599e2f7..73a163e7a0 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c
@@ -104,62 +104,7 @@ PeiUsbSetDeviceAddress (
);
}
-/**
- Clear a given usb feature.
-
- @param PeiServices General-purpose services that are available to every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param Recipient The recipient of ClearFeature Request, should be one of Device/Interface/Endpoint.
- @param Value Request Value.
- @param Target Request Index.
-
- @retval EFI_SUCCESS Usb feature is cleared successfully.
- @retval EFI_DEVICE_ERROR Cannot clear the usb feature due to a hardware error.
- @retval Others Other failure occurs.
-**/
-EFI_STATUS
-PeiUsbClearDeviceFeature (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN EFI_USB_RECIPIENT Recipient,
- IN UINT16 Value,
- IN UINT16 Target
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
-
- ASSERT (UsbIoPpi != NULL);
-
- switch (Recipient) {
- case EfiUsbDevice:
- DevReq.RequestType = USB_DEV_CLEAR_FEATURE_REQ_TYPE_D;
- break;
-
- case EfiUsbInterface:
- DevReq.RequestType = USB_DEV_CLEAR_FEATURE_REQ_TYPE_I;
- break;
-
- case EfiUsbEndpoint:
- DevReq.RequestType = USB_DEV_CLEAR_FEATURE_REQ_TYPE_E;
- break;
- }
-
- DevReq.Request = USB_DEV_CLEAR_FEATURE;
- DevReq.Value = Value;
- DevReq.Index = Target;
- DevReq.Length = 0;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- &DevReq,
- EfiUsbNoData,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- NULL,
- 0
- );
-}
/**
Configure a usb device to Configuration 1.
@@ -244,26 +189,4 @@ PeiUsbGetDeviceSpeed (
}
}
-/**
- Judge if the port is in "connection change" status or not.
-
- @param PortChangeStatus The usb port change status gotten.
-
- @retval TRUE The port is in "connection change" status.
- @retval FALSE The port is NOT in "connection change" status.
-**/
-BOOLEAN
-IsPortConnectChange (
- IN UINT16 PortChangeStatus
- )
-{
- //
- // return the bit 0 value of PortChangeStatus
- //
- if ((PortChangeStatus & USB_PORT_STAT_C_CONNECTION) != 0) {
- return TRUE;
- } else {
- return FALSE;
- }
-}
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
index 35f47a35ec..e3afee6e84 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
@@ -148,28 +148,6 @@ PeiUsbSetDeviceAddress (
IN UINT16 AddressValue
);
-/**
- Clear a given usb feature.
-
- @param PeiServices General-purpose services that are available to every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param Recipient The recipient of ClearFeature Request, should be one of Device/Interface/Endpoint.
- @param Value Request Value.
- @param Target Request Index.
-
- @retval EFI_SUCCESS Usb feature is cleared successfully.
- @retval EFI_DEVICE_ERROR Cannot clear the usb feature due to a hardware error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbClearDeviceFeature (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN EFI_USB_RECIPIENT Recipient,
- IN UINT16 Value,
- IN UINT16 Target
- );
/**
Configure a usb device to Configuration 1.
@@ -215,17 +193,4 @@ PeiUsbGetDeviceSpeed (
IN UINT16 PortStatus
);
-/**
- Judge if the port is in "connection change" status or not.
-
- @param PortChangeStatus The usb port change status gotten.
-
- @retval TRUE The port is in "connection change" status.
- @retval FALSE The port is NOT in "connection change" status.
-
-**/
-BOOLEAN
-IsPortConnectChange (
- IN UINT16 PortChangeStatus
- );
#endif
--
2.18.0.windows.1
next prev parent reply other threads:[~2018-08-15 1:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 1:45 [PATCH v2 00/27] MdeModulePkg Remove redundant functions shenglei
2018-08-15 1:45 ` [PATCH v2 01/27] MdeModulePkg CapsuleApp: Remove a redundant function shenglei
2018-08-15 1:45 ` [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant functions shenglei
2018-08-15 2:24 ` Dong, Eric
2018-08-15 1:45 ` [PATCH v2 03/27] MdeModulePkg AtaAtapiPassThru: " shenglei
2018-08-15 1:45 ` [PATCH v2 04/27] MdeModulePkg EhciDxe: " shenglei
2018-08-15 1:45 ` [PATCH v2 05/27] MdeModulePkg NvmExpressDxe: " shenglei
2018-08-15 1:45 ` [PATCH v2 06/27] MdeModulePkg PciBusDxe: " shenglei
2018-08-15 1:45 ` [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: " shenglei
2018-08-15 2:01 ` Wu, Hao A
2018-08-20 4:57 ` Zeng, Star
2018-08-15 1:45 ` [PATCH v2 08/27] MdeModulePkg UhciPei: " shenglei
2018-08-15 1:45 ` [PATCH v2 09/27] MdeModulePkg XhciDxe: " shenglei
2018-08-15 1:45 ` [PATCH v2 10/27] MdeModulePkg XhciPei: " shenglei
2018-08-15 1:45 ` [PATCH v2 11/27] MdeModulePkg UfsBlockIoPei: " shenglei
2018-08-15 1:45 ` [PATCH v2 12/27] MdeModulePkg UfsPassThruDxe: " shenglei
2018-08-15 1:45 ` [PATCH v2 13/27] MdeModulePkg UsbBotPei: " shenglei
2018-08-15 1:45 ` [PATCH v2 14/27] MdeModulePkg UsbBusDxe: " shenglei
2018-08-15 1:45 ` shenglei [this message]
2018-08-15 1:45 ` [PATCH v2 16/27] MdeModulePkg Core/Dxe: " shenglei
2018-08-15 1:45 ` [PATCH v2 17/27] MdeModulePkg PiSmmCore: " shenglei
2018-08-15 1:46 ` [PATCH v2 18/27] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function shenglei
2018-08-15 1:46 ` [PATCH v2 19/27] MdeModulePkg EmmcBlockIoPei: " shenglei
2018-08-15 1:46 ` [PATCH v2 20/27] MdeModulePkg SdBlockIoPei: " shenglei
2018-08-15 1:46 ` [PATCH v2 21/27] MdeModulePkg TerminalDxe: " shenglei
2018-08-15 1:46 ` [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: " shenglei
2018-08-15 2:20 ` Dong, Eric
2018-08-15 1:46 ` [PATCH v2 23/27] MdeModulePkg Ip4Dxe: " shenglei
2018-08-15 1:46 ` [PATCH v2 24/27] MdeModulePkg IScsiDxe: " shenglei
2018-08-15 1:46 ` [PATCH v2 25/27] MdeModulePkg Tcp4Dxe: Remove redundant functions shenglei
2018-08-15 1:46 ` [PATCH v2 26/27] MdeModulePkg SetupBrowserDxe: Remove a redundant function shenglei
2018-08-20 4:56 ` Zeng, Star
2018-08-15 1:46 ` [PATCH v2 27/27] MdeModulePkg UiApp: Remove a redundant function and a variable shenglei
2018-08-20 4:55 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815014609.19948-16-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox