From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6AF22210F1554 for ; Tue, 14 Aug 2018 18:47:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 18:47:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,241,1531810800"; d="scan'208";a="81435105" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga001.fm.intel.com with ESMTP; 14 Aug 2018 18:47:14 -0700 From: shenglei To: edk2-devel@lists.01.org Cc: Star Zeng , Eric Dong Date: Wed, 15 Aug 2018 09:45:49 +0800 Message-Id: <20180815014609.19948-8-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180815014609.19948-1-shenglei.zhang@intel.com> References: <20180815014609.19948-1-shenglei.zhang@intel.com> Subject: [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 01:47:15 -0000 The functions that are never called have been removed. They are SdCardGetCsd and SdCardGetScr. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 107 ------------------ 1 file changed, 107 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c index 9e70de956f..8c93933bc6 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c @@ -318,116 +318,9 @@ SdCardSetRca ( return Status; } -/** - Send command SEND_CSD to the SD device to get the data of the CSD register. - - Refer to SD Physical Layer Simplified Spec 4.1 Section 4.7 for details. - - @param[in] PassThru A pointer to the EFI_SD_MMC_PASS_THRU_PROTOCOL instance. - @param[in] Slot The slot number of the SD card to send the command to. - @param[in] Rca The relative device address of selected device. - @param[out] Csd The buffer to store the content of the CSD register. - Note the caller should ignore the lowest byte of this - buffer as the content of this byte is meaningless even - if the operation succeeds. - - @retval EFI_SUCCESS The operation is done correctly. - @retval Others The operation fails. - -**/ -EFI_STATUS -SdCardGetCsd ( - IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, - IN UINT8 Slot, - IN UINT16 Rca, - OUT SD_CSD *Csd - ) -{ - EFI_SD_MMC_COMMAND_BLOCK SdMmcCmdBlk; - EFI_SD_MMC_STATUS_BLOCK SdMmcStatusBlk; - EFI_SD_MMC_PASS_THRU_COMMAND_PACKET Packet; - EFI_STATUS Status; - - ZeroMem (&SdMmcCmdBlk, sizeof (SdMmcCmdBlk)); - ZeroMem (&SdMmcStatusBlk, sizeof (SdMmcStatusBlk)); - ZeroMem (&Packet, sizeof (Packet)); - - Packet.SdMmcCmdBlk = &SdMmcCmdBlk; - Packet.SdMmcStatusBlk = &SdMmcStatusBlk; - Packet.Timeout = SD_MMC_HC_GENERIC_TIMEOUT; - SdMmcCmdBlk.CommandIndex = SD_SEND_CSD; - SdMmcCmdBlk.CommandType = SdMmcCommandTypeAc; - SdMmcCmdBlk.ResponseType = SdMmcResponseTypeR2; - SdMmcCmdBlk.CommandArgument = (UINT32)Rca << 16; - Status = SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - if (!EFI_ERROR (Status)) { - // - // For details, refer to SD Host Controller Simplified Spec 3.0 Table 2-12. - // - CopyMem (((UINT8*)Csd) + 1, &SdMmcStatusBlk.Resp0, sizeof (SD_CSD) - 1); - } - - return Status; -} - -/** - Send command SEND_CSD to the SD device to get the data of the CSD register. - - Refer to SD Physical Layer Simplified Spec 4.1 Section 4.7 for details. - @param[in] PassThru A pointer to the EFI_SD_MMC_PASS_THRU_PROTOCOL instance. - @param[in] Slot The slot number of the SD card to send the command to. - @param[in] Rca The relative device address of selected device. - @param[out] Scr The buffer to store the content of the SCR register. - - @retval EFI_SUCCESS The operation is done correctly. - @retval Others The operation fails. - -**/ -EFI_STATUS -SdCardGetScr ( - IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, - IN UINT8 Slot, - IN UINT16 Rca, - OUT SD_SCR *Scr - ) -{ - EFI_SD_MMC_COMMAND_BLOCK SdMmcCmdBlk; - EFI_SD_MMC_STATUS_BLOCK SdMmcStatusBlk; - EFI_SD_MMC_PASS_THRU_COMMAND_PACKET Packet; - EFI_STATUS Status; - - ZeroMem (&SdMmcCmdBlk, sizeof (SdMmcCmdBlk)); - ZeroMem (&SdMmcStatusBlk, sizeof (SdMmcStatusBlk)); - ZeroMem (&Packet, sizeof (Packet)); - - Packet.SdMmcCmdBlk = &SdMmcCmdBlk; - Packet.SdMmcStatusBlk = &SdMmcStatusBlk; - Packet.Timeout = SD_MMC_HC_GENERIC_TIMEOUT; - - SdMmcCmdBlk.CommandIndex = SD_APP_CMD; - SdMmcCmdBlk.CommandType = SdMmcCommandTypeAc; - SdMmcCmdBlk.ResponseType = SdMmcResponseTypeR1; - SdMmcCmdBlk.CommandArgument = (UINT32)Rca << 16; - - Status = SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - if (EFI_ERROR (Status)) { - return Status; - } - - SdMmcCmdBlk.CommandIndex = SD_SEND_SCR; - SdMmcCmdBlk.CommandType = SdMmcCommandTypeAdtc; - SdMmcCmdBlk.ResponseType = SdMmcResponseTypeR1; - - Packet.InDataBuffer = Scr; - Packet.InTransferLength = sizeof (SD_SCR); - - Status = SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - - return Status; -} /** Send command SELECT_DESELECT_CARD to the SD device to select/deselect it. -- 2.18.0.windows.1