public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Gary Lin <glin@suse.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel@lists.01.org, Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH 1/1] OvmfPkg: Resolve HashInstanceLibSha384 and HashInstanceLibSha512
Date: Wed, 15 Aug 2018 09:51:30 +0800	[thread overview]
Message-ID: <20180815015130.GC31095@GaryWorkstation> (raw)
In-Reply-To: <7757580c-0799-105c-401a-5b140082a905@redhat.com>

On Tue, Aug 14, 2018 at 06:37:51PM +0200, Laszlo Ersek wrote:
> Hi Gary,
> 
> (+ Marc-André)
> 
> On 08/14/18 09:36, Gary Lin wrote:
> > Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those
> > two libraries to enable SHA384 and SHA512 support in TPM.
> > 
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Gary Lin <glin@suse.com>
> > ---
> >  OvmfPkg/OvmfPkgIa32.dsc    | 4 ++++
> >  OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++
> >  OvmfPkg/OvmfPkgX64.dsc     | 4 ++++
> >  3 files changed, 12 insertions(+)
> > 
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> > index a28b511d5c2f..9f07e75050c0 100644
> > --- a/OvmfPkg/OvmfPkgIa32.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32.dsc
> > @@ -634,6 +634,8 @@ [Components]
> >        HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf
> >    }
> >  !endif
> >  
> > @@ -936,5 +938,7 @@ [Components]
> >        HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf
> >    }
> >  !endif
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> > index 115d0c01ff5c..a4eaeb808c6b 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> > @@ -642,6 +642,8 @@ [Components.IA32]
> >        HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf
> >    }
> >  !endif
> >  
> > @@ -946,5 +948,7 @@ [Components.X64]
> >        HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf
> >    }
> >  !endif
> > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> > index 362eb789c712..aa3efc5e73b9 100644
> > --- a/OvmfPkg/OvmfPkgX64.dsc
> > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > @@ -641,6 +641,8 @@ [Components]
> >        HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf
> >    }
> >  !endif
> >  
> > @@ -944,5 +946,7 @@ [Components]
> >        HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf
> >        NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf
> > +      NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf
> >    }
> >  !endif
> > 
> 
> this patch looks good to me, but we'll have to delay it until after the
> stable tag (see "EDK II Stable Tag release edk2-stable201808 and quiet
> period starting today").
> 
> Meanwhile, can you please repost the patch with some commit message
> updates (including the subject): we're not really resolving these
> libraries for OvmfPkg; instead we link them into Tcg2Pei and Tcg2Dxe via
> NULL class resolution. So I suggest the following subject:
> 
>   OvmfPkg: link Sha384 and Sha512 support into Tcg2Pei and Tcg2Dxe
> 
> Please try to replace the "resolve those two libraries" expression in
> the commit message similarly.
Sure. Will repost the patch after modifying the title and description.

Thanks,

Gary Lin

> 
> Thanks!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-08-15  1:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14  7:36 [PATCH 1/1] OvmfPkg: Resolve HashInstanceLibSha384 and HashInstanceLibSha512 Gary Lin
2018-08-14 16:37 ` Laszlo Ersek
2018-08-15  1:51   ` Gary Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180815015130.GC31095@GaryWorkstation \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox