From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=195.135.221.5; helo=smtp.nue.novell.com; envelope-from=glin@suse.com; receiver=edk2-devel@lists.01.org Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE197210EFB01 for ; Tue, 14 Aug 2018 18:51:57 -0700 (PDT) Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Wed, 15 Aug 2018 03:51:55 +0200 Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.202]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Wed, 15 Aug 2018 02:51:35 +0100 Date: Wed, 15 Aug 2018 09:51:30 +0800 From: Gary Lin To: Laszlo Ersek Cc: edk2-devel@lists.01.org, Jordan Justen Message-ID: <20180815015130.GC31095@GaryWorkstation> References: <20180814073628.20448-1-glin@suse.com> <7757580c-0799-105c-401a-5b140082a905@redhat.com> MIME-Version: 1.0 In-Reply-To: <7757580c-0799-105c-401a-5b140082a905@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [PATCH 1/1] OvmfPkg: Resolve HashInstanceLibSha384 and HashInstanceLibSha512 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 01:51:58 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Aug 14, 2018 at 06:37:51PM +0200, Laszlo Ersek wrote: > Hi Gary, > > (+ Marc-André) > > On 08/14/18 09:36, Gary Lin wrote: > > Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those > > two libraries to enable SHA384 and SHA512 support in TPM. > > > > Cc: Ard Biesheuvel > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Gary Lin > > --- > > OvmfPkg/OvmfPkgIa32.dsc | 4 ++++ > > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ > > OvmfPkg/OvmfPkgX64.dsc | 4 ++++ > > 3 files changed, 12 insertions(+) > > > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index a28b511d5c2f..9f07e75050c0 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -634,6 +634,8 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > > } > > !endif > > > > @@ -936,5 +938,7 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > > } > > !endif > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > > index 115d0c01ff5c..a4eaeb808c6b 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -642,6 +642,8 @@ [Components.IA32] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > > } > > !endif > > > > @@ -946,5 +948,7 @@ [Components.X64] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > > } > > !endif > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index 362eb789c712..aa3efc5e73b9 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -641,6 +641,8 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > > } > > !endif > > > > @@ -944,5 +946,7 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > > + NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > > } > > !endif > > > > this patch looks good to me, but we'll have to delay it until after the > stable tag (see "EDK II Stable Tag release edk2-stable201808 and quiet > period starting today"). > > Meanwhile, can you please repost the patch with some commit message > updates (including the subject): we're not really resolving these > libraries for OvmfPkg; instead we link them into Tcg2Pei and Tcg2Dxe via > NULL class resolution. So I suggest the following subject: > > OvmfPkg: link Sha384 and Sha512 support into Tcg2Pei and Tcg2Dxe > > Please try to replace the "resolve those two libraries" expression in > the commit message similarly. Sure. Will repost the patch after modifying the title and description. Thanks, Gary Lin > > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel