From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition
Date: Wed, 15 Aug 2018 14:29:27 +0100 [thread overview]
Message-ID: <20180815132927.33dhuiefcxo2dz4b@bivouac.eciton.net> (raw)
In-Reply-To: <1533890975-13055-2-git-send-email-haojian.zhuang@linaro.org>
Hi Haojian,
On Fri, Aug 10, 2018 at 04:49:33PM +0800, Haojian Zhuang wrote:
> Fix the LDO9_VSET register definition in PMIC.
Could you add some more detail to the commit message, please?:
What register was accidentally read/written before?
Does this change resolve a user-visible issue or just a hypothetical
one?
/
Leif
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
> Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
> index 5fbf32267657..6e0587f7783a 100644
> --- a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
> +++ b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
> @@ -58,7 +58,7 @@
> #define USB3OTG_PHY_CR_CAP_ADDR (1 << 0)
>
> #define PMU_REG_BASE 0xFFF34000
> -#define PMIC_LDO9_VSET_REG (PMU_REG_BASE + (0x068 << 2))
> +#define PMIC_LDO9_VSET_REG (PMU_REG_BASE + (0x06b << 2))
> #define LDO9_VSET_MASK (7 << 0)
>
> #define PMIC_LDO16_ONOFF_ECO_REG (PMU_REG_BASE + (0x078 << 2))
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-08-15 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 8:49 [PATCH v1 edk-platforms 0/3] enable eMMC/SD driver on HiKey Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition Haojian Zhuang
2018-08-15 13:29 ` Leif Lindholm [this message]
2018-08-16 1:50 ` Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 edk-platforms 2/3] Platform/HiKey960: enable SD controller Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 edk-platforms 3/3] Platform/HiKey: enable SD/MMC controller on HiKey Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815132927.33dhuiefcxo2dz4b@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox