public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Songpeng Li <songpeng.li@intel.com>
To: edk2-devel@lists.01.org
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH 3/5] NetworkPkg: TcpDxe: Remove the redundant code.
Date: Thu, 16 Aug 2018 09:37:55 +0800	[thread overview]
Message-ID: <20180816013757.9680-4-songpeng.li@intel.com> (raw)
In-Reply-To: <20180816013757.9680-1-songpeng.li@intel.com>

The function TcpPawsOK that is never called have been removed.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
 NetworkPkg/TcpDxe/TcpOption.c | 32 +-------------------------------
 NetworkPkg/TcpDxe/TcpOption.h | 18 +-----------------
 2 files changed, 2 insertions(+), 48 deletions(-)

diff --git a/NetworkPkg/TcpDxe/TcpOption.c b/NetworkPkg/TcpDxe/TcpOption.c
index bacce1070d..bd1c2b9c27 100644
--- a/NetworkPkg/TcpDxe/TcpOption.c
+++ b/NetworkPkg/TcpDxe/TcpOption.c
@@ -1,7 +1,7 @@
 /** @file
   Routines to process TCP option.
 
-  Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -342,33 +342,3 @@ TcpParseOption (
 
   return 0;
 }
-
-/**
-  Check the segment against PAWS.
-
-  @param[in]  Tcb     Pointer to the TCP_CB of this TCP instance.
-  @param[in]  TSVal   The timestamp value.
-
-  @retval     1       The segment passed the PAWS check.
-  @retval     0       The segment failed to pass the PAWS check.
-
-**/
-UINT32
-TcpPawsOK (
-  IN TCP_CB *Tcb,
-  IN UINT32 TSVal
-  )
-{
-  //
-  // PAWS as defined in RFC1323, buggy...
-  //
-  if (TCP_TIME_LT (TSVal, Tcb->TsRecent) &&
-      TCP_TIME_LT (Tcb->TsRecentAge + TCP_PAWS_24DAY, mTcpTick)
-      ) {
-
-    return 0;
-
-  }
-
-  return 1;
-}
diff --git a/NetworkPkg/TcpDxe/TcpOption.h b/NetworkPkg/TcpDxe/TcpOption.h
index 0ccadb9536..e50fb9b129 100644
--- a/NetworkPkg/TcpDxe/TcpOption.h
+++ b/NetworkPkg/TcpDxe/TcpOption.h
@@ -1,7 +1,7 @@
 /** @file
   Tcp option's routine header file.
 
-  Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -126,20 +126,4 @@ TcpParseOption (
   IN OUT TCP_OPTION *Option
   );
 
-/**
-  Check the segment against PAWS.
-
-  @param[in]  Tcb     Pointer to the TCP_CB of this TCP instance.
-  @param[in]  TSVal   The timestamp value.
-
-  @retval     1       The segment passed the PAWS check.
-  @retval     0       The segment failed to pass the PAWS check.
-
-**/
-UINT32
-TcpPawsOK (
-  IN TCP_CB *Tcb,
-  IN UINT32 TSVal
-  );
-
 #endif
-- 
2.18.0.windows.1



  parent reply	other threads:[~2018-08-16  1:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16  1:37 [PATCH 0/5] NetworkPkg: Remove the redundant code and definition Songpeng Li
2018-08-16  1:37 ` [PATCH 1/5] NetworkPkg: IScsiDxe: " Songpeng Li
2018-08-16 19:15   ` Laszlo Ersek
2018-08-16  1:37 ` [PATCH 2/5] NetworkPkg: IpSecDxe: Remove the redundant code Songpeng Li
2018-08-16  1:37 ` Songpeng Li [this message]
2018-08-16 19:17   ` [PATCH 3/5] NetworkPkg: TcpDxe: " Laszlo Ersek
2018-08-16  1:37 ` [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant definition Songpeng Li
2018-08-16 19:26   ` Laszlo Ersek
2018-08-17  1:36     ` Li, Songpeng
2018-08-17 11:00       ` Laszlo Ersek
2018-08-16  1:37 ` [PATCH 5/5] NetworkPkg: UefiPxeBcDxe: Remove the redundant code Songpeng Li
2018-08-16 19:28   ` Laszlo Ersek
2018-08-23  8:25 ` [PATCH 0/5] NetworkPkg: Remove the redundant code and definition Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180816013757.9680-4-songpeng.li@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox