From: Songpeng Li <songpeng.li@intel.com>
To: edk2-devel@lists.01.org
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH 5/5] NetworkPkg: UefiPxeBcDxe: Remove the redundant code.
Date: Thu, 16 Aug 2018 09:37:57 +0800 [thread overview]
Message-ID: <20180816013757.9680-6-songpeng.li@intel.com> (raw)
In-Reply-To: <20180816013757.9680-1-songpeng.li@intel.com>
The function PxeBcFreeBootFileOption that is never called
have been removed.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 23 -----------------------
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 10 ----------
2 files changed, 33 deletions(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
index c06b0242bb..5bbc1922a6 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
@@ -202,29 +202,6 @@ PxeBcCacheDhcp6Packet (
return EFI_SUCCESS;
}
-
-/**
- Free all the nodes in the list for boot file.
-
- @param[in] Head The pointer to the head of list.
-
-**/
-VOID
-PxeBcFreeBootFileOption (
- IN LIST_ENTRY *Head
- )
-{
- LIST_ENTRY *Entry;
- LIST_ENTRY *NextEntry;
- PXEBC_DHCP6_OPTION_NODE *Node;
-
- NET_LIST_FOR_EACH_SAFE (Entry, NextEntry, Head) {
- Node = NET_LIST_USER_STRUCT (Entry, PXEBC_DHCP6_OPTION_NODE, Link);
- RemoveEntryList (Entry);
- FreePool (Node);
- }
-}
-
/**
Retrieve the boot server address using the EFI_DNS6_PROTOCOL.
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
index f3dcd89743..d6e6745f0d 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
@@ -116,16 +116,6 @@ typedef struct {
} PXEBC_DHCP6_PACKET_CACHE;
-/**
- Free all the nodes in the boot file list.
-
- @param[in] Head The pointer to the head of the list.
-
-**/
-VOID
-PxeBcFreeBootFileOption (
- IN LIST_ENTRY *Head
- );
/**
--
2.18.0.windows.1
next prev parent reply other threads:[~2018-08-16 1:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 1:37 [PATCH 0/5] NetworkPkg: Remove the redundant code and definition Songpeng Li
2018-08-16 1:37 ` [PATCH 1/5] NetworkPkg: IScsiDxe: " Songpeng Li
2018-08-16 19:15 ` Laszlo Ersek
2018-08-16 1:37 ` [PATCH 2/5] NetworkPkg: IpSecDxe: Remove the redundant code Songpeng Li
2018-08-16 1:37 ` [PATCH 3/5] NetworkPkg: TcpDxe: " Songpeng Li
2018-08-16 19:17 ` Laszlo Ersek
2018-08-16 1:37 ` [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant definition Songpeng Li
2018-08-16 19:26 ` Laszlo Ersek
2018-08-17 1:36 ` Li, Songpeng
2018-08-17 11:00 ` Laszlo Ersek
2018-08-16 1:37 ` Songpeng Li [this message]
2018-08-16 19:28 ` [PATCH 5/5] NetworkPkg: UefiPxeBcDxe: Remove the redundant code Laszlo Ersek
2018-08-23 8:25 ` [PATCH 0/5] NetworkPkg: Remove the redundant code and definition Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816013757.9680-6-songpeng.li@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox