From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=songpeng.li@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E24DD210F2D13 for ; Wed, 15 Aug 2018 18:39:06 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2018 18:39:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,245,1531810800"; d="scan'208";a="254456850" Received: from songpeng.ccr.corp.intel.com ([10.239.158.47]) by fmsmga005.fm.intel.com with ESMTP; 15 Aug 2018 18:39:05 -0700 From: Songpeng Li To: edk2-devel@lists.01.org Cc: Jiaxin Wu , Siyuan Fu , Laszlo Ersek Date: Thu, 16 Aug 2018 09:37:57 +0800 Message-Id: <20180816013757.9680-6-songpeng.li@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180816013757.9680-1-songpeng.li@intel.com> References: <20180816013757.9680-1-songpeng.li@intel.com> Subject: [PATCH 5/5] NetworkPkg: UefiPxeBcDxe: Remove the redundant code. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 01:39:07 -0000 The function PxeBcFreeBootFileOption that is never called have been removed. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Laszlo Ersek Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 23 ----------------------- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 10 ---------- 2 files changed, 33 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c index c06b0242bb..5bbc1922a6 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c @@ -202,29 +202,6 @@ PxeBcCacheDhcp6Packet ( return EFI_SUCCESS; } - -/** - Free all the nodes in the list for boot file. - - @param[in] Head The pointer to the head of list. - -**/ -VOID -PxeBcFreeBootFileOption ( - IN LIST_ENTRY *Head - ) -{ - LIST_ENTRY *Entry; - LIST_ENTRY *NextEntry; - PXEBC_DHCP6_OPTION_NODE *Node; - - NET_LIST_FOR_EACH_SAFE (Entry, NextEntry, Head) { - Node = NET_LIST_USER_STRUCT (Entry, PXEBC_DHCP6_OPTION_NODE, Link); - RemoveEntryList (Entry); - FreePool (Node); - } -} - /** Retrieve the boot server address using the EFI_DNS6_PROTOCOL. diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h index f3dcd89743..d6e6745f0d 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h @@ -116,16 +116,6 @@ typedef struct { } PXEBC_DHCP6_PACKET_CACHE; -/** - Free all the nodes in the boot file list. - - @param[in] Head The pointer to the head of the list. - -**/ -VOID -PxeBcFreeBootFileOption ( - IN LIST_ENTRY *Head - ); /** -- 2.18.0.windows.1