From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A5AF210F93FE for ; Tue, 21 Aug 2018 14:45:49 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id l2-v6so10625040wme.1 for ; Tue, 21 Aug 2018 14:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zEg4nbFSOGKL6RkXLLb+WbO/WDWeiI/uSyF3BF+74I8=; b=buibTlfJ9Ponv1dt4LZHIrHneytFPIrYBidJpo0D+eaGOw19zpcnNZ9cn2fhIsPTL3 qD6zKshhtq731k+VA+Tf9lhHxvVqC9saXn/OLoKBf5DQs5yv59ODSucPOi3I76qAGgjN wxBBELiK7CkGqriIowu7VfVxnfqkt1VWGkMYs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zEg4nbFSOGKL6RkXLLb+WbO/WDWeiI/uSyF3BF+74I8=; b=aCwUplreZyJ2pBILh9lQUpPGe3kenE3/hMv99sJSiRw+zUH7MhiogDHxgCHYp6uRbx zkWyTUyo/mMfpVdKvWgSpVdOBXiC6bAszJiZsVUvdJQBF21OjmBclboRgKRwG8ecyGhJ 6ZS0wBt05vuCzzjz3u71t1O1dHaW42XjSVH2FIbo02hN+goph9OQpyTDOrSQKEgx2FJB bkdIq6mFTd+tWJCXPGS2sgU8S7T6X0aI9N/2UQXqFsSbop8E0CUjbFwNuxyPWPKt+rFy U/kVQCTzurMmH8Rdt1hxzbuUXeniePwWt7x2c1JBiZbZWuhjTsAa4LG2JJe8jT5LpZ7m 0vHA== X-Gm-Message-State: APzg51BkohRCaZDme1Al2wZRHhVB70DamfuKuKRVO3pBRQMw/E2FUfwH QY/abrj/32vxXF9696HBHRKE0A== X-Google-Smtp-Source: ANB0VdbuJWYW1TBiIFQJl/EypOYvefocyaAd20Fzq0pfvfStLY9vpAcnqJZM40aVBTKe7FKKd59cVg== X-Received: by 2002:a1c:f60c:: with SMTP id w12-v6mr676431wmc.80.1534887947593; Tue, 21 Aug 2018 14:45:47 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o134-v6sm455482wmd.9.2018.08.21.14.45.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Aug 2018 14:45:46 -0700 (PDT) Date: Tue, 21 Aug 2018 22:45:44 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180821214544.ukuogabw5vp6wpq3@bivouac.eciton.net> References: <20180816121239.44129-1-ming.huang@linaro.org> <20180816121239.44129-18-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180816121239.44129-18-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 17/36] Hisilicon/I2C: Fix a typo issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 21:45:49 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C library. It can (and should) go in before D06 support. For the three patches: Reviewed-by: Leif Lindholm Pushed as 4e6af5fa1b..342330470f. On Thu, Aug 16, 2018 at 08:12:20PM +0800, Ming Huang wrote: > Modify spedd to Speed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 2 +- > Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h > index d77aea509e..6fd7b8183e 100644 > --- a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h > @@ -81,7 +81,7 @@ > struct > { > UINT32 master : 1 ; > - UINT32 spedd : 2 ; > + UINT32 Speed : 2 ; > UINT32 slave_10bit : 1 ; > UINT32 master_10bit : 1 ; > UINT32 restart_en : 1 ; > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c > index 59633106ce..ed44ac204f 100644 > --- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c > @@ -158,7 +158,7 @@ I2CInit ( > > I2C_REG_READ (Base + I2C_CON_OFFSET, I2cControlReg.Val32); > I2cControlReg.bits.master = 1; > - I2cControlReg.bits.spedd = 0x1; > + I2cControlReg.bits.Speed = 0x1; > I2cControlReg.bits.restart_en = 1; > I2cControlReg.bits.slave_disable = 1; > I2C_REG_WRITE (Base + I2C_CON_OFFSET, I2cControlReg.Val32); > -- > 2.17.0 >