From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ming Huang <ming.huang@linaro.org>
Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org,
graeme.gregory@linaro.org, ard.biesheuvel@linaro.org,
michael.d.kinney@intel.com, lersek@redhat.com,
guoheyi@huawei.com, wanghuiqiang@huawei.com,
huangming23@huawei.com, zhangjinsong2@huawei.com,
huangdaode@hisilicon.com, john.garry@huawei.com,
xinliang.liu@linaro.org
Subject: Re: [PATCH edk2-platforms v3 17/36] Hisilicon/I2C: Fix a typo issue
Date: Tue, 21 Aug 2018 22:48:56 +0100 [thread overview]
Message-ID: <20180821214856.nezdolpmjahb3gnn@bivouac.eciton.net> (raw)
In-Reply-To: <20180821214544.ukuogabw5vp6wpq3@bivouac.eciton.net>
Err, that was 13, 14 and 17 in v3.
In v2, it's 20, 21, 24.
(I pushed the right patches, I just replied to the wrong email.)
On Tue, Aug 21, 2018 at 10:45:44PM +0100, Leif Lindholm wrote:
> Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C
> library. It can (and should) go in before D06 support.
>
> For the three patches:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Pushed as 4e6af5fa1b..342330470f.
>
> On Thu, Aug 16, 2018 at 08:12:20PM +0800, Ming Huang wrote:
> > Modify spedd to Speed.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ming Huang <ming.huang@linaro.org>
> > ---
> > Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 2 +-
> > Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
> > index d77aea509e..6fd7b8183e 100644
> > --- a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
> > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
> > @@ -81,7 +81,7 @@
> > struct
> > {
> > UINT32 master : 1 ;
> > - UINT32 spedd : 2 ;
> > + UINT32 Speed : 2 ;
> > UINT32 slave_10bit : 1 ;
> > UINT32 master_10bit : 1 ;
> > UINT32 restart_en : 1 ;
> > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
> > index 59633106ce..ed44ac204f 100644
> > --- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
> > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
> > @@ -158,7 +158,7 @@ I2CInit (
> >
> > I2C_REG_READ (Base + I2C_CON_OFFSET, I2cControlReg.Val32);
> > I2cControlReg.bits.master = 1;
> > - I2cControlReg.bits.spedd = 0x1;
> > + I2cControlReg.bits.Speed = 0x1;
> > I2cControlReg.bits.restart_en = 1;
> > I2cControlReg.bits.slave_disable = 1;
> > I2C_REG_WRITE (Base + I2C_CON_OFFSET, I2cControlReg.Val32);
> > --
> > 2.17.0
> >
next prev parent reply other threads:[~2018-08-21 21:49 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 12:12 [PATCH edk2-platforms v3 00/36] Upload for D06 platform Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 01/36] Hisilicon/D0x: Unify FlashFvbDxe driver Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 02/36] Hisilicon/D0X: Rename the global variable gDS3231RtcDevice Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 03/36] Hisilicon/D06: Add several base file for D06 Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 04/36] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 05/36] Platform/Hisilicon/D06: Add edk2-non-osi components for D06 Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 06/36] Hisilicon/D06: Add OemMiscLibD06 Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 07/36] Silicon/Hisilicon/D06: Wait for all disk ready Ming Huang
2018-08-22 10:25 ` Leif Lindholm
2018-08-22 15:00 ` Ming
2018-08-16 12:12 ` [PATCH edk2-platforms v3 08/36] Silicon/Hisilicon/Acpi: Unify HisiAcipPlatformDxe Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 09/36] Hisilicon/D06: Add Debug Serial Port Init Driver Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 10/36] Hisilicon/D06: Add ACPI Tables for D06 Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 11/36] Hisilicon/D06: Add Hi1620OemConfigUiLib Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 12/36] Silicon/Hisilicon/D06: Stop watchdog Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 13/36] Hisilicon/I2C: Modify I2CLib.c for coding style Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 14/36] Silicon/Hisilicon/I2C: Refactor I2C library Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 15/36] Silicon/Hisilicon/D06: Fix I2C enable fail issue for D06 Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 16/36] Silicon/Hisilicon/D06: Add I2C delay for HNS auto config Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 17/36] Hisilicon/I2C: Fix a typo issue Ming Huang
2018-08-21 21:45 ` Leif Lindholm
2018-08-21 21:48 ` Leif Lindholm [this message]
2018-08-16 12:12 ` [PATCH edk2-platforms v3 18/36] Silicon/Hisilicon/D06: Optimize HNS config CDR post time Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 19/36] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP" Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 20/36] Hisilicon/Hi1620: Add ACPI PPTT table Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 21/36] Platform/Hisilicon/D06: Enable ACPI PPTT Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 22/36] Platform/Hisilicon/D06: Add OemNicLib Ming Huang
2018-08-22 14:55 ` Leif Lindholm
2018-08-16 12:12 ` [PATCH edk2-platforms v3 23/36] Platform/Hisilicon/D06: Add OemNicConfig2P Driver Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 24/36] Hisilicon/D0x: Update SMBIOS type9 info Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 25/36] Platform/Hisilicon/D06: Add EarlyConfigPeim peim Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 26/36] Platform/Hisilicon/D06: Add PciHostBridgeLib Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 27/36] Hisilicon/D06: add apei driver Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 28/36] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 29/36] Platform/Hisilicon/D06: Add capsule upgrade support Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 30/36] Silicon/Hisilicon/D06: Modify for close slave core clock Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 31/36] Silicon/Hisilicon/D06: Add I2C Bus Exception handle function Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch Ming Huang
2018-08-21 21:11 ` Leif Lindholm
[not found] ` <6cf5a20d-b648-1ae8-043d-75f241fc4123@linaro.org>
2018-08-23 10:50 ` Ming
2018-08-23 11:12 ` Leif Lindholm
2018-08-23 11:58 ` Ming
2018-08-16 12:12 ` [PATCH edk2-platforms v3 33/36] Silicon/Hisilicon/setup: Support SMMU switch Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 34/36] Hisilicon/D06: Add PciPlatformLib Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 35/36] Hisilicon/D06: Add edk2-non-osi Shell components Ming Huang
2018-08-16 12:12 ` [PATCH edk2-platforms v3 36/36] Platform/Hisilicon/D0x: Update version string to 18.08 Ming Huang
2018-08-17 12:23 ` [PATCH edk2-platforms v3 00/36] Upload for D06 platform Leif Lindholm
2018-08-18 6:20 ` Ming
2018-08-22 16:40 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821214856.nezdolpmjahb3gnn@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox