From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2CB6620945B9C for ; Wed, 22 Aug 2018 02:49:05 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id o18-v6so1548611wmc.0 for ; Wed, 22 Aug 2018 02:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=om7qfvtaFZvWy26wWNyRJTDk7lzV/2TdL/WXcdcJfiU=; b=EQBDk1H90OvZOZfn4V/VB8fVW59o7GlfPYQ0c3CMdZUobvmQRyljC6SGz8W9NGHyR6 di0882i6r0w9zbCZrJuF9ZW8kudx2GLx/An4JRysWi1Jp7xv5615uWOGaDCMPEDFrOmQ EYoOdkRSDFP5dKbNsfUtOOuxJ2LFCa5LN6LMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=om7qfvtaFZvWy26wWNyRJTDk7lzV/2TdL/WXcdcJfiU=; b=JbdpiesfeyAP89btt3rf3bZFdsTahhM3r4a7CXhU3mtcgvvWJr5+lQLSUCOJRsB+WX rApHwvjc/aYbe6OY/C3XtUyKJfpIcrHwIEk3aforjFJGT4dhGEONqt1o/0Aeao22Lpko 0oVe6TbQvGC5zzt39NYsXb4bM8nSVIbUNJE+y7B3Tj/MjPp93gX/RM+a8XuPWumGujMo nrcduWrOID7b/RLC8ygOjxC1I8iQLYALiN26n4vOFdWUb6aS1tnKmXwqi8v9a+Rki6+r XwknIB3Z5NNDuHhASO+XdpN5KwNrBsyLRCi05i1dU15MWcU/4qYBfG5rkzdAj7pvrIIk oQuw== X-Gm-Message-State: APzg51AEkD6Uf4EHA7kRHRZsNZgXqmrQ0fXen9Y4UgT+wLAG0cNKNRm8 pP7aGAI/hpyPM22ZwalhNXnJCQ== X-Google-Smtp-Source: ANB0VdY1QHHV2OBLHYYbJv/x0S71a4iAsnL6HTl0s7LVPDgyV+cX7nWQYkQTdzfaGD/dZVOzkXX+NQ== X-Received: by 2002:a1c:2d54:: with SMTP id t81-v6mr2009984wmt.31.1534931344281; Wed, 22 Aug 2018 02:49:04 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 144-v6sm2339788wma.19.2018.08.22.02.49.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 02:49:03 -0700 (PDT) Date: Wed, 22 Aug 2018 10:49:01 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180822094901.6oavgeeqpzckqjwx@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-13-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180814080903.50466-13-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 09:49:06 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote: > Add PcdCoreCount to fix build issue while add binary components. This commit message fails to describe what is being done, apart from a single thing that should be a separate patch. Pleas add a proper commit message describing which components are being imported. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.dsc | 7 +++++++ > Platform/Hisilicon/D06/D06.fdf | 17 +++++++++++++++++ > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 2 ++ > 3 files changed, 26 insertions(+) > > diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > index 2275586ff3..a47806f391 100644 > --- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > +++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > @@ -28,6 +28,7 @@ > > [Packages] > ArmPkg/ArmPkg.dec > + ArmPlatformPkg/ArmPlatformPkg.dec > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > IntelFrameworkPkg/IntelFrameworkPkg.dec > @@ -52,6 +53,7 @@ > gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED > > [Pcd] > + gArmPlatformTokenSpaceGuid.PcdCoreCount > gHisiTokenSpaceGuid.PcdCPUInfo > gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz And please submit this as a separate patch, explaining why the change is needed. If it is only needed by one of the binary modules imported as part of the current patch, place it immediately preceding this. If it resolves some other issue, please insert it as early in the set as possible. / Leif > > -- > 2.17.0 >