Re: [PATCH edk2-platforms v2 13/43] Hisilicon/D06: Add OemMiscLibD06

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Aug 14, 2018 at 04:08:33PM +0800, Ming Huang wrote:
> This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
> use for several modules like PciHostBridgeLib and Smbios.
> Enlarge macro PCIEDEVICE_REPORT_MAX for D06.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
>  Platform/Hisilicon/D06/D06.dsc                                          |   1 +
>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf          |  47 +++
>  Silicon/Hisilicon/Include/Library/OemMiscLib.h                          |   6 +-
>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c          | 432 ++++++++++++++++++++
>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c            | 132 ++++++
>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni |  64 +++
>  6 files changed, 681 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
> index 94454569f6..9ca7160dad 100644
> --- a/Platform/Hisilicon/D06/D06.dsc
> +++ b/Platform/Hisilicon/D06/D06.dsc
> @@ -70,6 +70,7 @@
>  
>    TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>    RealTimeClockLib|Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf
> +  OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
>    OemAddressMapLib|Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.inf
>    PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf
>  

> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni
> new file mode 100644
> index 0000000000..046fa05dff
> --- /dev/null
> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni
> @@ -0,0 +1,64 @@
> +// *++
> +//
> +// Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>

Add your own copyright year.
With that, the next revision can include:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> +//
> +// This program and the accompanying materials
> +// are licensed and made available under the terms and conditions of the BSD License
> +// which accompanies this distribution.  The full text of the license may be found at
> +// http://opensource.org/licenses/bsd-license.php
> +//
> +// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +//
> +// --*/
> +
> +/=#
> +
> +#langdef en-US "English"
> +
> +//
> +// Begin English Language Strings
> +//
> +#string STR_MEMORY_SUBCLASS_UNKNOWN    #language en-US  "Unknown"
> +
> +//
> +// DIMM Device Locator strings
> +
> +// D06
> +#string STR_LEMON_C10_DIMM_000     #language en-US "J5"
> +#string STR_LEMON_C10_DIMM_001     #language en-US "J6"
> +#string STR_LEMON_C10_DIMM_010     #language en-US "J7"
> +#string STR_LEMON_C10_DIMM_011     #language en-US "J8"
> +#string STR_LEMON_C10_DIMM_020     #language en-US "J9"
> +#string STR_LEMON_C10_DIMM_021     #language en-US "J10"
> +#string STR_LEMON_C10_DIMM_030     #language en-US "J11"
> +#string STR_LEMON_C10_DIMM_031     #language en-US "J12"
> +#string STR_LEMON_C10_DIMM_040     #language en-US "J13"
> +#string STR_LEMON_C10_DIMM_041     #language en-US "J14"
> +#string STR_LEMON_C10_DIMM_050     #language en-US "J15"
> +#string STR_LEMON_C10_DIMM_051     #language en-US "J16"
> +#string STR_LEMON_C10_DIMM_060     #language en-US "J17"
> +#string STR_LEMON_C10_DIMM_061     #language en-US "J18"
> +#string STR_LEMON_C10_DIMM_070     #language en-US "J19"
> +#string STR_LEMON_C10_DIMM_071     #language en-US "J20"
> +#string STR_LEMON_C10_DIMM_100     #language en-US "J21"
> +#string STR_LEMON_C10_DIMM_101     #language en-US "J22"
> +#string STR_LEMON_C10_DIMM_110     #language en-US "J23"
> +#string STR_LEMON_C10_DIMM_111     #language en-US "J24"
> +#string STR_LEMON_C10_DIMM_120     #language en-US "J25"
> +#string STR_LEMON_C10_DIMM_121     #language en-US "J26"
> +#string STR_LEMON_C10_DIMM_130     #language en-US "J27"
> +#string STR_LEMON_C10_DIMM_131     #language en-US "J28"
> +#string STR_LEMON_C10_DIMM_140     #language en-US "J29"
> +#string STR_LEMON_C10_DIMM_141     #language en-US "J30"
> +#string STR_LEMON_C10_DIMM_150     #language en-US "J31"
> +#string STR_LEMON_C10_DIMM_151     #language en-US "J32"
> +#string STR_LEMON_C10_DIMM_160     #language en-US "J33"
> +#string STR_LEMON_C10_DIMM_161     #language en-US "J34"
> +#string STR_LEMON_C10_DIMM_170     #language en-US "J35"
> +#string STR_LEMON_C10_DIMM_171     #language en-US "J36"
> +
> +//
> +// End English Language Strings
> +//
> +
> -- 
> 2.17.0
>