From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E683210FC0A4 for ; Wed, 22 Aug 2018 07:33:23 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id i134-v6so12179328wmf.0 for ; Wed, 22 Aug 2018 07:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h6ndy2m5f6T1AdPTJuoUmmMhystpv8HdowYA8hGSyoI=; b=VATw4ePCweuumEjSYGKaADjDqUGYqz6dNd8VvuaQWAxlzpr5krYys3HGd9Tmf7WWhA APWm60tBiXAp1Wx1TxU3U1j/m6/UwapYlZVSHD+EPQS+UJrt9chJACnPRTK8WFeqPE3F uUKlKMwh6RYiJ2prYgkB6LydPODaUjOoQxNRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h6ndy2m5f6T1AdPTJuoUmmMhystpv8HdowYA8hGSyoI=; b=YGrEEYbBxblywscl5zixtCl8jEmE4D4LQyO4a+D9IrHMkY9lwQ/G6p5qyjtXpwJi1V dwZuyMC77ylhKOjD59baqWG4QzUVh4utViLO98QUPsIYo0OjVi/Jcc691ft2eF9WaAyb Mnqtvoixi8DQZBlmlL6rP0CI4KF+MlpR8twVgEKNDKHF79p0tP3fj+RJbny/IoT212o8 Rlik2svJs1gpOiwCjwAf5UmoIjrJOj3VmkQ/ptRI8SacSQxeOmiwG7QCIKFQybhXHsf3 YQwQdWUQV8O7+xHPKBKRIQsTtT2lpMP8kAd8+v+jjFd01odt3cSp/LjjhfiDT9YD5DOq oHzw== X-Gm-Message-State: APzg51AizTokwPoi9YoBxnRm/qdfESf+tbBM2uIDR5joOjQJva1AeuNK S3aIRiJ83u70x4R1XRAGykAHFQ== X-Google-Smtp-Source: ANB0VdbT1mkYmnSXli2OzUXPXpFZJqgLjq5OC+1zutydI6zTgpSTszfupdE+CrJ3BvQeoGRjI0EUhA== X-Received: by 2002:a1c:8406:: with SMTP id g6-v6mr2402191wmd.18.1534948401653; Wed, 22 Aug 2018 07:33:21 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v2-v6sm2014158wrs.54.2018.08.22.07.33.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 07:33:20 -0700 (PDT) Date: Wed, 22 Aug 2018 15:33:18 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Yang XinYi Message-ID: <20180822143318.z75oncqixnpbm6t4@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-27-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180814080903.50466-27-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 26/43] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 14:33:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 14, 2018 at 04:08:46PM +0800, Ming Huang wrote: > From: Yang XinYi > > Add Setup Item "EnableGOP" for D06, This Item only takes > effect on VGA device SM750. Feedback on v1 was: What is SM750? Please add more detail to commit message. Please address. Rest of patch is fine. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yang XinYi > --- > Silicon/Hisilicon/Include/Library/OemConfigData.h | 1 + > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 1 + > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr | 7 +++++++ > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni | 4 ++-- > 4 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Hisilicon/Include/Library/OemConfigData.h b/Silicon/Hisilicon/Include/Library/OemConfigData.h > index 478821ae2c..e4d5917046 100644 > --- a/Silicon/Hisilicon/Include/Library/OemConfigData.h > +++ b/Silicon/Hisilicon/Include/Library/OemConfigData.h > @@ -61,6 +61,7 @@ typedef struct { > UINT8 EnableSmmu; > UINT8 EnableFdtTable; > UINT8 EnableSpcr; > + UINT8 EnableGOP; > /*RAS Config*/ > UINT8 EnRasSupport; > UINT8 EnPoison; > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > index 1e3635307c..3ecae3759a 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > @@ -295,6 +295,7 @@ OemConfigUiLibConstructor ( > Configuration.EnableSmmu = 1; > Configuration.EnableFdtTable = 0; > Configuration.EnableSpcr = 0; > + Configuration.EnableGOP = 0; > // > //Set the default value of the Ras option > // > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > index 9e3ac73116..c0b6e294a6 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > @@ -38,4 +38,11 @@ form formid = MISC_CONFIG_FORM_ID, > option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; > endoneof; > > + oneof varid = OEM_CONFIG_DATA.EnableGOP, > + prompt = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER), > + help = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER_HELP), > + option text = STRING_TOKEN(STR_DISABLED), value = 0, flags = DEFAULT; > + option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; > + endoneof; > + > endform; > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > index 53eb1622c4..2fd92fedff 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > @@ -23,5 +23,5 @@ > #string STR_FDT_CONFIG_HELP #language en-US "Enable or Disable Fdt Table." > #string STR_ENABLE_SPCR_TABLE #language en-US "Support SPCR" > #string STR_ENABLE_SPCR_HELP #language en-US "Enable or Disable SPCR Table." > -#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB" > -#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer." > +#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB for SM750" > +#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer for SM750." > -- > 2.17.0 >