From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DFC6210F41CD for ; Wed, 22 Aug 2018 07:39:32 -0700 (PDT) Received: by mail-wm0-x241.google.com with SMTP id y2-v6so2273052wma.1 for ; Wed, 22 Aug 2018 07:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+ZGskD78DbPP/NTOsk7JFeLWEbSAEl90BkJqR+PBiAI=; b=dF155NwMv8eNAjZo+x+sHAQSInM2Jy1+Re+e0xYXQ01UsHvZ3xhMUMzsK7pjxK+QwJ PPb5IuCloUSv9UjTW2U7icSi6c/esoCXMqKm8F5H+x4J98rbvvYHBCJ2Za/GNDMkkzyr fVPzyQ8Gw9zk4ikb+GfG/Yzaydy+41g6hpllc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+ZGskD78DbPP/NTOsk7JFeLWEbSAEl90BkJqR+PBiAI=; b=Z+1llGbro94JiCZQpVfU+BWX3pqfjL4jaWeoTsOHZv5x/OS2qcb+J32pUzPUTKYcMn elCXBt9LFlEhfRDWDBO8oszQjREhj7eXsGGFv3+xMtPPpInk0rodH3oYf3BUcaq5gZhV g3kAzLlh8kLjchlzRDNLHXXFBqfbv/MW5k5XuFLQ5EqNoDmnJxO/fubvT5sLJ35IlIsV dQk2zNAp1InHG3RPb+Om/su96gRg0Fz3xgn4hX+eQdiQmdzLc5TR0MxOjBT8IJ2Sa231 JfegBB0HEOMNTDyjILclxj1Fvc76kJGE3Hk7soNnx2HIVjl3LDOmlQeLQ2nUU3NsKkm0 kYKA== X-Gm-Message-State: APzg51CzSs23vLK8249meGP5t4G+a16Eu3RjdrHgMI/cMyRcZJezXoa7 Y8BnIrspyGDumzqvCv5CyQus6g== X-Google-Smtp-Source: ANB0VdZgheP+RXPXmYjn8Tr8mssaAtpj8zaJvI/jH7Xr8efg6X6lk4iR6MvjpI4hSo0dsnap6m7B3w== X-Received: by 2002:a1c:e382:: with SMTP id a124-v6mr1299228wmh.121.1534948771027; Wed, 22 Aug 2018 07:39:31 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v46-v6sm3726424wrc.63.2018.08.22.07.39.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 07:39:30 -0700 (PDT) Date: Wed, 22 Aug 2018 15:39:28 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Heyi Guo Message-ID: <20180822143928.4dnouv4w3dk57xfo@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-28-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180814080903.50466-28-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 27/43] Hisilicon/Hi1620: Add ACPI PPTT table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 14:39:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 14, 2018 at 04:08:47PM +0800, Ming Huang wrote: > From: Heyi Guo > > This driver fetches information from MADT, so it is adaptable for > partial good and 1P/2P, since MADT is updated for different > configurations by certain mechanism. > > Since L2 cache is also private resource of core, so we need to set the > next level of cache for L1I and L1D, which is important for OS to > parse cache hierarchy. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo No, Signed-off-by: Ming Huang You are signing off on these patches being correclty licensed and permitted to contribute under the Contribution agreement. The above is equivalent to "Heyi says it's fine". "Heyi wrote this code" is reflected through the From: tag above. Looking back, I notice this is true for many patches in the set. Please address throughout v4. I have no further comment on this patch, so with that change: Reviewed-by: Leif Lindholm > --- > Silicon/Hisilicon/Hi1620/Pptt/Pptt.inf | 48 ++ > Silicon/Hisilicon/Hi1620/Pptt/Pptt.h | 68 +++ > Silicon/Hisilicon/Hi1620/Pptt/Pptt.c | 543 ++++++++++++++++++++ > 3 files changed, 659 insertions(+)