From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1FEA4210FC0AE for ; Wed, 22 Aug 2018 07:57:26 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z96-v6so1864703wrb.8 for ; Wed, 22 Aug 2018 07:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Kuuyy28L0faxXg/JwylC18MQy0PtxQIC4mZw2rDRci0=; b=WuvQPKJzI6lfmT1+fkWroQTUlPpkaXLC3utiUORBJ+WZA/5TXX6E49QqxsDGWiNHNW OuxypPWnzPL7kzkPyyq53i7wwgRCaI2ZZ61ue395U8j3KtTde6VWvKWWNZMg9nVrjJI5 bnD6fGRm8UZi348acyfRB8CkhaQw3QW+0AbLk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Kuuyy28L0faxXg/JwylC18MQy0PtxQIC4mZw2rDRci0=; b=AYyhoLYLpBMko+Q7AUDsuRGkF6rn4D9wCw7OT6OcgYZLL/V+doO1fkRm4OJclxbefv xJdEOk5/d/VPh2CCx0jn0FlfBV3uNIBMYeAfBES861cBeWiVmhriu3H/Rpd2Slt+U8Pd 4hpma8beNv0nXxKG/sKGOTk0zdBvNrS2Vx9aB4EtdE2tm0FRomokDPdC465YdqKRL4Qa bnMNXV5i0wGjS1CszvUPlhrpUTt2WZEE0/h7jF1/LP6l3uJSf0voAMFZWHcuLiy+rFMz ujxUGXnEsGlNV9KchRGzKvyUUsNLQPCrAKXRQLT38B5siPky0BJJwRzHzMIHUXBcRlZ4 s6WQ== X-Gm-Message-State: APzg51Aq2uFW0d7u5VwuakwudfJKvyte0qtKpjNKJZgnDHbpZnbIYvfn DXhhvPJ2KdcRuipUeg3TzUc5/A== X-Google-Smtp-Source: ANB0VdYgxsKKTCgRIn3Yu6dHC6Pxyfy/XL6KnjmqUdVB00hDYYQPocrEudMjhP0P8atn79P0cWE0WA== X-Received: by 2002:adf:d110:: with SMTP id a16-v6mr12242790wri.17.1534949844684; Wed, 22 Aug 2018 07:57:24 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l10-v6sm2231558wre.0.2018.08.22.07.57.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 07:57:23 -0700 (PDT) Date: Wed, 22 Aug 2018 15:57:22 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180822145722.ckv5mrok6ttafn5u@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-31-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180814080903.50466-31-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 30/43] Platform/Hisilicon/D06: Add OemNicConfig2P Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 14:57:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 14, 2018 at 04:08:50PM +0800, Ming Huang wrote: > This Driver provide Get/Set Mac function. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/D06.dsc | 2 +- > Platform/Hisilicon/D06/D06.fdf | 2 +- > Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.inf | 43 ++++++++++++ > Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig.h | 25 +++++++ > Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.c | 71 ++++++++++++++++++++ > 5 files changed, 141 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index e18badf3b3..5571028f42 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -285,7 +285,7 @@ > # > ArmPkg/Drivers/CpuDxe/CpuDxe.inf > MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > - > + Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf { > diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf > index 5bb779d2e4..184d5d4dcf 100644 > --- a/Platform/Hisilicon/D06/D06.fdf > +++ b/Platform/Hisilicon/D06/D06.fdf > @@ -174,7 +174,7 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > INF Platform/Hisilicon/D06/Drivers/SFC/SfcDxeDriver.inf > > - > + INF Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.inf > INF Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf > INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > diff --git a/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.inf b/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.inf > new file mode 100644 > index 0000000000..a91f2b6005 > --- /dev/null > +++ b/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.inf > @@ -0,0 +1,43 @@ > +#/** @file > +# > +# Copyright (c) 2016-2018, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2016-2018, Linaro Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = OemNicConfigPangea > + FILE_GUID = edc95319-ebe9-4c38-96af-1d203fb85231 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = OemNicConfigEntry > + > +[Sources.common] > + OemNicConfig2P.c > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Silicon/Hisilicon/HisiPkg.dec > + > +[Protocols] > + gHisiBoardNicProtocolGuid ##Produce > + > +[LibraryClasses] > + DebugLib > + IoLib > + OemNicLib > + UefiBootServicesTableLib > + UefiDriverEntryPoint > + > +[Depex] > + TRUE > diff --git a/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig.h b/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig.h > new file mode 100644 > index 0000000000..35228fdf1d > --- /dev/null > +++ b/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig.h > @@ -0,0 +1,25 @@ > +/** @file > +* > +* Copyright (c) 2016-2018, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2016-2018, Linaro Limited. All rights reserved. > +* > +* This program and the accompanying materials > +* are licensed and made available under the terms and conditions of the BSD License > +* which accompanies this distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#ifndef __OEM_NIC_CONFIG_H__ > +#define __OEM_NIC_CONFIG_H__ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#endif > diff --git a/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.c b/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.c > new file mode 100644 > index 0000000000..c01c49150a > --- /dev/null > +++ b/Platform/Hisilicon/D06/Drivers/OemNicConfig2PHi1620/OemNicConfig2P.c > @@ -0,0 +1,71 @@ > +/** @file > +* > +* Copyright (c) 2016-2018, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2016-2018, Linaro Limited. All rights reserved. > +* > +* This program and the accompanying materials > +* are licensed and made available under the terms and conditions of the BSD License > +* which accompanies this distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#include > + > + > +EFI_STATUS > +EFIAPI OemGetMac2P ( > + IN OUT EFI_MAC_ADDRESS *Mac, > + IN UINTN Port > + ) > +{ > + OemGetMac (Mac, Port); > + > + return EFI_SUCCESS; > +} > + > +EFI_STATUS > +EFIAPI OemSetMac2P ( > + IN EFI_MAC_ADDRESS *Mac, > + IN UINTN Port > + ) > +{ > + OemSetMac (Mac, Port); > + > + return EFI_SUCCESS; > +} > + > +HISI_BOARD_NIC_PROTOCOL mHisiBoardNicProtocol2P = { > + .GetMac = OemGetMac2P, > + .SetMac = OemSetMac2P, > +}; > + > + > +EFI_STATUS > +EFIAPI > +OemNicConfigEntry ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + > + Status = gBS->InstallProtocolInterface ( > + &ImageHandle, > + &gHisiBoardNicProtocolGuid, > + EFI_NATIVE_INTERFACE, > + &mHisiBoardNicProtocol2P > + ); > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Install Protocol failed %r\n", > + __FUNCTION__, __LINE__, Status)); > + return Status; > + } > + > + return EFI_SUCCESS; > +} > + > -- > 2.17.0 >