From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D2ED1210F157D for ; Wed, 22 Aug 2018 08:09:10 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id c14-v6so2339557wmb.4 for ; Wed, 22 Aug 2018 08:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IO5oOyYorwaWZdFs8SzUZSdUyz/zhToic5HfwyF0fdY=; b=bWStAoDIlnm0W2DpwM2mTx0wCWnaa2D5KK3xCuU6Ivg/923Ps0xyBu9WrgF9h+HT3I rKXbmqySSPLUYahaC2+5v6lf5OPp79svHXVnbh4YROQ1g10Urm/Tyfe4zKtlyz0V7Cld cW98xhJTsHsTfb/2i2B4uMqgeguDX4I+sgVmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IO5oOyYorwaWZdFs8SzUZSdUyz/zhToic5HfwyF0fdY=; b=CS+kaDWvcX1aSb2EJLTWxOkpGPXHPY6bq5L8KiiBQZEZJ4OwD2VjaSEeXabFqH23ie qaA4hmQBQL4x82veKXFycMgOWbx9QQQgi4ZYKUoHlSyOhvo9feY7u7MH2NLzOy90ZsaM Zc65sDhuIm4vxGqAMPCSFysfDkPiav8gF+b+1YXuN+tx56A6kefvtINgYDTgcOUZl1sj W/mZXjE75VK/V+avnctye5AlC0SA58EZLL4lpg1RdQSq9v0CoD3OxI2BKaqmw3tCStzv J7iz6a4d0EIpc/OjICLPVJALsQ4lBHr+JNEZ4ypmdPx5HPhiapW3lFORG+LEbxIZvsXq Vk2Q== X-Gm-Message-State: APzg51Cbvo4D83NrlsZcQfDBdi69CtInUy3H2rA2saFxn+6gtkFmyd2d qIFwMB2ZfJ2eY2tDxW7X4sMT9w== X-Google-Smtp-Source: ANB0Vdbv5KbjU2b5Og5ZRz11n/dNOFdEi6cdYZYjm8CYhfpkrJVjl2Lp+8Nk1HQ+wj2a9gy8cI3NzA== X-Received: by 2002:a1c:700a:: with SMTP id l10-v6mr2691483wmc.90.1534950549383; Wed, 22 Aug 2018 08:09:09 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f132-v6sm2177052wme.24.2018.08.22.08.09.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 08:09:07 -0700 (PDT) Date: Wed, 22 Aug 2018 16:09:06 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180822150906.5lq4eckeapeo57do@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-34-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180814080903.50466-34-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 33/43] Platform/Hisilicon/D06: Add PciHostBridgeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 15:09:11 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 14, 2018 at 04:08:53PM +0800, Ming Huang wrote: > PciHostBridgeLib which is need by PciHostBridgeDxe, provide > root bridges and deal with resource conflict. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang All of my comments from v1 have been addressed. Reviewed-by: Leif Lindholm / Leif > --- > Platform/Hisilicon/D06/D06.dsc | 2 +- > Platform/Hisilicon/D06/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 36 ++ > Platform/Hisilicon/D06/Library/PciHostBridgeLib/PciHostBridgeLib.c | 635 ++++++++++++++++++++ > 3 files changed, 672 insertions(+), 1 deletion(-)