From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 327BA210FC369 for ; Wed, 22 Aug 2018 09:43:13 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id k5-v6so2139802wre.10 for ; Wed, 22 Aug 2018 09:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aGBF5bWE7AjuS7mPeydgeM3jQE6F5WItwPxKwYgEggs=; b=JruSJ7bHKgN2TvTNKyfNXRHHK8GpBk8WuJhMG4wByt6VN9URK0V5pGhJ8kVWWdw64y tyB02IytWzmD4jJMpyT7bwZyaEPLWV4pifX2JsQd7apXMXvzfsp2PufVizp57jjNLgfp FyEEF6Onc/PzWosGf4LQiZmJz3cRJ2AgfZIrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aGBF5bWE7AjuS7mPeydgeM3jQE6F5WItwPxKwYgEggs=; b=HK/vYgbCqRxtF+U7DesDIROyRls8ouKyRnVhnQ1J7y2HuTPm+GtLZQPqgzc9EQ/aA5 b9Uefy01Mt375Ki04tjztHuJ+3wSiAW74leUJDtZOk5fZhtByySD1/fSG6q2KYBmh99G o3sjjvo16nn5G4M86CloUHgKayoTMjHSE3PEE/iH/dgeJhVYVj/CogXbDGOBmTuukgbv mg+Q1Adn9THWst3FdOaM4Iy0Sorba1OkgvcboBykl730uvI5NOgLcimqQgkErnCALSe/ X/d924wHZl75deOB3Jfi8gOLOGwUrsSHVzPyRsc0bM/IhxgGGfvIcLBISI/XhhPIWsEk cDxQ== X-Gm-Message-State: AOUpUlEhQP/+in9HOQ2jxFlveF5vap5PH6hzYsK5MtjgVrlX70GEmFR0 RmSGB43YdCUW4v38KGYV/b2FwA== X-Google-Smtp-Source: AA+uWPx4tjChiYex4EeeEkdC106DmUw0YyUZvj8VYDQAPqV9jj28s/1I7wA8IoP4fM+CALxf6h75Kw== X-Received: by 2002:a5d:550a:: with SMTP id b10-v6mr36930355wrv.228.1534956191736; Wed, 22 Aug 2018 09:43:11 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g2-v6sm3827206wrd.71.2018.08.22.09.43.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 09:43:10 -0700 (PDT) Date: Wed, 22 Aug 2018 17:43:08 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180822164308.tgj3apq3ufufrkte@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-13-ming.huang@linaro.org> <20180822094901.6oavgeeqpzckqjwx@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 16:43:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 22, 2018 at 10:54:54PM +0800, Ming wrote: > > > On 8/22/2018 5:49 PM, Leif Lindholm wrote: > > On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote: > >> Add PcdCoreCount to fix build issue while add binary components. > > > > This commit message fails to describe what is being done, apart from a > > single thing that should be a separate patch. > > > > Pleas add a proper commit message describing which components are > > being imported. > > > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ming Huang > >> --- > >> Platform/Hisilicon/D06/D06.dsc | 7 +++++++ > >> Platform/Hisilicon/D06/D06.fdf | 17 +++++++++++++++++ > >> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 2 ++ > >> 3 files changed, 26 insertions(+) > >> > > > >> diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > >> index 2275586ff3..a47806f391 100644 > >> --- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > >> +++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > >> @@ -28,6 +28,7 @@ > >> > >> [Packages] > >> ArmPkg/ArmPkg.dec > >> + ArmPlatformPkg/ArmPlatformPkg.dec > >> MdePkg/MdePkg.dec > >> MdeModulePkg/MdeModulePkg.dec > >> IntelFrameworkPkg/IntelFrameworkPkg.dec > >> @@ -52,6 +53,7 @@ > >> gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED > >> > >> [Pcd] > >> + gArmPlatformTokenSpaceGuid.PcdCoreCount > >> gHisiTokenSpaceGuid.PcdCPUInfo > >> gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz > > > > And please submit this as a separate patch, explaining why the change > > is needed. If it is only needed by one of the binary modules imported > > as part of the current patch, place it immediately preceding this. > > > > If it resolves some other issue, please insert it as early in the set > > as possible. > > Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620 add a function > which use the PcdCoreCount and the function is used by ProcessorSubClassDxe. > Should I add gArmPlatformTokenSpaceGuid.PcdCoreCount to > Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf ? > And delete the commit message in this patch ? Yes please - that sounds like the correct solution. / Leif