From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3D320210FC370 for ; Wed, 22 Aug 2018 11:48:14 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id o37-v6so2441074wrf.6 for ; Wed, 22 Aug 2018 11:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pUy606RP/3P/+zKTMFEB6mWfP2fQjCphz6NGXtajQuY=; b=VUI9GnZF6czu2uYG6XTny11h7qUrU+/xJcQZsFT7/zs22OBJrPUKDaP64Qy29Du4tQ odioSpRQ1dAk61HGTnr0b1mVeMxQXvKlxGMO+5367Er0AbgV1G4W1yYhmmMYQe9Q6s+2 CyFM12BWujZEILmJlMT+pdgeL3wOFD5m+7fvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pUy606RP/3P/+zKTMFEB6mWfP2fQjCphz6NGXtajQuY=; b=NI3imLo04X/SR63hpkU1Qd48GypRl73ul3L/r2gG9fyUg/mR1TtYCKnV71OlbAq8IU a5Y/4TVJflrPrQpU5EiS8soeA2vJR/7qsi67I7/YlwFgiZWq6yg4wZ8+fUk4X30kLsDw gH34pJmTqMTJl3Eq0UhY7O5Dw/0AmvNXZCw2fOIr2yedtHB5BnXv013nrnGkJtIQ0PBC 67+wjVpXrVZP4oG16kHlS4CMOP+1q3e061Dr3xn8JlEVqTnHS/UMLenxNQvHFZTp/4mb JYEhWXQ70by7YNodg+uxx9qQ1Pbula6FcqetURDnDny2IzBrY/0QZfXvMofs8vC3GJCu YXhw== X-Gm-Message-State: AOUpUlHEGnZSMAVIlbIIJ8dbmweHSe3RW9fzyuV44TdoJGErtj6A4dr8 hm1y1bNBQgHU8hYJnXT7Oui66Q== X-Google-Smtp-Source: AA+uWPxL6u6x7UMFo6DLzpFJoMCOsIGH6nadH8jxfuqHOfBW/AL2T8QXx9CXDq82wecT5amTzb6TuQ== X-Received: by 2002:adf:b642:: with SMTP id i2-v6mr34423799wre.54.1534963693510; Wed, 22 Aug 2018 11:48:13 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l24-v6sm4977202wrb.65.2018.08.22.11.48.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Aug 2018 11:48:12 -0700 (PDT) Date: Wed, 22 Aug 2018 19:48:10 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180822184810.qyrnecgl7fq7tj5f@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-43-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180814080903.50466-43-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 42/43] Hisilicon/D06: Add edk2-non-osi Shell components X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 18:48:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline So, on the whole, I am really not happy for any of these commands to go into 18.08. I understand they may be handy for development, but I do not understand why they make sense to upstream. On Tue, Aug 14, 2018 at 04:09:02PM +0800, Ming Huang wrote: > Add Hisilicon Oem Shell libraries for some commands,such as > biosupdate, getmac, setmac, provision, acpistartos, brdinfo, > sfpinfo. > > biosupdate example: > ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1 > biosupdate serverIp -u user -p password -f D06.fd -m master > > acpistartos example: > ifconfig -s eth2 static 192.168.2.69 255.255.255.0 192.168.2.1 > provision serverIp -u user -p password -f os\Image -a 0x80000 > 2 > provision serverIp -u user -p password -f os\minifs.cpio.gz -a 0x07000000 > 2 > acpistartos > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/HisiPkg.dec | 4 ++++ > Platform/Hisilicon/D06/D06.dsc | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Silicon/Hisilicon/HisiPkg.dec b/Silicon/Hisilicon/HisiPkg.dec > index 858b840a57..010d501914 100644 > --- a/Silicon/Hisilicon/HisiPkg.dec > +++ b/Silicon/Hisilicon/HisiPkg.dec > @@ -39,6 +39,7 @@ > gPlatformSasProtocolGuid = {0x40e9829f, 0x3a2c, 0x479a, {0x9a, 0x93, 0x45, 0x7d, 0x13, 0x50, 0x96, 0x5d}} > gHisiPlatformSasProtocolGuid = {0x20e9829f, 0x3a2c, 0x479a, {0x9a, 0x93, 0x45, 0x7d, 0x13, 0x50, 0x96, 0x6d}} > gHisiSnpPlatformProtocolGuid = {0x81321f27, 0xff58, 0x4a1d, {0x99, 0x97, 0xd, 0xcc, 0xfa, 0x82, 0xf4, 0x6f}} > + gOemNicProtocolGuid = {0xb5903955, 0x31e9, 0x4aaf, {0xb2, 0x83, 0x7, 0x9f, 0x3c, 0xc4, 0x71, 0x66}} > > [Guids] > gHisiTokenSpaceGuid = {0xc8bc553e, 0x12bf, 0x11e6, {0x97, 0x4f, 0x87, 0xf7, 0x7c, 0xfd, 0x52, 0x1d}} > @@ -49,6 +50,8 @@ > gHisiOemVariableGuid = {0xac62b9a5, 0x9939, 0x41d3, {0xff, 0x5c, 0xc5, 0x80, 0x32, 0x7d, 0x9b, 0x29}} > gOemBootVariableGuid = {0xb7784577, 0x5aaf, 0x4557, {0xa1, 0x99, 0xd4, 0xa4, 0x2f, 0x45, 0x06, 0xf8}} > gEfiHisiSocControllerGuid = {0xee369cc3, 0xa743, 0x5382, {0x75, 0x64, 0x53, 0xe4, 0x31, 0x19, 0x38, 0x35}} > + HisiShellSampleHiiGuid = { 0x43859314, 0x82c1, 0x4592, { 0x8f, 0xf7, 0xc1, 0xbd, 0xf3, 0xb2, 0x0e, 0xd5 }} > + HisiPlatformShellSampleHiiGuid = { 0x7924a5de, 0xc600, 0x40d5, { 0x91, 0x10, 0xf9, 0xc3, 0xe7, 0x25, 0x4d, 0x33 }} Why do we need all these different GUIDs? Also, why "Sample"? / Leif > > [LibraryClasses] > PlatformSysCtrlLib|Include/Library/PlatformSysCtrlLib.h > @@ -101,6 +104,7 @@ > gHisiTokenSpaceGuid.PcdSlotPerChannelNum|0x0|UINT32|0x40000004 > > gHisiTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0x30006554 > + gHisiTokenSpaceGuid.PcdStartOsParameter|L""|VOID*|0x5000000 > > #FDT File Address > gHisiTokenSpaceGuid.FdtFileAddress|0x0|UINT64|0x40000005 > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index 053ea894d5..544039e450 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -473,6 +473,8 @@ > !if $(INCLUDE_DP) == TRUE > NULL|ShellPkg/Library/UefiDpLib/UefiDpLib.inf > !endif #$(INCLUDE_DP) > + NULL|Silicon/Hisilicon/Library/HisiShellCmdLib/HisiShellCmdLib.inf > + NULL|Silicon/Hisilicon/Hi1620/Library/HisiD06ShellCmdLib/HisiD06ShellCmdLib.inf > > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF > -- > 2.17.0 >