From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8ED01210FCF58 for ; Thu, 23 Aug 2018 02:43:21 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id s9-v6so4562850wmh.3 for ; Thu, 23 Aug 2018 02:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Up12xm9aEcD2+FA/ehVmAI8jGbfCR64lHRAN/HGIIsg=; b=Ugd+Q2RjF18eFiZygjc1h1Oz49H7O86p0+oHxrIZz3e7Ac0UKEU4u/IXan7eCSZQSC xxHKRJy4DkFXmaokxEEWTjFH5POPFtAYG7T7FcwMysvO9yfFNDHO23u0oE++HFdLtIbN V8dtHHU27VQ9HRoipxdBco7kwGvByQX/SLCwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Up12xm9aEcD2+FA/ehVmAI8jGbfCR64lHRAN/HGIIsg=; b=T6J8NWaAubcPuiUVsdnVd+Xwracmf8B1hK+R+JQm4BK8Q68qapDboyiTFNTodw1VB5 8oCc5mirwfMj34wBX1dStt9wrT4M7uzcWya1JF2Ljjs64ZHqhQ8mlT4FluTwUey+9W3G /WQ9D7LIsfgFsyVYF8VdivZNMKdV8zGnrpyhm3UmC/jmat5aAZPdBwy5gOgvfFshMRfQ jGI/wsCyeAb2QTa8MR6ZLVTSsS2LXW+zy2iI4VHvXZSZXb7xlVeZfzgq8emCLneqMg37 NlkAD2/IYoFfBngjTc35K0VxNaaFmNdC6JdNYiCfJ6GwtWszb1dIbfL3bwD/eKQonvQG UpPQ== X-Gm-Message-State: APzg51DeOqQVVyzq95dc8MQXTOgYC90S6xU8Zn2rc1CHUrCnZ52HKngi U5sVGeSnmhtGRR645D3dlgiCRQ== X-Google-Smtp-Source: ANB0VdZ4DXb8VIWAyxzN11E0bwKOybBDIk/b5gJIvsOlfNeou5kZZp7dGrBpv5bwQ7DxIVF1Or3ZZg== X-Received: by 2002:a1c:7513:: with SMTP id o19-v6mr4783702wmc.53.1535017400230; Thu, 23 Aug 2018 02:43:20 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z16-v6sm3118044wrq.78.2018.08.23.02.43.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 02:43:18 -0700 (PDT) Date: Thu, 23 Aug 2018 10:43:17 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Luqi Jiang Message-ID: <20180823094316.3rgxwmrzrnl57xyu@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-35-ming.huang@linaro.org> <20180822153142.5ykxhobxqeaa4qmu@bivouac.eciton.net> <9f9b2575-b668-4f95-34a5-e66906ff65b6@linaro.org> MIME-Version: 1.0 In-Reply-To: <9f9b2575-b668-4f95-34a5-e66906ff65b6@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 34/43] Hisilicon/D06: add apei driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 09:43:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 23, 2018 at 03:35:04PM +0800, Ming wrote: > >> +BOOLEAN > >> +BertAddGenericErrorData ( > >> + IN EFI_ACPI_6_0_BOOT_ERROR_RECORD_TABLE_HEADER *Bert, > >> + IN EFI_CPER_SECTION_TYPE TypeOfErrorData, > >> + IN VOID *GenericErrorData, > >> + IN UINT32 SizeOfGenericErrorData, > >> + IN ERROR_SEVERITY ErrorSeverity, > >> + IN BOOLEAN Correctable > >> +) > >> +{ > >> + DEBUG ((DEBUG_ERROR, "[%a]:[%dL]: \n", __FUNCTION__, __LINE__)); > > > > Isn't this adding error data for somewhere else? > > If so, shouldn't that be giving an error message? > > This one amounts to "I'm logging that there was an error somewhere". > > I want to drop this DEBUG line. Is that ok? Yes please. > > This does not look like an error - should it really be of the ERROR > > debug level? Better to move it to INFO. > > The same applies to similar functions for the other tables. > > Yes, it should be INFO and I will modify similar issues in this patch. Thanks. > >> + DEBUG ((DEBUG_ERROR, "[%a]:[%dL]: \n", __FUNCTION__, __LINE__)); > > > > Why this message? > > I think this DEBUG is useless. > I will drop it in v4. Yes please. / Leif