From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F045B210EFB11 for ; Thu, 23 Aug 2018 02:44:52 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id 20-v6so4054362wrb.12 for ; Thu, 23 Aug 2018 02:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KdJ/RkRC3YC27yuHa0SYX6+63V64l5zRyD1o5F9IRBM=; b=BeVwxuJn677KOgRkTQZgj44qk2+8rgzKLpflRCkaxgF7Ex9Jq9fuAO2odV2BXzefpt yX/jnxl7cUN5qKUPDLbSSnyBwPeb6PL6ulrqmydE2x179phnuNiXoHxssHW4rdeHBJ9c 0UrUufN7ycPT4sJAqCzfls4OS3IM/HJVIGid4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KdJ/RkRC3YC27yuHa0SYX6+63V64l5zRyD1o5F9IRBM=; b=fWte+Sefouz/qwEZSVztXyK/VSITo3v4M0enriJXwtKiO2KczQIokZ1y3NF2mm0Guu zJsGFO5kLBgKk5SqsNyhSPmHzBMkhlGy3OqkiwJwj3v5DiK62sCYUdOwXkaBZKC5ro// w6CUEQdl7Zidk2w4aESRydDlLYODs5gsMdIsF9710of4Cy9TOes/rs7rlGb3879pOQZB Z5uBv9njQ+Ds4r7zIO67yQmZACRUXJ18Gd3+qNN2gXYHCyIlGuevGl+/7i3jIH8l4hyv lxrI/U22m1oeRUtw/ka4e+yUJnm9BLrNgHRIubzh6olcwhpQ5vnRqgg7EvSt5MOezZTf L4XQ== X-Gm-Message-State: APzg51Bj6wmd//tIXy81U1FD/TNzdII5RqpN9U9F/NrR8fT4czeLKGml sIgHZUsbyNOLLZMT2TtMZm2irQ== X-Google-Smtp-Source: ANB0Vdbe5nPOlgjt8WSOzhxHNyZbotVeRT9G4WNOJGWn2oHeDJDJHcfajK6tgZqSiYKPaDi9kkOYaA== X-Received: by 2002:a5d:4a44:: with SMTP id v4-v6mr5831999wrs.278.1535017491558; Thu, 23 Aug 2018 02:44:51 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d12-v6sm4311659wru.36.2018.08.23.02.44.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 02:44:50 -0700 (PDT) Date: Thu, 23 Aug 2018 10:44:48 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180823094448.il72wdbebxh2lcuu@bivouac.eciton.net> References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-36-ming.huang@linaro.org> <20180822153336.mllu5y6fr72surxn@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 09:44:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 23, 2018 at 03:39:57PM +0800, Ming wrote: > > > On 8/22/2018 11:33 PM, Leif Lindholm wrote: > > On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote: > >> Add some Lpc macro to LpcLib.h for D06. > >> > > > > Unaddressed feedback from v1: > > > > I have no issue with this patch, but can you explain when these macros > > are intended to be used? And if in this set, move this patch > > immediately before the patch than needs it? > > These macros are not used in edk2-platforms, used in HwPkg/LpcLib. Then why are they not in HwPkg? / Leif