* [PATCH v3 01/16] IntelFsp2Pkg/FspSecCore: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 02/16] IntelFsp2Pkg/BaseFspCommonLib: " shenglei
` (16 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chasel Chiu, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize
gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 6 ------
IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 11 -----------
IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 5 -----
3 files changed, 22 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
index 0500a197f8..c657862deb 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
@@ -58,17 +58,11 @@
FspSecPlatformLib
[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## UNDEFINED
- gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## CONSUMES
gIntelFsp2PkgTokenSpaceGuid.PcdFspHeapSizePercentage ## CONSUMES
-[FixedPcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES
-
[Ppis]
gEfiTemporaryRamSupportPpiGuid ## PRODUCES
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
index a3563dd8cf..dd3f8e56a0 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
@@ -52,17 +52,6 @@
FspCommonLib
FspSecPlatformLib
-[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## UNDEFINED
- gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## CONSUMES
-
-[FixedPcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES
-
[Ppis]
gEfiTemporaryRamSupportPpiGuid ## PRODUCES
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
index cf6a1918a3..aff4b23f88 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
@@ -53,14 +53,9 @@
FspSecPlatformLib
[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## UNDEFINED
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
gIntelFsp2PkgTokenSpaceGuid.PcdFspReservedBufferSize ## CONSUMES
-[FixedPcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES
-
[Ppis]
gEfiTemporaryRamSupportPpiGuid ## PRODUCES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 02/16] IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
2018-08-28 3:42 ` [PATCH v3 01/16] IntelFsp2Pkg/FspSecCore: Remove " shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 03/16] IntelFsp2Pkg/BaseFspPlatformLib: " shenglei
` (15 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chasel Chiu, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
---
IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf | 5 -----
1 file changed, 5 deletions(-)
diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf b/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf
index c9d98357e2..ff82f8040b 100644
--- a/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf
+++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf
@@ -33,8 +33,3 @@
[Pcd]
gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES
-[FixedPcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 03/16] IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
2018-08-28 3:42 ` [PATCH v3 01/16] IntelFsp2Pkg/FspSecCore: Remove " shenglei
2018-08-28 3:42 ` [PATCH v3 02/16] IntelFsp2Pkg/BaseFspCommonLib: " shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 04/16] IntelFsp2Pkg/BaseFspSwitchStackLib: " shenglei
` (14 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chasel Chiu, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize
gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
---
.../Library/BaseFspPlatformLib/BaseFspPlatformLib.inf | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf b/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf
index 907482daed..b9e8a61809 100644
--- a/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf
+++ b/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf
@@ -35,12 +35,6 @@
PerformanceLib
ReportStatusCodeLib
-[Pcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## CONSUMES
-
[Guids]
gFspPerformanceDataGuid ## CONSUMES ## GUID
gFspEventEndOfFirmwareGuid ## PRODUCES ## GUID
@@ -49,6 +43,3 @@
[Protocols]
gEfiPciEnumerationCompleteProtocolGuid ## CONSUMES
-[FixedPcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 04/16] IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (2 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 03/16] IntelFsp2Pkg/BaseFspPlatformLib: " shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD shenglei
` (13 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chasel Chiu, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
---
.../Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf | 4 ----
1 file changed, 4 deletions(-)
diff --git a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf
index b3c673a0ac..97cf3caa6a 100644
--- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf
+++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf
@@ -34,9 +34,5 @@
BaseLib
IoLib
-[FixedPcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES
-
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (3 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 04/16] IntelFsp2Pkg/BaseFspSwitchStackLib: " shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 5:28 ` Chiu, Chasel
2018-08-28 3:42 ` [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs shenglei
` (12 subsequent siblings)
17 siblings, 1 reply; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chasel Chiu, Laszlo Ersek
The PCD below is unused, so it has been removed from inf.
gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
index ce3bfa0c75..011cf89d3f 100644
--- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
+++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
@@ -61,7 +61,6 @@
gFspHobGuid ## CONSUMES ## HOB
[Pcd]
- gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress ## CONSUMES
gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi ## CONSUMES
[Depex]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD
2018-08-28 3:42 ` [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD shenglei
@ 2018-08-28 5:28 ` Chiu, Chasel
0 siblings, 0 replies; 32+ messages in thread
From: Chiu, Chasel @ 2018-08-28 5:28 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Yao, Jiewen, Laszlo Ersek
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
-----Original Message-----
From: Zhang, Shenglei
Sent: Tuesday, August 28, 2018 11:43 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD
The PCD below is unused, so it has been removed from inf.
gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
index ce3bfa0c75..011cf89d3f 100644
--- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
+++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
@@ -61,7 +61,6 @@
gFspHobGuid ## CONSUMES ## HOB
[Pcd]
- gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress ## CONSUMES
gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi ## CONSUMES
[Depex]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (4 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 5:30 ` Chiu, Chasel
2018-08-28 3:42 ` [PATCH v3 07/16] SecurityPkg/Tcg2ConfigPei: Remove an unused PCD shenglei
` (11 subsequent siblings)
17 siblings, 1 reply; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chasel Chiu, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
.../BaseFspWrapperPlatformLibSample.inf | 3 ---
1 file changed, 3 deletions(-)
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
index f9581e8456..3bc024459f 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
@@ -55,6 +55,3 @@
[LibraryClasses]
-[Pcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
2018-08-28 3:42 ` [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs shenglei
@ 2018-08-28 5:30 ` Chiu, Chasel
0 siblings, 0 replies; 32+ messages in thread
From: Chiu, Chasel @ 2018-08-28 5:30 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Yao, Jiewen, Laszlo Ersek
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
-----Original Message-----
From: Zhang, Shenglei
Sent: Tuesday, August 28, 2018 11:43 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
The PCDs below are unused, so they have been removed from inf.
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
.../BaseFspWrapperPlatformLibSample.inf | 3 ---
1 file changed, 3 deletions(-)
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
index f9581e8456..3bc024459f 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
@@ -55,6 +55,3 @@
[LibraryClasses]
-[Pcd]
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES
- gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v3 07/16] SecurityPkg/Tcg2ConfigPei: Remove an unused PCD
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (5 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs shenglei
` (10 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chao Zhang, Laszlo Ersek
The PCD below is unused, so it has been removed from inf.
gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf
index a0136bc0c5..581669a277 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf
@@ -67,7 +67,6 @@
gEfiSecurityPkgTokenSpaceGuid.PcdTpmInstanceGuid ## PRODUCES
gEfiSecurityPkgTokenSpaceGuid.PcdTpmInitializationPolicy ## PRODUCES
gEfiSecurityPkgTokenSpaceGuid.PcdTpmAutoDetection ## CONSUMES
- gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress ## SOMETIMES_CONSUMES
[Depex]
gEfiPeiMasterBootModePpiGuid AND
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (6 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 07/16] SecurityPkg/Tcg2ConfigPei: Remove an unused PCD shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-29 13:41 ` Laszlo Ersek
2018-08-28 3:42 ` [PATCH v3 09/16] UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD shenglei
` (9 subsequent siblings)
17 siblings, 1 reply; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chao Zhang, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 6 ------
1 file changed, 6 deletions(-)
diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
index b875ab7e01..2b89869ef1 100644
--- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
+++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
@@ -101,12 +101,6 @@
gEfiSecurityPkgTokenSpaceGuid.PcdTpmPlatformClass ## SOMETIMES_CONSUMES
gEfiSecurityPkgTokenSpaceGuid.PcdFirmwareDebuggerInitialized ## SOMETIMES_CONSUMES
gEfiSecurityPkgTokenSpaceGuid.PcdTpmInstanceGuid ## CONSUMES
- gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress ## SOMETIMES_CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId ## SOMETIMES_CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId ## SOMETIMES_CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision ## SOMETIMES_CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId ## SOMETIMES_CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision ## SOMETIMES_CONSUMES
gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice ## SOMETIMES_CONSUMES
gEfiSecurityPkgTokenSpaceGuid.PcdTcg2HashAlgorithmBitmap ## CONSUMES
gEfiSecurityPkgTokenSpaceGuid.PcdTcg2NumberOfPCRBanks ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs shenglei
@ 2018-08-29 13:41 ` Laszlo Ersek
0 siblings, 0 replies; 32+ messages in thread
From: Laszlo Ersek @ 2018-08-29 13:41 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jiewen Yao, Chao Zhang
On 08/28/18 05:42, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
> index b875ab7e01..2b89869ef1 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
> @@ -101,12 +101,6 @@
> gEfiSecurityPkgTokenSpaceGuid.PcdTpmPlatformClass ## SOMETIMES_CONSUMES
> gEfiSecurityPkgTokenSpaceGuid.PcdFirmwareDebuggerInitialized ## SOMETIMES_CONSUMES
> gEfiSecurityPkgTokenSpaceGuid.PcdTpmInstanceGuid ## CONSUMES
> - gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress ## SOMETIMES_CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId ## SOMETIMES_CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId ## SOMETIMES_CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision ## SOMETIMES_CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId ## SOMETIMES_CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision ## SOMETIMES_CONSUMES
> gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice ## SOMETIMES_CONSUMES
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2HashAlgorithmBitmap ## CONSUMES
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2NumberOfPCRBanks ## CONSUMES
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 09/16] UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (7 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 10/16] MdePkg/BaseLib: " shenglei
` (8 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Eric Dong, Laszlo Ersek
The PCD below is unused, so it has been removed from inf.
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
index 8bc8979de0..cb7f227f6c 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
@@ -64,7 +64,6 @@
LocalApicLib
[Pcd]
- gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport ## CONSUMES
gUefiCpuPkgTokenSpaceGuid.PcdCpuClockModulationDutyCycle ## SOMETIMES_CONSUMES
gUefiCpuPkgTokenSpaceGuid.PcdIsPowerOnReset ## SOMETIMES_CONSUMES
gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme ## SOMETIMES_CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 10/16] MdePkg/BaseLib: Remove an unused PCD
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (8 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 09/16] UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs shenglei
` (7 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Michael D Kinney, Liming Gao, Laszlo Ersek
The PCD below is unused, so it has been removed from inf.
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
MdePkg/Library/BaseLib/BaseLib.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/MdePkg/Library/BaseLib/BaseLib.inf b/MdePkg/Library/BaseLib/BaseLib.inf
index a1b5ec4b75..4ae8a0b05a 100644
--- a/MdePkg/Library/BaseLib/BaseLib.inf
+++ b/MdePkg/Library/BaseLib/BaseLib.inf
@@ -643,7 +643,6 @@
gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength ## SOMETIMES_CONSUMES
gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength ## SOMETIMES_CONSUMES
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## SOMETIMES_CONSUMES
- gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## SOMETIMES_CONSUMES
[FeaturePcd]
gEfiMdePkgTokenSpaceGuid.PcdVerifyNodeInList ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (9 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 10/16] MdePkg/BaseLib: " shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 4:53 ` Zeng, Star
2018-08-28 3:42 ` [PATCH v3 12/16] MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD shenglei
` (6 subsequent siblings)
17 siblings, 1 reply; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Eric Dong, Laszlo Ersek
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 2958 bytes --]
The PCDs below are unused, so they have been removed from inf.
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax
gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem
The library Pcdlib is not linked， so "#include <Library/PcdLib.h>"
is deleted.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 1 -
.../Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 11 -----------
2 files changed, 12 deletions(-)
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index 91c6849a46..fe3ee93523 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -39,7 +39,6 @@
#include <Library/CapsuleLib.h>
#include <Library/DevicePathLib.h>
#include <Library/UefiLib.h>
-#include <Library/PcdLib.h>
#include <Library/BmpSupportLib.h>
#include <Protocol/GraphicsOutput.h>
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
index 342df9e99c..d5e87cb97b 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
@@ -56,17 +56,6 @@
HobLib
BmpSupportLib
-[Pcd]
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag ## CONSUMES
-
- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem ## CONSUMES
[Protocols]
gEsrtManagementProtocolGuid ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs shenglei
@ 2018-08-28 4:53 ` Zeng, Star
0 siblings, 0 replies; 32+ messages in thread
From: Zeng, Star @ 2018-08-28 4:53 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org
Cc: Dong, Eric, Laszlo Ersek, Zeng, Star
Shenglei,
The library Pcdlib is not linked， so "#include <Library/PcdLib.h>"
is deleted.
There is massy code, please correct it before it can be pushed.
Thanks,
Star
-----Original Message-----
From: Zhang, Shenglei
Sent: Tuesday, August 28, 2018 11:43 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs
The PCDs below are unused, so they have been removed from inf.
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax
gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem
The library Pcdlib is not linked， so "#include <Library/PcdLib.h>"
is deleted.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 1 - .../Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 11 -----------
2 files changed, 12 deletions(-)
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index 91c6849a46..fe3ee93523 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -39,7 +39,6 @@
#include <Library/CapsuleLib.h>
#include <Library/DevicePathLib.h>
#include <Library/UefiLib.h>
-#include <Library/PcdLib.h>
#include <Library/BmpSupportLib.h>
#include <Protocol/GraphicsOutput.h>
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
index 342df9e99c..d5e87cb97b 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
@@ -56,17 +56,6 @@
HobLib
BmpSupportLib
-[Pcd]
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag ## CONSUMES
-
- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem ## CONSUMES
[Protocols]
gEsrtManagementProtocolGuid ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v3 12/16] MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (10 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-28 3:42 ` [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs shenglei
` (5 subsequent siblings)
17 siblings, 0 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Eric Dong, Laszlo Ersek
The PCD below is unused, so it has been removed from inf.
gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
---
.../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf
index 983ce41b48..023ab00c7c 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf
@@ -73,7 +73,6 @@
[Pcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdProgressCodeOsLoaderLoad ## CONSUMES
gEfiMdeModulePkgTokenSpaceGuid.PcdProgressCodeOsLoaderStart ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId ## CONSUMES
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId ## CONSUMES
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (11 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 12/16] MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-29 1:36 ` Ni, Ruiyu
2018-08-29 13:43 ` Laszlo Ersek
2018-08-28 3:42 ` [PATCH v3 14/16] ShellPkg/DpDynamicCommand: " shenglei
` (4 subsequent siblings)
17 siblings, 2 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
---
ShellPkg/Application/Shell/Shell.inf | 2 --
1 file changed, 2 deletions(-)
diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf
index d89f85bb76..83049844d6 100644
--- a/ShellPkg/Application/Shell/Shell.inf
+++ b/ShellPkg/Application/Shell/Shell.inf
@@ -102,10 +102,8 @@
gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES
- gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES
- gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs shenglei
@ 2018-08-29 1:36 ` Ni, Ruiyu
2018-08-29 13:43 ` Laszlo Ersek
1 sibling, 0 replies; 32+ messages in thread
From: Ni, Ruiyu @ 2018-08-29 1:36 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jaben Carsey, Laszlo Ersek
On 8/28/2018 11:42 AM, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/Application/Shell/Shell.inf | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf
> index d89f85bb76..83049844d6 100644
> --- a/ShellPkg/Application/Shell/Shell.inf
> +++ b/ShellPkg/Application/Shell/Shell.inf
> @@ -102,10 +102,8 @@
> gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs shenglei
2018-08-29 1:36 ` Ni, Ruiyu
@ 2018-08-29 13:43 ` Laszlo Ersek
1 sibling, 0 replies; 32+ messages in thread
From: Laszlo Ersek @ 2018-08-29 13:43 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni
On 08/28/18 05:42, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/Application/Shell/Shell.inf | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf
> index d89f85bb76..83049844d6 100644
> --- a/ShellPkg/Application/Shell/Shell.inf
> +++ b/ShellPkg/Application/Shell/Shell.inf
> @@ -102,10 +102,8 @@
> gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 14/16] ShellPkg/DpDynamicCommand: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (12 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-29 1:36 ` Ni, Ruiyu
2018-08-28 3:42 ` [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD shenglei
` (3 subsequent siblings)
17 siblings, 1 reply; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in DpApp.inf
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in
DpDynamicCommand.inf
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
---
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 --
ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf | 3 ---
2 files changed, 5 deletions(-)
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
index cedb333b28..c35a3087cf 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
@@ -69,5 +69,3 @@
gEfiLoadedImageDevicePathProtocolGuid ## SOMETIMES_CONSUMES
gEfiHiiPackageListProtocolGuid ## CONSUMES
-[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
index 8fd3bbd5df..2d07b32266 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
@@ -71,8 +71,5 @@
gEfiHiiPackageListProtocolGuid ## CONSUMES
gEfiShellDynamicCommandProtocolGuid ## PRODUCES
-[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES
-
[DEPEX]
TRUE
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 14/16] ShellPkg/DpDynamicCommand: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 14/16] ShellPkg/DpDynamicCommand: " shenglei
@ 2018-08-29 1:36 ` Ni, Ruiyu
0 siblings, 0 replies; 32+ messages in thread
From: Ni, Ruiyu @ 2018-08-29 1:36 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jaben Carsey, Laszlo Ersek
On 8/28/2018 11:42 AM, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in DpApp.inf
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in
> DpDynamicCommand.inf
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 --
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf | 3 ---
> 2 files changed, 5 deletions(-)
>
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> index cedb333b28..c35a3087cf 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> @@ -69,5 +69,3 @@
> gEfiLoadedImageDevicePathProtocolGuid ## SOMETIMES_CONSUMES
> gEfiHiiPackageListProtocolGuid ## CONSUMES
>
> -[Pcd]
> - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> index 8fd3bbd5df..2d07b32266 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> @@ -71,8 +71,5 @@
> gEfiHiiPackageListProtocolGuid ## CONSUMES
> gEfiShellDynamicCommandProtocolGuid ## PRODUCES
>
> -[Pcd]
> - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES
> -
> [DEPEX]
> TRUE
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (13 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 14/16] ShellPkg/DpDynamicCommand: " shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-29 13:49 ` Laszlo Ersek
2018-08-28 3:42 ` [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs shenglei
` (2 subsequent siblings)
17 siblings, 1 reply; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni, Laszlo Ersek
The PCD below is unused, so it has been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
index e5e007bef3..a795fb92de 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
@@ -353,5 +353,4 @@
gEfiAdapterInfoUndiIpv6SupportGuid ## SOMETIMES_CONSUMES ## GUID
[Pcd.common]
- gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
gEfiShellPkgTokenSpaceGuid.PcdShellIncludeNtGuids ## CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD
2018-08-28 3:42 ` [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD shenglei
@ 2018-08-29 13:49 ` Laszlo Ersek
0 siblings, 0 replies; 32+ messages in thread
From: Laszlo Ersek @ 2018-08-29 13:49 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni
On 08/28/18 05:42, shenglei wrote:
> The PCD below is unused, so it has been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index e5e007bef3..a795fb92de 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -353,5 +353,4 @@
> gEfiAdapterInfoUndiIpv6SupportGuid ## SOMETIMES_CONSUMES ## GUID
>
> [Pcd.common]
> - gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellIncludeNtGuids ## CONSUMES
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (14 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD shenglei
@ 2018-08-28 3:42 ` shenglei
2018-08-29 1:37 ` Ni, Ruiyu
2018-08-29 13:50 ` Laszlo Ersek
2018-08-28 14:56 ` [PATCH v3 00/16] Removed " Carsey, Jaben
2018-10-02 10:13 ` Laszlo Ersek
17 siblings, 2 replies; 32+ messages in thread
From: shenglei @ 2018-08-28 3:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni, Laszlo Ersek
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
---
.../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 2 --
1 file changed, 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
index 3ea51ec082..ec1f87ae19 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
@@ -119,8 +119,6 @@
[Pcd]
gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
- gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize ## CONSUMES
- gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## CONSUMES
[Protocols]
gEfiPciRootBridgeIoProtocolGuid ## SOMETIMES_CONSUMES
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs shenglei
@ 2018-08-29 1:37 ` Ni, Ruiyu
2018-08-29 13:50 ` Laszlo Ersek
1 sibling, 0 replies; 32+ messages in thread
From: Ni, Ruiyu @ 2018-08-29 1:37 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jaben Carsey, Laszlo Ersek
On 8/28/2018 11:42 AM, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> .../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> index 3ea51ec082..ec1f87ae19 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> @@ -119,8 +119,6 @@
>
> [Pcd]
> gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize ## CONSUMES
> - gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## CONSUMES
>
> [Protocols]
> gEfiPciRootBridgeIoProtocolGuid ## SOMETIMES_CONSUMES
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs
2018-08-28 3:42 ` [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs shenglei
2018-08-29 1:37 ` Ni, Ruiyu
@ 2018-08-29 13:50 ` Laszlo Ersek
1 sibling, 0 replies; 32+ messages in thread
From: Laszlo Ersek @ 2018-08-29 13:50 UTC (permalink / raw)
To: shenglei, edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni
On 08/28/18 05:42, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> .../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> index 3ea51ec082..ec1f87ae19 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> @@ -119,8 +119,6 @@
>
> [Pcd]
> gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize ## CONSUMES
> - gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## CONSUMES
>
> [Protocols]
> gEfiPciRootBridgeIoProtocolGuid ## SOMETIMES_CONSUMES
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 00/16] Removed unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (15 preceding siblings ...)
2018-08-28 3:42 ` [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs shenglei
@ 2018-08-28 14:56 ` Carsey, Jaben
2018-10-02 10:13 ` Laszlo Ersek
17 siblings, 0 replies; 32+ messages in thread
From: Carsey, Jaben @ 2018-08-28 14:56 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org
For 13,14,15,16 about the ShellPkg content.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> shenglei
> Sent: Monday, August 27, 2018 8:43 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v3 00/16] Removed unused PCDs
> Importance: High
>
> A lot of unused PCDs are removed from inf.
> All packages are built and the results are "pass".
>
> v2:
> 1.Split MdeModulePkg into separated patches.
> 2.Split IntelFsp2Pkg into separated patches.
>
> v3:
> 1.Split ShellPkg into separated patches.
> 2.Split SecurityPkg into separated patches.
> 3.Split IntelFsp2WrapperPkg into separated patches.
> 4.Split IntelFspPkg into separated patches.
> 5.Update the message in the cover letter.
>
> shenglei (16):
> IntelFsp2Pkg FspSecCore: Remove unused PCDs
> IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs
> IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs
> IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs
> IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD
> IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
> SecurityPkg/Tcg2ConfigPei: Remove an unused PCD
> SecurityPkg/Tcg2Dxe: Remove unused PCDs
> UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD
> MdePkg/BaseLib: Remove an unused PCD
> MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs
> MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused
> PCD
> ShellPkg/Shell: Remove unused PCDs
> ShellPkg/DpDynamicCommand: Remove unused PCDs
> ShellPkg/UefiHandleParsingLib: Remove an unused PCD
> ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs
>
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 6 ------
> IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 11 -----------
> IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 5 -----
> .../Library/BaseFspCommonLib/BaseFspCommonLib.inf | 5 -----
> .../Library/BaseFspPlatformLib/BaseFspPlatformLib.inf | 9 ---------
> .../BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf | 4 ----
> .../FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 1 -
> .../BaseFspWrapperPlatformLibSample.inf | 3 ---
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 1 -
> .../Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 11 -----------
> .../FirmwarePerformanceDxe.inf | 1 -
> MdePkg/Library/BaseLib/BaseLib.inf | 1 -
> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf | 1 -
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 6 ------
> ShellPkg/Application/Shell/Shell.inf | 2 --
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 --
> .../DpDynamicCommand/DpDynamicCommand.inf | 3 ---
> .../UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 -
> .../UefiShellDebug1CommandsLib.inf | 2 --
> .../CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 1 -
> 20 files changed, 76 deletions(-)
>
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v3 00/16] Removed unused PCDs
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
` (16 preceding siblings ...)
2018-08-28 14:56 ` [PATCH v3 00/16] Removed " Carsey, Jaben
@ 2018-10-02 10:13 ` Laszlo Ersek
2018-10-08 2:14 ` Zhang, Shenglei
2018-10-08 3:07 ` Ni, Ruiyu
17 siblings, 2 replies; 32+ messages in thread
From: Laszlo Ersek @ 2018-10-02 10:13 UTC (permalink / raw)
To: Ruiyu Ni, Chao Zhang; +Cc: shenglei, edk2-devel, Michael Kinney
Ray, Chao,
guys, you keep breaking the development process. Please fix your email
clients *now*.
On 08/28/18 05:42, shenglei wrote:
> shenglei (16):
> IntelFsp2Pkg FspSecCore: Remove unused PCDs
> IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs
> IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs
> IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs
> IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD
> IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
> SecurityPkg/Tcg2ConfigPei: Remove an unused PCD
This was patch #07 in this series. I had never reviewed it, yet Chao
pushed it with my R-b as commit
https://github.com/tianocore/edk2/commit/3e11c27f67ea
> SecurityPkg/Tcg2Dxe: Remove unused PCDs
> UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD
> MdePkg/BaseLib: Remove an unused PCD
> MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs
> MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD
> ShellPkg/Shell: Remove unused PCDs
This was patch #13 in this series. I reviewed it:
http://mid.mail-archive.com/70dfa56d-6781-e8c0-f3f4-aa12558672b9@redhat.com
but Ray pushed it as commit
https://github.com/tianocore/edk2/commit/a9dfe53f56bb
without my R-b tag. (Note: there was 1 month between my feedback and the
push date.)
The commit message now suggests that I ignored the patch (because I was
on CC, but seemingly didn't respond). It mis-represents my acts.
> ShellPkg/DpDynamicCommand: Remove unused PCDs
> ShellPkg/UefiHandleParsingLib: Remove an unused PCD
Same here. Patch #15, pushed as commit
https://github.com/tianocore/edk2/commit/42a7c2871a65
My review was at:
http://mid.mail-archive.com/a70f17d9-b937-2835-4d71-5464bad82219@redhat.com
but it was dropped from the commit.
> ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs
Ditto. Patch #16. My review was at:
http://mid.mail-archive.com/d23e7c95-96e9-4088-4e95-5dbc0a331cb1@redhat.com
but the patch was pushed as commit
https://github.com/tianocore/edk2/commit/aa9986651bfe
with my review lost.
This is not the first time it has happened. If I remember correctly, Ray
blamed his email client last time (not showing message threads
correctly, or something similar).
I'm sorry, but this is unacceptable. This is on-going, systemic
disregard for the project's other participants.
Please fix your mail user agents *now*.
Here's my promise. Next time, I'm going to revert such commits (assuming
I manage to catch them again). They do not represent the facts from the
mailing list.
Laszlo
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v3 00/16] Removed unused PCDs
2018-10-02 10:13 ` Laszlo Ersek
@ 2018-10-08 2:14 ` Zhang, Shenglei
2018-10-08 3:07 ` Ni, Ruiyu
1 sibling, 0 replies; 32+ messages in thread
From: Zhang, Shenglei @ 2018-10-08 2:14 UTC (permalink / raw)
To: Laszlo Ersek, Ni, Ruiyu, Zhang, Chao B
Cc: edk2-devel@lists.01.org, Kinney, Michael D
Hi all,
Sorry for that. Ray and Chao just helped me push the patches. It's my fault about the mistake.
I'll prepare patches more carefully next time and make sure all things correct.
Best Regards,
Shenglei
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, October 2, 2018 6:14 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; edk2-devel@lists.01.org;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
>
> Ray, Chao,
>
> guys, you keep breaking the development process. Please fix your email
> clients *now*.
>
>
> On 08/28/18 05:42, shenglei wrote:
> > shenglei (16):
> > IntelFsp2Pkg FspSecCore: Remove unused PCDs
> > IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs
> > IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs
> > IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs
> > IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD
> > IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
> > SecurityPkg/Tcg2ConfigPei: Remove an unused PCD
>
> This was patch #07 in this series. I had never reviewed it, yet Chao
> pushed it with my R-b as commit
>
> https://github.com/tianocore/edk2/commit/3e11c27f67ea
>
>
> > SecurityPkg/Tcg2Dxe: Remove unused PCDs
> > UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD
> > MdePkg/BaseLib: Remove an unused PCD
> > MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs
> > MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused
> PCD
> > ShellPkg/Shell: Remove unused PCDs
>
> This was patch #13 in this series. I reviewed it:
>
> http://mid.mail-archive.com/70dfa56d-6781-e8c0-f3f4-
> aa12558672b9@redhat.com
>
> but Ray pushed it as commit
>
> https://github.com/tianocore/edk2/commit/a9dfe53f56bb
>
> without my R-b tag. (Note: there was 1 month between my feedback and
> the
> push date.)
>
> The commit message now suggests that I ignored the patch (because I was
> on CC, but seemingly didn't respond). It mis-represents my acts.
>
>
> > ShellPkg/DpDynamicCommand: Remove unused PCDs
> > ShellPkg/UefiHandleParsingLib: Remove an unused PCD
>
> Same here. Patch #15, pushed as commit
>
> https://github.com/tianocore/edk2/commit/42a7c2871a65
>
> My review was at:
>
> http://mid.mail-archive.com/a70f17d9-b937-2835-4d71-
> 5464bad82219@redhat.com
>
> but it was dropped from the commit.
>
>
> > ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs
>
> Ditto. Patch #16. My review was at:
>
> http://mid.mail-archive.com/d23e7c95-96e9-4088-4e95-
> 5dbc0a331cb1@redhat.com
>
> but the patch was pushed as commit
>
> https://github.com/tianocore/edk2/commit/aa9986651bfe
>
> with my review lost.
>
>
> This is not the first time it has happened. If I remember correctly, Ray
> blamed his email client last time (not showing message threads
> correctly, or something similar).
>
> I'm sorry, but this is unacceptable. This is on-going, systemic
> disregard for the project's other participants.
>
> Please fix your mail user agents *now*.
>
> Here's my promise. Next time, I'm going to revert such commits (assuming
> I manage to catch them again). They do not represent the facts from the
> mailing list.
>
> Laszlo
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 00/16] Removed unused PCDs
2018-10-02 10:13 ` Laszlo Ersek
2018-10-08 2:14 ` Zhang, Shenglei
@ 2018-10-08 3:07 ` Ni, Ruiyu
2018-10-08 12:12 ` Laszlo Ersek
1 sibling, 1 reply; 32+ messages in thread
From: Ni, Ruiyu @ 2018-10-08 3:07 UTC (permalink / raw)
To: Laszlo Ersek, Zhang, Chao B
Cc: Zhang, Shenglei, edk2-devel@lists.01.org, Kinney, Michael D
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, October 2, 2018 6:14 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; edk2-devel@lists.01.org;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
>
> Ray, Chao,
>
> guys, you keep breaking the development process. Please fix your email
> clients *now*.
>
> This is not the first time it has happened. If I remember correctly, Ray blamed
> his email client last time (not showing message threads correctly, or
> something similar).
>
> I'm sorry, but this is unacceptable. This is on-going, systemic disregard for the
> project's other participants.
>
> Please fix your mail user agents *now*.
>
> Here's my promise. Next time, I'm going to revert such commits (assuming I
> manage to catch them again). They do not represent the facts from the
> mailing list.
Sorry about that. I can understand it.
So this is the first mail I choose to reply after a long holiday.
I am now using Mozilla Thunderbird to only receive mails from this mailing list.
This mail client can group the mails correctly so if I missed any R-b that's absolutely
my fault😊
There is a difference between help-to-push for Intel developers and non-Intel developers.
As the Intel developer, Shenglei is very kind to prepare the patch files with R-b and
send to me internally as attachments. All I need to do is pushing the patches.
Before the pushing, I will check whether there is R-b but won't check whether all R-bs
are there.
For non-Intel developers, I will edit the patch to list all R-bs before pushing.
Again, thanks for enforcing the process. We will follow the process more strictly in future.
>
> Laszlo
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 00/16] Removed unused PCDs
2018-10-08 3:07 ` Ni, Ruiyu
@ 2018-10-08 12:12 ` Laszlo Ersek
0 siblings, 0 replies; 32+ messages in thread
From: Laszlo Ersek @ 2018-10-08 12:12 UTC (permalink / raw)
To: Ni, Ruiyu, Zhang, Chao B
Cc: Zhang, Shenglei, edk2-devel@lists.01.org, Kinney, Michael D
Hi Ray,
On 10/08/18 05:07, Ni, Ruiyu wrote:
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Tuesday, October 2, 2018 6:14 PM
>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
>> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; edk2-devel@lists.01.org;
>> Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
>>
>> Ray, Chao,
>>
>> guys, you keep breaking the development process. Please fix your email
>> clients *now*.
>>
>> This is not the first time it has happened. If I remember correctly, Ray blamed
>> his email client last time (not showing message threads correctly, or
>> something similar).
>>
>> I'm sorry, but this is unacceptable. This is on-going, systemic disregard for the
>> project's other participants.
>>
>> Please fix your mail user agents *now*.
>>
>> Here's my promise. Next time, I'm going to revert such commits (assuming I
>> manage to catch them again). They do not represent the facts from the
>> mailing list.
>
> Sorry about that. I can understand it.
> So this is the first mail I choose to reply after a long holiday.
> I am now using Mozilla Thunderbird to only receive mails from this mailing list.
> This mail client can group the mails correctly so if I missed any R-b that's absolutely
> my fault😊
>
> There is a difference between help-to-push for Intel developers and non-Intel developers.
> As the Intel developer, Shenglei is very kind to prepare the patch files with R-b and
> send to me internally as attachments. All I need to do is pushing the patches.
> Before the pushing, I will check whether there is R-b but won't check whether all R-bs
> are there.
>
> For non-Intel developers, I will edit the patch to list all R-bs before pushing.
>
> Again, thanks for enforcing the process. We will follow the process more strictly in future.
Thank you for following up.
Traditionally, going through the review feedback, and picking up R-b /
T-b and similar tags, are the maintainer's task, involving a git-rebase
with "reword" operations, and the final push. I'm not sure how it helps
to split this work, for any given /single/ series, between multiple
people. To me it seems difficult to coordinate.
It definitely makes sense to distribute /multiple/ series over a pool of
maintainers. I think it's the sub-series granularity that is difficult.
In edk2's case, if I remember correctly, there have been some series
even that modified multiple Packages, and were finally pushed by a
single maintainer (after everything had been fully reviewed). That's a
good approach.
If I can help with pushing a patch set at any time (because it is fully
reviewed, but it's hard to find the time to wrangle the patches), please
ping me, on-list or off-list, as you prefer.
(We might also end up updating the workflow so that it become less
error-prone when not using the git command line.)
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 32+ messages in thread