From: BobCF <bob.c.feng@intel.com>
To: edk2-devel@lists.01.org
Subject: [Patch] BaseTools: Involve Dec default value to calculate Maxsize
Date: Thu, 30 Aug 2018 13:27:30 +0800 [thread overview]
Message-ID: <20180830052730.63120-1-bob.c.feng@intel.com> (raw)
Involve Dec default value to calculate Maxsize for structure PCD
Cc: Bob Feng <bob.c.feng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/Workspace/BuildClassObject.py | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/BaseTools/Source/Python/Workspace/BuildClassObject.py b/BaseTools/Source/Python/Workspace/BuildClassObject.py
index 88465c59ea..32d202de5e 100644
--- a/BaseTools/Source/Python/Workspace/BuildClassObject.py
+++ b/BaseTools/Source/Python/Workspace/BuildClassObject.py
@@ -91,10 +91,19 @@ class PcdClassObject(object):
return max([len(self.PcdValueFromComm)-2+1, MaxSize])
elif self.PcdValueFromComm.startswith("L\""):
return max([2*(len(self.PcdValueFromComm)-3+1), MaxSize])
else:
return max([len(self.PcdValueFromComm), MaxSize])
+ if hasattr(self, "DefaultValueFromDec"):
+ if self.DefaultValueFromDec.startswith("{") and self.DefaultValueFromDec.endswith("}"):
+ return max([len(self.DefaultValueFromDec.split(",")), MaxSize])
+ elif self.DefaultValueFromDec.startswith("\"") or self.DefaultValueFromDec.startswith("\'"):
+ return max([len(self.DefaultValueFromDec)-2+1, MaxSize])
+ elif self.DefaultValueFromDec.startswith("L\""):
+ return max([2*(len(self.DefaultValueFromDec)-3+1), MaxSize])
+ else:
+ return max([len(self.DefaultValueFromDec), MaxSize])
return MaxSize
## Get the number of bytes
def GetPcdSize(self):
if self.DatumType in TAB_PCD_NUMERIC_TYPES:
--
2.16.2.windows.1
next reply other threads:[~2018-08-30 5:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 5:27 BobCF [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-03 1:05 [Patch] BaseTools: Involve Dec default value to calculate Maxsize BobCF
2018-09-04 14:50 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830052730.63120-1-bob.c.feng@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox