From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 861C721107447 for ; Thu, 30 Aug 2018 09:15:53 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id o18-v6so2634307wmc.0 for ; Thu, 30 Aug 2018 09:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NtY95kJlBKIuQikJoY8565FO1Cs6phGCe2ZeIlJi8n0=; b=EaJ3lNngQd9VX2L2xGEMFmVhTTqw7yho8IANnTZV1j7LYt0IcTveGdNjPToRluTynz 6+Dx+QWxv3my5Dt/CivVzR22t3+/Zx99j7+OjXm8SkPwwjZ0512/rlaMBdi5slgqw0aH j20fUeeGoPiTSMW29pIWlDLChV07crF1NnS4s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NtY95kJlBKIuQikJoY8565FO1Cs6phGCe2ZeIlJi8n0=; b=Sym+eIyaVbwe5lPF/DuYSIZYLjFlEzJyn0KrSRKSrSHgOrIvTmvh76k9eSlv3kiG82 M+hqYXR/ZPVjPNcWVAAQNGYUfwCHWtuOmAQsLW0v6ie8ZUSTLzsl9l8njh+aEpUjLuRs C5zueHQZVew1ZI3a8kxV1v3xG6na7Y+vDZIVTmGTSce76SsTNL4V9E/gWcodlzIvp1eQ RzlOpbmpZcK8A1EwAwtVgbpvFxp37QnZeHttmgj0tzamUrXFyLEGST4c33FN3ctlYaF2 rE63vOlMFpEw9Ed9rm4mkHL2tNZ12L5LHDqthGwu6yYg1p4DMYw7V0mUaAaA6r79vSmP /oZw== X-Gm-Message-State: APzg51Dq0CmdSOSZEQekTebOb2P2IIpkx4WzS/JFuB2moyQ1XaUlkFkJ /FCmIJe36Hx65YMMSK9v/0kz0w== X-Google-Smtp-Source: ANB0VdYxOp3Z0wCrW7QL/rfd1KgSi859uhVuCtQp33/IIH+HY+IsW9TEmyWsGkHlisaNjdr4z/Wbxw== X-Received: by 2002:a1c:ee97:: with SMTP id j23-v6mr2289490wmi.66.1535645751527; Thu, 30 Aug 2018 09:15:51 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w3-v6sm4716609wrn.16.2018.08.30.09.15.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 09:15:50 -0700 (PDT) Date: Thu, 30 Aug 2018 17:15:48 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180830161548.yfrdsakzsgitiqpw@bivouac.eciton.net> References: <20180823160743.45638-1-ming.huang@linaro.org> <20180823160743.45638-31-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180823160743.45638-31-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 30/31] Hisilicon/D06: Add PciPlatformLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 16:15:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 24, 2018 at 12:07:42AM +0800, Ming Huang wrote: > Add a Null PciPlatformLib for build D06. The switch generic > PciHostBridge patch set add two api for PciPlatform driver, > so need to implement the two api for D06. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Reviewed-by: Leif Lindholm This library is required to build Silicon/Hisilicon/Drivers/PciPlatform/PciPlatform.inf, which exists in D06.dsc from the original revision in: Hisilicon/D06: Add several base file for D06 This breaks the build on every commit between these two points. If you are OK with the idea, I can just squash them together. There is nothing interesting done in this code anyway - it's just glue. Regards, Leif > --- > Platform/Hisilicon/D06/D06.dsc | 1 + > Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.inf | 30 +++++++++ > Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.c | 67 ++++++++++++++++++++ > 3 files changed, 98 insertions(+) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index e6bebfb78b..e828010abf 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -95,6 +95,7 @@ > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > !endif > PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf > + PciPlatformLib|Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.inf > > [LibraryClasses.common.SEC] > ArmPlatformLib|Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > diff --git a/Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.inf b/Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.inf > new file mode 100644 > index 0000000000..7648322522 > --- /dev/null > +++ b/Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.inf > @@ -0,0 +1,30 @@ > +## @file > +# PCI Segment Library for Hisilicon Hi1610/Hi1616 SoC with multiple RCs > +# > +# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2018, Linaro Ltd. All rights reserved.
> +# Copyright (c) 2018, Hisilicon Ltd. All rights reserved.
> +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php. > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = Hi1620PciPlatformLib > + FILE_GUID = 29ba30da-68bc-46a5-888f-c65dabb67fd8 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = PciPlatformLib > + > +[Sources] > + Hi1620PciPlatformLib.c > + > +[Packages] > + MdePkg/MdePkg.dec > diff --git a/Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.c b/Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.c > new file mode 100644 > index 0000000000..ff77974c0f > --- /dev/null > +++ b/Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.c > @@ -0,0 +1,67 @@ > +/** @file > +* > +* Copyright (c) 2018, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2018, Linaro Limited. All rights reserved. > +* > +* This program and the accompanying materials > +* are licensed and made available under the terms and conditions of the BSD License > +* which accompanies this distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#include > +#include > + > + > +/*++ > + > +Routine Description: > + > + Perform Platform initialization first in PciPlatform. > + > +Arguments: > + > +Returns: > + > + VOID. > + > +--*/ > +VOID > +EFIAPI > +PciInitPlatform ( > + VOID > + ) > +{ > + return; > +} > + > +/*++ > + > +Routine Description: > + > + Perform Platform initialization by the phase indicated. > + > +Arguments: > + > + HostBridge - The associated PCI host bridge handle. > + Phase - The phase of the PCI controller enumeration. > + ChipsetPhase - Defines the execution phase of the PCI chipset driver. > + > +Returns: > + > +--*/ > +VOID > +EFIAPI > +PhaseNotifyPlatform ( > + IN EFI_HANDLE HostBridge, > + IN EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PHASE Phase, > + IN EFI_PCI_CHIPSET_EXECUTION_PHASE ChipsetPhase > + ) > +{ > + return; > +} > + > -- > 2.18.0 >