From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ADC8021107454 for ; Thu, 30 Aug 2018 11:41:10 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id f21-v6so2948644wmc.5 for ; Thu, 30 Aug 2018 11:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZOSwSsnMdCrgG+QEyO2MVa0GHIlm3klsumN+mcZCXQY=; b=N0ARRPLY9VcH4tLOwMLCvvLL/VXGghw9RJzgL8BdLF43hrgUysKmIUdfN+MBJrQSqY G4CJl8fwuTGI6/t4BlZwqE4M49tKOI4/nb8DTG/1ts8k98afsRpsnspq6K3LMIjZ0BoG oZwu3KdjQicqsgSPFUp4IkWEwNR1AnJKnok0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZOSwSsnMdCrgG+QEyO2MVa0GHIlm3klsumN+mcZCXQY=; b=r5x8hhgv6geNPvL69UIszrizwY7ezCDyWLf2fUVNNrfdOWWG4hVVfvxuc0yolc5lvR 31JKioU8iPFpcGBRtT8KeTpje+sVCEAe7MPuodLLxhthxu0GlxarPIAYerFoAkOIcs/g EhWV82HfZAG12BoabdTbVMfTIEwpqFjy+f5/I6csNcZBVqyxRBorzofyR3FrpKPrzY7x CyjAEzib6gjAOF5r+moUuWqIZJk5ANsnYMFN3A5W5fp+yDtQbFk8zINdqRuwZTWmOJd0 Lg9+51nZ+9ItQTyvZGT4pLevTVJLgKP+kgalNpCKbUi2mIVjwktFE4KnVq+G076ytY4/ C+HQ== X-Gm-Message-State: APzg51COS3J26MIE1jh5JIVDJ5yjFZkjKtdYsH3bgVEV8DhxVUCN6UE6 kyuZ0GQiL4GJh38ByQbrNHzRuA== X-Google-Smtp-Source: ANB0VdZZqwol/Qg7NKHx93bVAnOKGJcHS/Cm8J1QHl4OmGkf+1zYdPkXqKEyU40HRWiYI3V3Wt2Q1g== X-Received: by 2002:a1c:80d8:: with SMTP id b207-v6mr2663884wmd.146.1535654469080; Thu, 30 Aug 2018 11:41:09 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v46-v6sm11763835wrc.63.2018.08.30.11.41.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 11:41:08 -0700 (PDT) Date: Thu, 30 Aug 2018 19:41:06 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Yang XinYi Message-ID: <20180830184106.pada5o3raqg5srwl@bivouac.eciton.net> References: <20180823160743.45638-1-ming.huang@linaro.org> <20180823160743.45638-17-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180823160743.45638-17-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 16/31] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 18:41:11 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Can you add Hi1620 to the subject line, so it's clear that this is a D06-specific library? With that Reviewed-by: Leif Lindholm / Leif On Fri, Aug 24, 2018 at 12:07:28AM +0800, Ming Huang wrote: > From: Yang XinYi > > Add Setup Item "EnableGOP" for D06, This Item only takes > effect on SM750. The SM750 is a VGA device under BMC and > the KVM output to SM750. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Include/Library/OemConfigData.h | 1 + > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 1 + > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr | 7 +++++++ > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni | 4 ++-- > 4 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Hisilicon/Include/Library/OemConfigData.h b/Silicon/Hisilicon/Include/Library/OemConfigData.h > index 8ab402144c..f120e3123c 100644 > --- a/Silicon/Hisilicon/Include/Library/OemConfigData.h > +++ b/Silicon/Hisilicon/Include/Library/OemConfigData.h > @@ -60,6 +60,7 @@ typedef struct { > /*Misc Config*/ > UINT8 EnableSmmu; > UINT8 EnableFdtTable; > + UINT8 EnableGOP; > /*RAS Config*/ > UINT8 EnRasSupport; > UINT8 EnPoison; > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > index f49fb3533b..012d45bc02 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > @@ -294,6 +294,7 @@ OemConfigUiLibConstructor ( > // > Configuration.EnableSmmu = 1; > Configuration.EnableFdtTable = 0; > + Configuration.EnableGOP = 0; > // > //Set the default value of the Ras option > // > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > index 819c2b988d..16ce27b95b 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > @@ -31,4 +31,11 @@ form formid = MISC_CONFIG_FORM_ID, > option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; > endoneof; > > + oneof varid = OEM_CONFIG_DATA.EnableGOP, > + prompt = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER), > + help = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER_HELP), > + option text = STRING_TOKEN(STR_DISABLED), value = 0, flags = DEFAULT; > + option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; > + endoneof; > + > endform; > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > index 53eb1622c4..2fd92fedff 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > @@ -23,5 +23,5 @@ > #string STR_FDT_CONFIG_HELP #language en-US "Enable or Disable Fdt Table." > #string STR_ENABLE_SPCR_TABLE #language en-US "Support SPCR" > #string STR_ENABLE_SPCR_HELP #language en-US "Enable or Disable SPCR Table." > -#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB" > -#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer." > +#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB for SM750" > +#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer for SM750." > -- > 2.18.0 >