From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC2412110746B for ; Thu, 30 Aug 2018 11:47:40 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id o18-v6so3049630wmc.0 for ; Thu, 30 Aug 2018 11:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ulE0mCufwKCqi6PcqCRf+thOCrn+BbuCjs90Jgxfsok=; b=MTKgRd1an23wFuCatMSnRBmwwfLZZoM/A/AIKNXebzxa0W6N5tqO/2R47WsBHmbZD6 Oz+ht1cLl6tIcqVD7zvmYXB1c7GTFP3PxaCMpJo//wcweztGYHxsnjYpZ06tzWUF3sFP c9LbSJhoI/+h/f0fgNa1pcabz3wdnhe3YLDbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ulE0mCufwKCqi6PcqCRf+thOCrn+BbuCjs90Jgxfsok=; b=gbfeiqoKuVdSAZ6fxXbZctQVyww+nB0z1jZ7gZnGiJH3P0w00L1/EZ2f8sfljpn1j6 c71qN0JW0xX/lhB+4XoOXxUbShtiSxRtO3FRgg9MQcvq/kshmTXKfNsSDzt9cApO8uy7 PwnPXR1PBsvAVvrSE+/vRWRVittAbugTuphpOTHuchOGrggZhNKPPu1GJaSqy8pPw7lL +g+j9tQvLvfgWb3UGfQO/S+PimfEFchYPpNE3mcPDvHWRW4+OcI4a+Z+bSTTFmmF15Lz zj3OeWQQ77VFij5mGH7SzTH0om0ku2ZimmNvWIrguwyMp+Z0GF4TsFS5EVjnYZRgAdVX x+YA== X-Gm-Message-State: APzg51BVpp1JzOzuIzCkVb0fVP5Imc7bPpylEm41w22+tStwNVzxlrGB 9SiAunUT9bDSmo49pFpSkYl1RQ== X-Google-Smtp-Source: ANB0Vda0Ycisr4Fyg2YM+qibcdkThtPxJ+ScZekAUe4Hpsw0wDxR5gbdiJnp+U3q8yIa1wgU37VBGQ== X-Received: by 2002:a1c:7305:: with SMTP id d5-v6mr2630321wmb.53.1535654859270; Thu, 30 Aug 2018 11:47:39 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o33-v6sm13593110wrf.11.2018.08.30.11.47.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 11:47:38 -0700 (PDT) Date: Thu, 30 Aug 2018 19:47:35 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Luqi Jiang Message-ID: <20180830184735.5nvpsmenh3naounj@bivouac.eciton.net> References: <20180823160743.45638-1-ming.huang@linaro.org> <20180823160743.45638-25-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180823160743.45638-25-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 24/31] Hisilicon/D06: add apei driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 18:47:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 24, 2018 at 12:07:36AM +0800, Ming Huang wrote: > From: Luqi Jiang > > This driver provide a means for the platform to > convey error information to OSPM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang As far as I can see, this addresses all of my feedback: Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/D06.dsc | 1 + > Platform/Hisilicon/D06/D06.fdf | 1 + > Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.inf | 59 +++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.h | 41 +++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Bert/Bert.h | 43 +++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Einj/Einj.h | 146 ++++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/ErrorSource/Ghes.h | 110 ++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Erst/Erst.h | 140 ++++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Hest/Hest.h | 59 +++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/OemApeiHi1620.h | 43 +++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.c | 108 ++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Bert/Bert.c | 91 +++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Einj/Einj.c | 349 ++++++++++++++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/ErrorSource/Ghes.c | 330 +++++++++++++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Erst/Erst.c | 374 ++++++++++++++++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/Hest/Hest.c | 118 ++++++ > Silicon/Hisilicon/Hi1620/Drivers/Apei/OemApeiHi1620.c | 337 ++++++++++++++++++ > 17 files changed, 2350 insertions(+)