From: Ruiyu Ni <ruiyu.ni@intel.com>
To: edk2-devel@lists.01.org
Cc: Dandan Bi <dandan.bi@intel.com>
Subject: [PATCH] EmulatorPkg/PlatformBmLib: Fix GCC build failure
Date: Mon, 3 Sep 2018 10:24:06 +0800 [thread overview]
Message-ID: <20180903022406.25580-1-ruiyu.ni@intel.com> (raw)
Some local variables are initialized but never used.
GCC complains about that. The patch fixes this issue.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c b/EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c
index 5b39776..b07226f 100644
--- a/EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c
+++ b/EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c
@@ -41,26 +41,15 @@ PlatformBootManagerMemoryTest (
EFI_GENERIC_MEMORY_TEST_PROTOCOL *GenMemoryTest;
UINT64 TestedMemorySize;
UINT64 TotalMemorySize;
- UINT64 PreviousValue;
BOOLEAN ErrorOut;
BOOLEAN TestAbort;
EFI_INPUT_KEY Key;
- CHAR16 *StrTotalMemory;
- CHAR16 *Pos;
- UINTN StrTotalMemorySize;
ReturnStatus = EFI_SUCCESS;
ZeroMem (&Key, sizeof (EFI_INPUT_KEY));
- StrTotalMemorySize = 128;
- Pos = AllocateZeroPool (StrTotalMemorySize);
- ASSERT (Pos != NULL);
-
- StrTotalMemory = Pos;
-
TestedMemorySize = 0;
TotalMemorySize = 0;
- PreviousValue = 0;
ErrorOut = FALSE;
TestAbort = FALSE;
@@ -72,7 +61,6 @@ PlatformBootManagerMemoryTest (
(VOID **) &GenMemoryTest
);
if (EFI_ERROR (Status)) {
- FreePool (Pos);
return EFI_SUCCESS;
}
@@ -89,7 +77,6 @@ PlatformBootManagerMemoryTest (
// do the test, and then the status of EFI_NO_MEDIA will be returned by
// "MemoryTestInit". So it does not need to test memory again, just return.
//
- FreePool (Pos);
return EFI_SUCCESS;
}
@@ -128,6 +115,5 @@ PlatformBootManagerMemoryTest (
Done:
DEBUG ((DEBUG_INFO, "%d bytes of system memory tested OK\r\n", TotalMemorySize));
- FreePool (Pos);
return ReturnStatus;
}
--
2.7.4
next reply other threads:[~2018-09-03 2:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 2:24 Ruiyu Ni [this message]
2018-09-03 7:09 ` [PATCH] EmulatorPkg/PlatformBmLib: Fix GCC build failure Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903022406.25580-1-ruiyu.ni@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox