public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>,
	Henri Yandell <flamefew@gmail.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>,
	"Cetola, Stephano" <stephano.cetola@intel.com>
Subject: Re: Missing ‘or’ in CLA
Date: Mon, 3 Sep 2018 12:08:52 +0100	[thread overview]
Message-ID: <20180903110852.xxm4enjitebmisbf@bivouac.eciton.net> (raw)
In-Reply-To: <bb0e2b8d-c597-fd99-eabd-d264943397f9@redhat.com>

On Fri, Aug 31, 2018 at 09:30:31PM +0200, Laszlo Ersek wrote:
> On 08/31/18 01:58, Henri Yandell wrote:
> > The CLA is missing an ‘or’ in section 3.
> > 
> > See https://github.com/tianocore/edk2/pull/133/files for an example of the
> > specific text.
> 
> could you please turn this report into a real patch (if the suggested
> change is valid)? Technically it's easy enough so I could do it as well,
> just so we have something to review on the list, but:
> - I have no idea if the suggested change is valid,
> - I wasn't around when "Contributions.txt" was originally invented.

Would this require a revision bump to 1.2?

Whether a valid correction or not, it changes the premises under which
certain organisations have confirmed they are happy to contribute.
Moreso in my eyes than the change that lead to the bump to 1.1.

/
    Leif


  parent reply	other threads:[~2018-09-03 11:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 23:58 Missing ‘or’ in CLA Henri Yandell
2018-08-31 19:30 ` Laszlo Ersek
2018-09-01 22:29   ` Henri Yandell
2018-09-03 11:08   ` Leif Lindholm [this message]
2018-09-03 21:44     ` Henri Yandell
2018-09-14 22:34       ` Henri Yandell
2018-09-15  0:38         ` Kinney, Michael D
2018-09-15  3:25           ` Henri Yandell
2018-09-17  3:57             ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903110852.xxm4enjitebmisbf@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox