* [PATCH] ShellPkg Shell: Remove an unused global variable
@ 2018-09-07 1:52 shenglei
2018-09-07 4:39 ` Ni, Ruiyu
0 siblings, 1 reply; 3+ messages in thread
From: shenglei @ 2018-09-07 1:52 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni
The unused global variable InvalidChars is removed.
It is only used in the function IsValidCommandName which
was removed previously.
https://bugzilla.tianocore.org/show_bug.cgi?id=1066
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
ShellPkg/Application/Shell/Shell.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 397cfd1994..3f3bcbb4b0 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -2750,9 +2750,6 @@ RunCommand(
return (RunShellCommand(CmdLine, NULL));
}
-
-STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
-
/**
Function to process a NSH script file via SHELL_FILE_HANDLE.
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg Shell: Remove an unused global variable
2018-09-07 1:52 [PATCH] ShellPkg Shell: Remove an unused global variable shenglei
@ 2018-09-07 4:39 ` Ni, Ruiyu
2018-09-07 11:14 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Ni, Ruiyu @ 2018-09-07 4:39 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
> Sent: Friday, September 7, 2018 9:52 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable
>
> The unused global variable InvalidChars is removed.
> It is only used in the function IsValidCommandName which was removed
> previously.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1066
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> ShellPkg/Application/Shell/Shell.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 397cfd1994..3f3bcbb4b0 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -2750,9 +2750,6 @@ RunCommand(
> return (RunShellCommand(CmdLine, NULL)); }
>
> -
> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
> 0x0001, 0x0002};
> -
> /**
> Function to process a NSH script file via SHELL_FILE_HANDLE.
>
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg Shell: Remove an unused global variable
2018-09-07 4:39 ` Ni, Ruiyu
@ 2018-09-07 11:14 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2018-09-07 11:14 UTC (permalink / raw)
To: Ni, Ruiyu, Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
On 09/07/18 06:39, Ni, Ruiyu wrote:
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Commit 98257f982072.
Thanks
Laszlo
>> -----Original Message-----
>> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
>> Sent: Friday, September 7, 2018 9:52 AM
>> To: edk2-devel@lists.01.org
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
>> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable
>>
>> The unused global variable InvalidChars is removed.
>> It is only used in the function IsValidCommandName which was removed
>> previously.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1066
>>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: shenglei <shenglei.zhang@intel.com>
>> ---
>> ShellPkg/Application/Shell/Shell.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/ShellPkg/Application/Shell/Shell.c
>> b/ShellPkg/Application/Shell/Shell.c
>> index 397cfd1994..3f3bcbb4b0 100644
>> --- a/ShellPkg/Application/Shell/Shell.c
>> +++ b/ShellPkg/Application/Shell/Shell.c
>> @@ -2750,9 +2750,6 @@ RunCommand(
>> return (RunShellCommand(CmdLine, NULL)); }
>>
>> -
>> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
>> 0x0001, 0x0002};
>> -
>> /**
>> Function to process a NSH script file via SHELL_FILE_HANDLE.
>>
>> --
>> 2.18.0.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-07 11:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 1:52 [PATCH] ShellPkg Shell: Remove an unused global variable shenglei
2018-09-07 4:39 ` Ni, Ruiyu
2018-09-07 11:14 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox