* [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue
@ 2018-09-15 6:33 Ming Huang
2018-09-15 6:33 ` [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: " Ming Huang
0 siblings, 1 reply; 3+ messages in thread
From: Ming Huang @ 2018-09-15 6:33 UTC (permalink / raw)
To: huangming23, edk2-devel
When some type raid cards is not healthy, such as Broadcom 3108/3508
raid card, board will enter endless loop in BmRepairAllControllers()
and can't show configuration formset which need to repair raid card.
Ming Huang (1):
MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue
.../UefiBootManagerLib/UefiBootManagerLib.inf | 2 +
.../UefiBootManagerLib/BmDriverHealth.c | 48 ++++++++++++++++++-
2 files changed, 49 insertions(+), 1 deletion(-)
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue
2018-09-15 6:33 [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue Ming Huang
@ 2018-09-15 6:33 ` Ming Huang
0 siblings, 0 replies; 3+ messages in thread
From: Ming Huang @ 2018-09-15 6:33 UTC (permalink / raw)
To: huangming23, edk2-devel
When some type raid cards is not healthy, such as Broadcom 3108/3508
raid card, board will enter endless loop in BmRepairAllControllers()
and can't show configuration formset which need to repair raid card.
DriverHealthManagerDxe is added to platform dsc/fdf, driver health
manager menu can show drivers which are not healthy, but raid card
can not be repaired by the menus under Device Manager. This modification
of BmRepairAllControllers() can show configuration formset for repair
when booting an option.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 2 +
MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c | 48 +++++++++++++++++++-
2 files changed, 49 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index 228b91033695..b9f96c763ff6 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -89,6 +89,8 @@ [Guids]
gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
+ gEfiHiiDriverHealthFormsetGuid
+ gEfiHiiPlatformSetupFormsetGuid
[Protocols]
gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c
index ecd01bbb81e3..fd47651ec937 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c
@@ -421,6 +421,47 @@ EfiBootManagerFreeDriverHealthInfo (
return gBS->FreePool (DriverHealthInfo);
}
+STATIC
+VOID
+ShowConfigureForm (
+ EFI_FORM_BROWSER2_PROTOCOL *FormBrowser2,
+ EFI_BOOT_MANAGER_DRIVER_HEALTH_INFO *DriverHealthInfo
+ )
+{
+ EFI_STATUS Status;
+ EFI_HII_HANDLE FormHiiHandle;
+ EFI_DRIVER_HEALTH_STATUS HealthStatus;
+
+ if (DriverHealthInfo != NULL) {
+ Status = DriverHealthInfo->DriverHealth->GetHealthStatus (
+ DriverHealthInfo->DriverHealth,
+ DriverHealthInfo->ControllerHandle,
+ DriverHealthInfo->ChildHandle,
+ &HealthStatus,
+ NULL,
+ &FormHiiHandle
+ );
+ if (!EFI_ERROR (Status) &&
+ (HealthStatus == EfiDriverHealthStatusConfigurationRequired) &&
+ (FormHiiHandle != NULL)) {
+ Status = FormBrowser2->SendForm (
+ FormBrowser2,
+ &FormHiiHandle,
+ 1,
+ &gEfiHiiPlatformSetupFormsetGuid,
+ 0,
+ NULL,
+ NULL
+ );
+ if (EFI_ERROR (Status)) {
+ Print (L"Show configurae menu:%r\n", Status);
+ }
+ }
+ }
+
+ return;
+}
+
/**
Repair all the controllers according to the Driver Health status queried.
@@ -434,6 +475,7 @@ BmRepairAllControllers (
{
EFI_STATUS Status;
EFI_BOOT_MANAGER_DRIVER_HEALTH_INFO *DriverHealthInfo;
+ EFI_BOOT_MANAGER_DRIVER_HEALTH_INFO *InfoConfigurationRequired;
EFI_DRIVER_HEALTH_STATUS HealthStatus;
UINTN Count;
UINTN Index;
@@ -462,6 +504,7 @@ BmRepairAllControllers (
do {
RepairRequired = FALSE;
ConfigurationRequired = FALSE;
+ InfoConfigurationRequired = NULL;
//
// Deal with Repair Required
@@ -470,6 +513,7 @@ BmRepairAllControllers (
for (Index = 0; Index < Count; Index++) {
if (DriverHealthInfo[Index].HealthStatus == EfiDriverHealthStatusConfigurationRequired) {
ConfigurationRequired = TRUE;
+ InfoConfigurationRequired = &DriverHealthInfo[Index];
}
if (DriverHealthInfo[Index].HealthStatus == EfiDriverHealthStatusRepairRequired) {
@@ -494,6 +538,7 @@ BmRepairAllControllers (
);
if (!EFI_ERROR (Status) && (HealthStatus == EfiDriverHealthStatusConfigurationRequired)) {
ConfigurationRequired = TRUE;
+ InfoConfigurationRequired = &DriverHealthInfo[Index];
}
}
}
@@ -507,12 +552,13 @@ BmRepairAllControllers (
FormBrowser2,
&HiiHandles[Index],
1,
- PcdGetPtr (PcdDriverHealthConfigureForm),
+ &gEfiHiiDriverHealthFormsetGuid,
0,
NULL,
NULL
);
if (!EFI_ERROR (Status)) {
+ ShowConfigureForm (FormBrowser2, InfoConfigurationRequired);
break;
}
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue
@ 2018-09-15 6:36 Ming Huang
0 siblings, 0 replies; 3+ messages in thread
From: Ming Huang @ 2018-09-15 6:36 UTC (permalink / raw)
To: linaro-uefi, edk2-devel, star.zeng, eric.dong
Cc: leif.lindholm, ard.biesheuvel, michael.d.kinney, liming.gao,
wanghuiqiang, huangming23, zhangjinsong2, huangdaode, waip23,
Ming Huang
When some type raid cards is not healthy, such as Broadcom 3108/3508
raid card, board will enter endless loop in BmRepairAllControllers()
and can't show configuration formset which need to repair raid card.
Ming Huang (1):
MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue
.../UefiBootManagerLib/UefiBootManagerLib.inf | 2 +
.../UefiBootManagerLib/BmDriverHealth.c | 48 ++++++++++++++++++-
2 files changed, 49 insertions(+), 1 deletion(-)
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-15 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-15 6:33 [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue Ming Huang
2018-09-15 6:33 ` [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: " Ming Huang
-- strict thread matches above, loose matches on Subject: below --
2018-09-15 6:36 [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] " Ming Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox