* [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file.
@ 2018-09-21 1:00 Chen A Chen
2018-09-21 1:00 ` [PATCH 2/3] MdeModulePkg: " Chen A Chen
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Chen A Chen @ 2018-09-21 1:00 UTC (permalink / raw)
To: edk2-devel; +Cc: Chen A Chen, Liming Gao, Michael D Kinney
The PalLib will remove in MdePkg, so remove this lib from DSC file.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
---
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
index 84e1d890b5..894c5340a0 100644
--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
@@ -75,7 +75,6 @@
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
- PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf
[LibraryClasses.common.PEIM]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. 2018-09-21 1:00 [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file Chen A Chen @ 2018-09-21 1:00 ` Chen A Chen 2018-09-21 3:48 ` Zeng, Star 2018-09-21 1:00 ` [PATCH 3/3] SignedCapsulePkg: " Chen A Chen 2018-09-25 1:16 ` [PATCH 1/3] IntelFrameworkModulePkg: " Gao, Liming 2 siblings, 1 reply; 8+ messages in thread From: Chen A Chen @ 2018-09-21 1:00 UTC (permalink / raw) To: edk2-devel; +Cc: Chen A Chen, Star Zeng, Eric Dong, Michael D Kinney The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Star Zeng <star.zeng@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen <chen.a.chen@intel.com> --- MdeModulePkg/MdeModulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 8a81ea141f..3ff3b1213c 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -79,7 +79,6 @@ SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf # -- 2.16.2.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. 2018-09-21 1:00 ` [PATCH 2/3] MdeModulePkg: " Chen A Chen @ 2018-09-21 3:48 ` Zeng, Star 2018-09-25 0:43 ` Chen, Chen A 0 siblings, 1 reply; 8+ messages in thread From: Zeng, Star @ 2018-09-21 3:48 UTC (permalink / raw) To: Chen, Chen A, edk2-devel@lists.01.org Cc: Dong, Eric, Kinney, Michael D, Zeng, Star As I remember, I raised comment about removing the PalLib in MdeModulePkg.dsc at https://lists.01.org/pipermail/edk2-devel/2018-June/026079.html. I'd like suggest updating the title and commit message a little. For title: How about "MdeModulePkg: Remove PalLib in dsc which was missed at de00522" ? For commit message: How about like below? The PalLib is IPF specific and will be removed from MdePkg. So this patch removes PalLib in MdeModulePkg.dsc which was missed at de005223b77c473d45c9c8a11147f6968325f73e. With them accepted, Reviewed-by: Star Zeng <star.zeng@intel.com>. Thanks, Star -----Original Message----- From: Chen, Chen A Sent: Friday, September 21, 2018 9:00 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A <chen.a.chen@intel.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Star Zeng <star.zeng@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen <chen.a.chen@intel.com> --- MdeModulePkg/MdeModulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 8a81ea141f..3ff3b1213c 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -79,7 +79,6 @@ SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf # -- 2.16.2.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. 2018-09-21 3:48 ` Zeng, Star @ 2018-09-25 0:43 ` Chen, Chen A 0 siblings, 0 replies; 8+ messages in thread From: Chen, Chen A @ 2018-09-25 0:43 UTC (permalink / raw) To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Dong, Eric, Kinney, Michael D Good suggest for me. -----Original Message----- From: Zeng, Star Sent: Friday, September 21, 2018 11:48 AM To: Chen, Chen A <chen.a.chen@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.dong@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Zeng, Star <star.zeng@intel.com> Subject: RE: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. As I remember, I raised comment about removing the PalLib in MdeModulePkg.dsc at https://lists.01.org/pipermail/edk2-devel/2018-June/026079.html. I'd like suggest updating the title and commit message a little. For title: How about "MdeModulePkg: Remove PalLib in dsc which was missed at de00522" ? For commit message: How about like below? The PalLib is IPF specific and will be removed from MdePkg. So this patch removes PalLib in MdeModulePkg.dsc which was missed at de005223b77c473d45c9c8a11147f6968325f73e. With them accepted, Reviewed-by: Star Zeng <star.zeng@intel.com>. Thanks, Star -----Original Message----- From: Chen, Chen A Sent: Friday, September 21, 2018 9:00 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A <chen.a.chen@intel.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Star Zeng <star.zeng@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen <chen.a.chen@intel.com> --- MdeModulePkg/MdeModulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 8a81ea141f..3ff3b1213c 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -79,7 +79,6 @@ SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf # -- 2.16.2.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] SignedCapsulePkg: Remove the missing PalLib in DSC file. 2018-09-21 1:00 [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file Chen A Chen 2018-09-21 1:00 ` [PATCH 2/3] MdeModulePkg: " Chen A Chen @ 2018-09-21 1:00 ` Chen A Chen 2018-09-21 1:02 ` Yao, Jiewen 2018-09-25 1:16 ` [PATCH 1/3] IntelFrameworkModulePkg: " Gao, Liming 2 siblings, 1 reply; 8+ messages in thread From: Chen A Chen @ 2018-09-21 1:00 UTC (permalink / raw) To: edk2-devel; +Cc: Chen A Chen, Jiewen Yao, Michael D Kinney The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen <chen.a.chen@intel.com> --- SignedCapsulePkg/SignedCapsulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc index 7ea74d7346..db7f176166 100644 --- a/SignedCapsulePkg/SignedCapsulePkg.dsc +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc @@ -77,7 +77,6 @@ SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf # # Misc -- 2.16.2.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] SignedCapsulePkg: Remove the missing PalLib in DSC file. 2018-09-21 1:00 ` [PATCH 3/3] SignedCapsulePkg: " Chen A Chen @ 2018-09-21 1:02 ` Yao, Jiewen 0 siblings, 0 replies; 8+ messages in thread From: Yao, Jiewen @ 2018-09-21 1:02 UTC (permalink / raw) To: Chen, Chen A, edk2-devel@lists.01.org; +Cc: Kinney, Michael D Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Chen, Chen A > Sent: Friday, September 21, 2018 9:00 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A <chen.a.chen@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: [PATCH 3/3] SignedCapsulePkg: Remove the missing PalLib in DSC > file. > > The PalLib will remove in MdePkg, so remove this lib from DSC file. > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chen A Chen <chen.a.chen@intel.com> > --- > SignedCapsulePkg/SignedCapsulePkg.dsc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc > b/SignedCapsulePkg/SignedCapsulePkg.dsc > index 7ea74d7346..db7f176166 100644 > --- a/SignedCapsulePkg/SignedCapsulePkg.dsc > +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc > @@ -77,7 +77,6 @@ > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in > f > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in > f > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf > > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Custo > mizedDisplayLib.inf > # > # Misc > -- > 2.16.2.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file. 2018-09-21 1:00 [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file Chen A Chen 2018-09-21 1:00 ` [PATCH 2/3] MdeModulePkg: " Chen A Chen 2018-09-21 1:00 ` [PATCH 3/3] SignedCapsulePkg: " Chen A Chen @ 2018-09-25 1:16 ` Gao, Liming 2018-09-25 1:16 ` Chen, Chen A 2 siblings, 1 reply; 8+ messages in thread From: Gao, Liming @ 2018-09-25 1:16 UTC (permalink / raw) To: Chen, Chen A, edk2-devel@lists.01.org; +Cc: Kinney, Michael D Chen: Please update patch title and commit message to follow Star comments. Reviewed-by: Liming Gao <liming.gao@intel.com> Thanks Liming >-----Original Message----- >From: Chen, Chen A >Sent: Friday, September 21, 2018 9:00 AM >To: edk2-devel@lists.01.org >Cc: Chen, Chen A <chen.a.chen@intel.com>; Gao, Liming ><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> >Subject: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib >in DSC file. > >The PalLib will remove in MdePkg, so remove this lib from DSC file. > >Cc: Liming Gao <liming.gao@intel.com> >Cc: Michael D Kinney <michael.d.kinney@intel.com> >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Chen A Chen <chen.a.chen@intel.com> >--- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >index 84e1d890b5..894c5340a0 100644 >--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >@@ -75,7 +75,6 @@ > >DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTable >Lib.inf > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf >- PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf > > [LibraryClasses.common.PEIM] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf >-- >2.16.2.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file. 2018-09-25 1:16 ` [PATCH 1/3] IntelFrameworkModulePkg: " Gao, Liming @ 2018-09-25 1:16 ` Chen, Chen A 0 siblings, 0 replies; 8+ messages in thread From: Chen, Chen A @ 2018-09-25 1:16 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Kinney, Michael D Ok -----Original Message----- From: Gao, Liming Sent: Tuesday, September 25, 2018 9:16 AM To: Chen, Chen A <chen.a.chen@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file. Chen: Please update patch title and commit message to follow Star comments. Reviewed-by: Liming Gao <liming.gao@intel.com> Thanks Liming >-----Original Message----- >From: Chen, Chen A >Sent: Friday, September 21, 2018 9:00 AM >To: edk2-devel@lists.01.org >Cc: Chen, Chen A <chen.a.chen@intel.com>; Gao, Liming ><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> >Subject: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib >in DSC file. > >The PalLib will remove in MdePkg, so remove this lib from DSC file. > >Cc: Liming Gao <liming.gao@intel.com> >Cc: Michael D Kinney <michael.d.kinney@intel.com> >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Chen A Chen <chen.a.chen@intel.com> >--- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >index 84e1d890b5..894c5340a0 100644 >--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >@@ -75,7 +75,6 @@ > >DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTable >Lib.inf > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf >- PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf > > [LibraryClasses.common.PEIM] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf >-- >2.16.2.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-25 1:21 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-09-21 1:00 [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file Chen A Chen 2018-09-21 1:00 ` [PATCH 2/3] MdeModulePkg: " Chen A Chen 2018-09-21 3:48 ` Zeng, Star 2018-09-25 0:43 ` Chen, Chen A 2018-09-21 1:00 ` [PATCH 3/3] SignedCapsulePkg: " Chen A Chen 2018-09-21 1:02 ` Yao, Jiewen 2018-09-25 1:16 ` [PATCH 1/3] IntelFrameworkModulePkg: " Gao, Liming 2018-09-25 1:16 ` Chen, Chen A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox