[PATCH 0/2] Fix Nt32Pkg/EmulatorPkg boot failure

[PATCH 0/2] Fix Nt32Pkg/EmulatorPkg boot failure

[Jian J Wang]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215

This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.

Jian J Wang (2):
  Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure
  EmulatorPkg/EmulatorPkg.dsc: override PCD default to avoid boot
    failure

 EmulatorPkg/EmulatorPkg.dsc | 1 +
 Nt32Pkg/Nt32Pkg.dsc         | 1 +
 2 files changed, 2 insertions(+)

-- 
2.19.0.windows.1

[PATCH 1/2] Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure

[Jian J Wang]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215

This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.

The reason is this commit changed the condition of building page table
in DxeIpl. The code before it will only build page table for the sake
of PcdSetNxForStack. This commit added PcdImageProtectionPolicy and
PcdDxeNxMemoryProtectionPolicy into the logic. But the default value of
PcdImageProtectionPolicy is 02, which means the DxeIpl should build page
table. Due to the fact that Nt32Pkg doesn't support page table at all,
this will cause exception on Windows OS.

This patch solves this issue by setting PcdImageProtectionPolicy to 0
explicitly in Nt32Pkg.dsc.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 Nt32Pkg/Nt32Pkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
index fcd833858d..58d9f8787d 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -265,6 +265,7 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdVariableCollectStatistics|TRUE
 
 [PcdsFixedAtBuild]
+  gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy|0x00000000
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule|0x0
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizePopulateCapsule|0x0
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000040
-- 
2.19.0.windows.1

[PATCH 2/2] EmulatorPkg/EmulatorPkg.dsc: override PCD default to avoid boot failure

[Jian J Wang]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215

This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.

The reason is this commit changed the condition of building page table
in DxeIpl. The code before it will only build page table for the sake
of PcdSetNxForStack. This commit added PcdImageProtectionPolicy and
PcdDxeNxMemoryProtectionPolicy into the logic. But the default value of
PcdImageProtectionPolicy is 02, which means the DxeIpl should build page
table. Due to the fact that EmulatorPkg doesn't support page table at all,
this will cause exception on Windows OS.

This patch solves this issue by setting PcdImageProtectionPolicy to 0
explicitly in EmulatorPkg.dsc.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 EmulatorPkg/EmulatorPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 78e9a3f1cc..c8c444fe1c 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -179,6 +179,7 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplBuildPageTables|FALSE
 
 [PcdsFixedAtBuild]
+  gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy|0x00000000
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000040
   gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f
-- 
2.19.0.windows.1

Re: [PATCH 0/2] Fix Nt32Pkg/EmulatorPkg boot failure

[Zeng, Star]

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] 
Sent: Thursday, September 27, 2018 3:14 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH 0/2] Fix Nt32Pkg/EmulatorPkg boot failure

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215

This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.

Jian J Wang (2):
  Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure
  EmulatorPkg/EmulatorPkg.dsc: override PCD default to avoid boot
    failure

 EmulatorPkg/EmulatorPkg.dsc | 1 +
 Nt32Pkg/Nt32Pkg.dsc         | 1 +
 2 files changed, 2 insertions(+)

-- 
2.19.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH 0/2] Fix Nt32Pkg/EmulatorPkg boot failure

[Ni, Ruiyu]

On 9/27/2018 3:13 PM, edk2-devel-bounces@lists.01.org wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215
> 
> This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.
> 
> Jian J Wang (2):
>    Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure
>    EmulatorPkg/EmulatorPkg.dsc: override PCD default to avoid boot
>      failure
> 
>   EmulatorPkg/EmulatorPkg.dsc | 1 +
>   Nt32Pkg/Nt32Pkg.dsc         | 1 +
>   2 files changed, 2 insertions(+)
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray