public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Songpeng Li <songpeng.li@intel.com>
To: edk2-devel@lists.01.org
Cc: Fu Siyuan <siyuan.fu@intel.com>, Wu Jiaxin <jiaxin.wu@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI
Date: Thu, 27 Sep 2018 15:37:04 +0800	[thread overview]
Message-ID: <20180927073704.15152-1-songpeng.li@intel.com> (raw)

In DevPathToTextiSCSI(), ISCSIDevPath->Lun is printed in reversed orders.

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1216
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
 MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
index 7d8d304f6f..3f6478e43c 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
@@ -1548,7 +1548,7 @@ DevPathToTextiSCSI (
     ISCSIDevPath->TargetName,
     ISCSIDevPath->TargetPortalGroupTag
     );
-  for (Index = 0; Index < sizeof (ISCSIDevPath->Lun) / sizeof (UINT8); Index++) {
+  for (Index = sizeof (ISCSIDevPath->Lun) / sizeof (UINT8) - 1; Index >= 0; Index--) {
     UefiDevicePathLibCatPrint (Str, L"%02x", ((UINT8 *)&ISCSIDevPath->Lun)[Index]);
   }
   Options = ISCSIDevPath->LoginOption;
-- 
2.18.0.windows.1



             reply	other threads:[~2018-09-27  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  7:37 Songpeng Li [this message]
2018-09-27  7:51 ` [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI Fu, Siyuan
2018-09-27  8:09   ` Li, Songpeng
2018-09-27 15:03 ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927073704.15152-1-songpeng.li@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox