public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Songpeng Li <songpeng.li@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v2 0/2] fix read memory access overflow in HTTPBoot
Date: Fri, 28 Sep 2018 11:02:33 +0800	[thread overview]
Message-ID: <20180928030235.1080-1-songpeng.li@intel.com> (raw)

The input param String of AsciiStrStr() requires a pointer to
 Null-terminated string, however in HttpTcpReceiveHeader() and
 HttpUtilitiesParse(), the Buffersize before AllocateZeroPool()
 is equal to the size of TCP header, after the CopyMem(), it
 might not end with Null-terminator. It might cause memory
 access overflow.

Songpeng Li (2):
  NetworkPkg/HttpDxe: fix read memory access overflow in HTTPBoot.
  NetworkPkg/HttpUtilitiesDxe: fix read memory access overflow.

 NetworkPkg/HttpDxe/HttpProto.c                      | 10 ++++++----
 NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesProtocol.c |  8 +++++++-
 2 files changed, 13 insertions(+), 5 deletions(-)

-- 
2.18.0.windows.1



             reply	other threads:[~2018-09-28  3:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  3:02 Songpeng Li [this message]
2018-09-28  3:02 ` [PATCH v2 1/2] NetworkPkg/HttpDxe: fix read memory access overflow in HTTPBoot Songpeng Li
2018-09-28  3:02 ` [PATCH v2 2/2] NetworkPkg/HttpUtilitiesDxe: fix read memory access overflow Songpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928030235.1080-1-songpeng.li@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox