From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH v3 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers
Date: Sat, 29 Sep 2018 14:57:31 +0800 [thread overview]
Message-ID: <20180929065736.12796-1-hao.a.wu@intel.com> (raw)
V3 changes:
A. Fix wrong file (should be LoadFenceSmm.c) gets listed in
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf
B. Rename the newly introduced internal function from 'VariableLoadFence'
to 'MemoryLoadFence' within
MdeModulePkg/Universal/Variable/RuntimeDxe/
C. Remove extra empty line before EOF for files:
MdePkg/Library/BaseLib/Ia32/Lfence.nasm
MdePkg/Library/BaseLib/X64/Lfence.nasm
D. Remove dummy message within commit log messages
Since A. has functional impact. Thus send V3 of the series.
V2 history:
A. Rename the newly introduced BaseLib API to 'AsmLfence', and makes it
IA32/X64 specific.
B. Add brief comments before calls of the AsmLfence() to state the
purpose.
C. Refine the patch for Variable/RuntimeDxe driver and make the change
focus on the SMM code.
V1 history:
The series aims to mitigate the Bounds Check Bypass (CVE-2017-5753) issues
within SMI handlers.
A more detailed explanation of the purpose of the series is under the
'Bounds check bypass mitigation' section of the below link:
https://software.intel.com/security-software-guidance/insights/host-firmware-speculative-execution-side-channel-mitigation
And the document at:
https://software.intel.com/security-software-guidance/api-app/sites/default/files/337879-analyzing-potential-bounds-Check-bypass-vulnerabilities.pdf
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Hao Wu (5):
MdePkg/BaseLib: Add new AsmLfence API
MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass
MdeModulePkg/SmmLockBox: [CVE-2017-5753] Fix bounds check bypass
MdeModulePkg/Variable: [CVE-2017-5753] Fix bounds check bypass
UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5753] Fix bounds check bypass
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c | 7 ++++
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf | 1 +
MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.c | 10 ++++++
MdeModulePkg/Universal/Variable/RuntimeDxe/LoadFenceDxe.c | 31 ++++++++++++++++
MdeModulePkg/Universal/Variable/RuntimeDxe/LoadFenceSmm.c | 30 ++++++++++++++++
MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h | 13 ++++++-
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 ++++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf | 1 +
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 18 ++++++++++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 1 +
MdePkg/Include/Library/BaseLib.h | 13 +++++++
MdePkg/Library/BaseLib/BaseLib.inf | 2 ++
MdePkg/Library/BaseLib/Ia32/Lfence.nasm | 36 +++++++++++++++++++
MdePkg/Library/BaseLib/X64/Lfence.nasm | 37 ++++++++++++++++++++
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 5 +++
15 files changed, 210 insertions(+), 1 deletion(-)
create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/LoadFenceDxe.c
create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/LoadFenceSmm.c
create mode 100644 MdePkg/Library/BaseLib/Ia32/Lfence.nasm
create mode 100644 MdePkg/Library/BaseLib/X64/Lfence.nasm
--
2.12.0.windows.1
next reply other threads:[~2018-09-29 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 6:57 Hao Wu [this message]
2018-09-29 6:57 ` [PATCH v3 1/5] MdePkg/BaseLib: Add new AsmLfence API Hao Wu
2018-09-29 6:57 ` [PATCH v3 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass Hao Wu
2018-09-29 6:57 ` [PATCH v3 3/5] MdeModulePkg/SmmLockBox: [CVE-2017-5753] Fix " Hao Wu
2018-09-29 6:57 ` [PATCH v3 4/5] MdeModulePkg/Variable: " Hao Wu
2018-09-29 6:57 ` [PATCH v3 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: " Hao Wu
2018-09-29 17:33 ` [PATCH v3 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers Laszlo Ersek
2018-09-30 5:20 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929065736.12796-1-hao.a.wu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox