public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Gary Lin <glin@suse.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Chen, Hesheng" <hesheng.chen@intel.com>,
	"Sun, Yanyan" <yanyan.sun@intel.com>
Subject: Re: [Patch] BaseTools Python: Migrate Python27 to Python36
Date: Mon, 1 Oct 2018 18:23:32 +0800	[thread overview]
Message-ID: <20181001102332.GB2545@GaryWorkstation> (raw)
In-Reply-To: <B9726D6DCCFB8B4CA276A9169B02216D52123AAB@SHSMSX103.ccr.corp.intel.com>

On Wed, Sep 26, 2018 at 01:02:05PM +0000, Zhu, Yonghong wrote:
> Hi All,
> 
Hi Yonghong,

> Now we are working on bugzilla 55<https://bugzilla.tianocore.org/show_bug.cgi?id=55> (https://bugzilla.tianocore.org/show_bug.cgi?id=55)  to migrate BaseTools python tool from Python27 to Python36.  After this migration, the BaseTools will only support Python 3. And for now, user need to install a Python version >= 3.6.
> Here is the link: https://github.com/yzhu52/edk2.git   Branch: Python3_V2
> In this branch, after run edksetup script file, tool auto detect the Python tool that version >= 3.6,  tool would report error if it can't find the python that >= 3.6.
> 
I'm testing the branch and found a minor bug in edksetup.sh that caused
OvmfPkg/build.sh failed to build. I wrote a patch and it works for me.
Where should I send the patch? to the edk2-devel mailinglist directly?
or a pull request in github?

Thanks,

Gary Lin

> Current we still in doing some validation for this migration, and not finish the update for UPT, ECC, EOT, Tests those tools and scripts.
> We already did following on this branch:
> 
> 1.       Remove the "from __future__ import" items
> 
> 2.       Update the xrange to range
> 
> 3.       Update long to int
> 
> 4.       Use input instead of raw_input
> 
> 5.       Not use iteritems(), but use items() directly
> 
> 6.       Remove the super() function argument
> 
> 7.       Remove the itertools usage
> 
> 8.       Fix some open file's read and write function
> 
> 9.       Hand the bytes and str type difference
> 
> 10.   Do some list and iterator update
> 
> 11.   Change the division operation in the expression
> 
> 12.   Use '\n' but not os.linesep
> 
> 13.   Update the BinWrappers script
> 
> 14.   Update edksetup script file
> 
> 
> Your suggestions is highly appreciated.
> 
> Best Regards,
> Zhu Yonghong
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 


  reply	other threads:[~2018-10-01 10:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 13:02 [Patch] BaseTools Python: Migrate Python27 to Python36 Zhu, Yonghong
2018-10-01 10:23 ` Gary Lin [this message]
2018-10-01 15:13   ` Kinney, Michael D
2018-10-09  8:57     ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001102332.GB2545@GaryWorkstation \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox