From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 0/2] add DwUsb3Dxe driver
Date: Thu, 4 Oct 2018 15:15:41 +0100 [thread overview]
Message-ID: <20181004141541.kcnzzu5juuss7ldv@bivouac.eciton.net> (raw)
In-Reply-To: <1534761085-26972-1-git-send-email-haojian.zhuang@linaro.org>
Hi Haojian,
I will start with a few high-level requests:
- Could you rework this for inclusion in edk2-platforms instead?
Silicon/Synopsys I guess?
- Could you submit Usb2 and Usb3 support in a single set for v2?
- Can you convert these to UEFI driver model with
NonDiscoverableDeviceRegistrationLib instead of a hard-coded base
address?
I will provide detailed feedback on the individual patches separately,
so please wait for that before creating a v2.
/
Leif
On Mon, Aug 20, 2018 at 06:31:23PM +0800, Haojian Zhuang wrote:
> Changelog:
> v1:
> * Add Designware USB 3.0 device driver.
>
> Haojian Zhuang (2):
> EmbeddedPkg: add DwUsb protocol
> EmbeddedPkg/Drivers: add DwUsb3Dxe driver
>
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.c | 2434 +++++++++++++++++++++++++++
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec | 44 +
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h | 632 +++++++
> EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf | 52 +
> EmbeddedPkg/Include/Protocol/DwUsb.h | 81 +
> 5 files changed, 3243 insertions(+)
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.c
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf
> create mode 100644 EmbeddedPkg/Include/Protocol/DwUsb.h
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-10-04 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 10:31 [PATCH v1 0/2] add DwUsb3Dxe driver Haojian Zhuang
2018-08-20 10:31 ` [PATCH v1 1/2] EmbeddedPkg: add DwUsb protocol Haojian Zhuang
2018-10-04 14:49 ` Leif Lindholm
2018-10-22 2:39 ` Haojian Zhuang
2018-08-20 10:31 ` [PATCH v1 2/2] EmbeddedPkg/Drivers: add DwUsb3Dxe driver Haojian Zhuang
2018-10-04 16:32 ` Leif Lindholm
2018-10-22 2:51 ` Haojian Zhuang
2018-10-04 14:15 ` Leif Lindholm [this message]
2018-10-22 2:09 ` [PATCH v1 0/2] " Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004141541.kcnzzu5juuss7ldv@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox