From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1005621959CB2 for ; Thu, 4 Oct 2018 07:15:47 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 185-v6so9250146wmt.2 for ; Thu, 04 Oct 2018 07:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SbWE7OWeadh7SPgC76MGU1Fo2wXjPnH84lXZUeHX9NM=; b=YowvOGgkK49/T8Z07VxBED8u6g9SnJaswEF1DUxrY55weJtYY1ClhDcz9jMMqKHc8Y VuI7oo/vshcvOsxqJLv7MhbrKzUoP+Pju4ihxrqwawJgzq5k5ykD+d8egIHRelXpQNNI 7lAMqa1Ezlva1f8gj6ggk3RB9wAVpj+aH7QPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SbWE7OWeadh7SPgC76MGU1Fo2wXjPnH84lXZUeHX9NM=; b=QeXjiGtDoRHh6JuOS35/6nXcT6rFGnJHZW1pJyl/s/sQd8wmHaTlPpJAdig8oD3E1x 9kRBQDE86eY4V6iivELtpd8XUVUajrIPGuF4iPNGC4D8UCHLby1BHCQpMX2jWnwHJ/xn 04B4vEY3aGa6DH9H2+8aLiPoYkIqbKZakXD68e7D8ZY2oEXu+kN4V+mdpPY9gYoVAzg4 tixZujGicQm0d5Cb8XPBRTZNirJCQGs9r2ElIa4GXVAUiOqcWTl4m+8RMlyZPNhCJFDF vdw9s9l3RqKCOlPpvH3n7CdMduhiWvCAn1Bg2svIUa+3gsy3NBs+ztEliuFCzdxyGba7 HrJQ== X-Gm-Message-State: ABuFfoj2sNeLmbT/chTga3B7enlux9SMdm8udK7d1TpPr+gefyI2YYCN kBSH1ErZKln3mtl1CXC9RQpXNw== X-Google-Smtp-Source: ACcGV62WA/SE6+Pe9C6CgvwIHEGq+wSquOdLF0ZZUx4u08YZM42Q4rViLgHuCU3gjk6GswDaS1SJgA== X-Received: by 2002:a1c:1d6:: with SMTP id 205-v6mr5038697wmb.0.1538662545444; Thu, 04 Oct 2018 07:15:45 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n68-v6sm2941236wmn.5.2018.10.04.07.15.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Oct 2018 07:15:43 -0700 (PDT) Date: Thu, 4 Oct 2018 15:15:41 +0100 From: Leif Lindholm To: Haojian Zhuang Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20181004141541.kcnzzu5juuss7ldv@bivouac.eciton.net> References: <1534761085-26972-1-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1534761085-26972-1-git-send-email-haojian.zhuang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1 0/2] add DwUsb3Dxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 14:15:48 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Haojian, I will start with a few high-level requests: - Could you rework this for inclusion in edk2-platforms instead? Silicon/Synopsys I guess? - Could you submit Usb2 and Usb3 support in a single set for v2? - Can you convert these to UEFI driver model with NonDiscoverableDeviceRegistrationLib instead of a hard-coded base address? I will provide detailed feedback on the individual patches separately, so please wait for that before creating a v2. / Leif On Mon, Aug 20, 2018 at 06:31:23PM +0800, Haojian Zhuang wrote: > Changelog: > v1: > * Add Designware USB 3.0 device driver. > > Haojian Zhuang (2): > EmbeddedPkg: add DwUsb protocol > EmbeddedPkg/Drivers: add DwUsb3Dxe driver > > EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.c | 2434 +++++++++++++++++++++++++++ > EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec | 44 + > EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h | 632 +++++++ > EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf | 52 + > EmbeddedPkg/Include/Protocol/DwUsb.h | 81 + > 5 files changed, 3243 insertions(+) > create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.c > create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec > create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h > create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf > create mode 100644 EmbeddedPkg/Include/Protocol/DwUsb.h > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > -- > 2.7.4 >