* [Patch 1/2] NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input parameter.
2018-10-08 3:03 [Patch 0/2] Correct comments to align with the input parameter Jiaxin Wu
@ 2018-10-08 3:03 ` Jiaxin Wu
2018-10-08 3:03 ` [Patch 2/2] ShellPkg/TftpDynamicCommand: " Jiaxin Wu
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jiaxin Wu @ 2018-10-08 3:03 UTC (permalink / raw)
To: edk2-devel; +Cc: Fu Siyuan, Ye Ting, Bi Dandan, Wu Jiaxin
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++++++++++-
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 ++++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c
index 9725fb40dd..61d2d59675 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c
@@ -1,9 +1,9 @@
/** @file
Functions implementation related with Mtftp for UefiPxeBc Driver.
- Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php.
@@ -107,10 +107,11 @@ PxeBcMtftp6CheckPacket (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to EFI_MTFTP6_CONFIG_DATA.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in, out] BufferSize Pointer to buffer size.
@retval EFI_SUCCESS Sucessfully obtained the size of file.
@retval EFI_NOT_FOUND Parse the tftp ptions failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@@ -246,10 +247,11 @@ ON_ERROR:
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to EFI_MTFTP6_CONFIG_DATA.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether with a receive buffer.
@retval EFI_SUCCESS Successfully read the data from the special file.
@@ -414,10 +416,11 @@ PxeBcMtftp6WriteFile (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to EFI_MTFTP6_CONFIG_DATA.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
@retval EFI_SUCCESS Successfully obtained the data from the file included in directory.
@@ -584,10 +587,11 @@ PxeBcMtftp4CheckPacket (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to EFI_MTFTP4_CONFIG_DATA.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in, out] BufferSize Pointer to buffer size.
@retval EFI_SUCCESS Successfully obtained the size of file.
@retval EFI_NOT_FOUND Parse the tftp options failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@@ -723,10 +727,11 @@ ON_ERROR:
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to EFI_MTFTP4_CONFIG_DATA.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
@retval EFI_SUCCESS Successfully read the data from the special file.
@@ -890,10 +895,11 @@ PxeBcMtftp4WriteFile (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to EFI_MTFTP4_CONFIG_DATA.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
@retval EFI_SUCCES Successfully obtained the data from the file included in the directory.
@@ -982,10 +988,11 @@ PxeBcMtftp4ReadDirectory (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to configure data.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in, out] BufferSize Pointer to buffer size.
@retval EFI_SUCCESS Successfully obtained the size of file.
@retval EFI_NOT_FOUND Parse the tftp options failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@@ -1029,10 +1036,11 @@ PxeBcTftpGetFileSize (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to config data.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
@retval EFI_SUCCESS Sucessfully read the data from the special file.
@@ -1134,10 +1142,11 @@ PxeBcTftpWriteFile (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to config data.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicatse whether to use a receive buffer.
@retval EFI_SUCCES Successfully obtained the data from the file included in the directory.
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
index edd8decbd8..30d5cfe343 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
@@ -1,9 +1,9 @@
/** @file
Functions declaration related with Mtftp for UefiPxeBc Driver.
- Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php.
@@ -33,10 +33,11 @@
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to configure data.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in, out] BufferSize Pointer to buffer size.
@retval EFI_SUCCESS Successfully obtained the size of file.
@retval EFI_NOT_FOUND Parse the tftp ptions failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@@ -59,10 +60,11 @@ PxeBcTftpGetFileSize (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to config data.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
@retval EFI_SUCCESS Successfully read the data from the special file.
@@ -116,10 +118,11 @@ PxeBcTftpWriteFile (
@param[in] Private Pointer to PxeBc private data.
@param[in] Config Pointer to config data.
@param[in] Filename Pointer to boot file name.
@param[in] BlockSize Pointer to required block size.
+ @param[in] WindowSize Pointer to required window size.
@param[in] BufferPtr Pointer to buffer.
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether with a receive buffer.
@retval EFI_SUCCES Successfully obtained the data from the file included in directory.
--
2.17.1.windows.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter.
2018-10-08 3:03 [Patch 0/2] Correct comments to align with the input parameter Jiaxin Wu
2018-10-08 3:03 ` [Patch 1/2] NetworkPkg/UefiPxeBcDxe: " Jiaxin Wu
@ 2018-10-08 3:03 ` Jiaxin Wu
2018-10-08 14:47 ` Carsey, Jaben
2018-10-08 3:11 ` [Patch 0/2] " Fu, Siyuan
2018-10-08 6:07 ` Bi, Dandan
3 siblings, 1 reply; 6+ messages in thread
From: Jiaxin Wu @ 2018-10-08 3:03 UTC (permalink / raw)
To: edk2-devel; +Cc: Carsey Jaben, Fu Siyuan, Ye Ting, Bi Dandan, Wu Jiaxin
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Carsey Jaben <jaben.carsey@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
index d4391b9f33..ccf7abde42 100644
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
@@ -163,10 +163,11 @@ GetFileSize (
@param[in] Mtftp4 MTFTP4 protocol interface
@param[in] FilePath Path of the file, Unicode encoded
@param[in] AsciiFilePath Path of the file, ASCII encoded
@param[in] FileSize Size of the file in number of bytes
@param[in] BlockSize Value of the TFTP blksize option
+ @param[in] WindowSize Value of the TFTP window size option
@param[out] Data Address where to store the address of the buffer
where the data of the file were downloaded in
case of success.
@retval EFI_SUCCESS The file was downloaded.
@@ -904,10 +905,11 @@ Error :
@param[in] Mtftp4 MTFTP4 protocol interface
@param[in] FilePath Path of the file, Unicode encoded
@param[in] AsciiFilePath Path of the file, ASCII encoded
@param[in] FileSize Size of the file in number of bytes
@param[in] BlockSize Value of the TFTP blksize option
+ @param[in] WindowSize Value of the TFTP window size option
@param[out] Data Address where to store the address of the buffer
where the data of the file were downloaded in
case of success.
@retval EFI_SUCCESS The file was downloaded.
--
2.17.1.windows.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter.
2018-10-08 3:03 ` [Patch 2/2] ShellPkg/TftpDynamicCommand: " Jiaxin Wu
@ 2018-10-08 14:47 ` Carsey, Jaben
0 siblings, 0 replies; 6+ messages in thread
From: Carsey, Jaben @ 2018-10-08 14:47 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org
Cc: Ye, Ting, Fu, Siyuan, Wu, Jiaxin, Bi, Dandan
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Sunday, October 07, 2018 8:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ye, Ting <ting.ye@intel.com>;
> Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>
> Subject: [edk2] [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct
> comments to align with the input parameter.
> Importance: High
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
>
> Cc: Carsey Jaben <jaben.carsey@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> index d4391b9f33..ccf7abde42 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> @@ -163,10 +163,11 @@ GetFileSize (
> @param[in] Mtftp4 MTFTP4 protocol interface
> @param[in] FilePath Path of the file, Unicode encoded
> @param[in] AsciiFilePath Path of the file, ASCII encoded
> @param[in] FileSize Size of the file in number of bytes
> @param[in] BlockSize Value of the TFTP blksize option
> + @param[in] WindowSize Value of the TFTP window size option
> @param[out] Data Address where to store the address of the buffer
> where the data of the file were downloaded in
> case of success.
>
> @retval EFI_SUCCESS The file was downloaded.
> @@ -904,10 +905,11 @@ Error :
> @param[in] Mtftp4 MTFTP4 protocol interface
> @param[in] FilePath Path of the file, Unicode encoded
> @param[in] AsciiFilePath Path of the file, ASCII encoded
> @param[in] FileSize Size of the file in number of bytes
> @param[in] BlockSize Value of the TFTP blksize option
> + @param[in] WindowSize Value of the TFTP window size option
> @param[out] Data Address where to store the address of the buffer
> where the data of the file were downloaded in
> case of success.
>
> @retval EFI_SUCCESS The file was downloaded.
> --
> 2.17.1.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch 0/2] Correct comments to align with the input parameter.
2018-10-08 3:03 [Patch 0/2] Correct comments to align with the input parameter Jiaxin Wu
2018-10-08 3:03 ` [Patch 1/2] NetworkPkg/UefiPxeBcDxe: " Jiaxin Wu
2018-10-08 3:03 ` [Patch 2/2] ShellPkg/TftpDynamicCommand: " Jiaxin Wu
@ 2018-10-08 3:11 ` Fu, Siyuan
2018-10-08 6:07 ` Bi, Dandan
3 siblings, 0 replies; 6+ messages in thread
From: Fu, Siyuan @ 2018-10-08 3:11 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Carsey, Jaben, Ye, Ting, Bi, Dandan
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Monday, October 8, 2018 11:03 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch 0/2] Correct comments to align with the input parameter.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
>
> Cc: Carsey Jaben <jaben.carsey@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
>
> Jiaxin Wu (2):
> NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input
> parameter.
> ShellPkg/TftpDynamicCommand: Correct comments to align with the input
> parameter.
>
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++++++++++-
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 ++++-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
> --
> 2.17.1.windows.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch 0/2] Correct comments to align with the input parameter.
2018-10-08 3:03 [Patch 0/2] Correct comments to align with the input parameter Jiaxin Wu
` (2 preceding siblings ...)
2018-10-08 3:11 ` [Patch 0/2] " Fu, Siyuan
@ 2018-10-08 6:07 ` Bi, Dandan
3 siblings, 0 replies; 6+ messages in thread
From: Bi, Dandan @ 2018-10-08 6:07 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Carsey, Jaben, Fu, Siyuan, Ye, Ting
Reviewed-by: Dandan Bi<dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Wu, Jiaxin
Sent: Monday, October 8, 2018 11:03 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.carsey@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 0/2] Correct comments to align with the input parameter.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Carsey Jaben <jaben.carsey@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Jiaxin Wu (2):
NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input
parameter.
ShellPkg/TftpDynamicCommand: Correct comments to align with the input
parameter.
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++++++++++-
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 ++++-
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
3 files changed, 16 insertions(+), 2 deletions(-)
--
2.17.1.windows.2
^ permalink raw reply [flat|nested] 6+ messages in thread