From: Jiaxin Wu <Jiaxin.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Carsey Jaben <jaben.carsey@intel.com>,
Fu Siyuan <siyuan.fu@intel.com>, Ye Ting <ting.ye@intel.com>,
Bi Dandan <dandan.bi@intel.com>, Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter.
Date: Mon, 8 Oct 2018 11:03:25 +0800 [thread overview]
Message-ID: <20181008030325.4188-3-Jiaxin.wu@intel.com> (raw)
In-Reply-To: <20181008030325.4188-1-Jiaxin.wu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Carsey Jaben <jaben.carsey@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
index d4391b9f33..ccf7abde42 100644
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
@@ -163,10 +163,11 @@ GetFileSize (
@param[in] Mtftp4 MTFTP4 protocol interface
@param[in] FilePath Path of the file, Unicode encoded
@param[in] AsciiFilePath Path of the file, ASCII encoded
@param[in] FileSize Size of the file in number of bytes
@param[in] BlockSize Value of the TFTP blksize option
+ @param[in] WindowSize Value of the TFTP window size option
@param[out] Data Address where to store the address of the buffer
where the data of the file were downloaded in
case of success.
@retval EFI_SUCCESS The file was downloaded.
@@ -904,10 +905,11 @@ Error :
@param[in] Mtftp4 MTFTP4 protocol interface
@param[in] FilePath Path of the file, Unicode encoded
@param[in] AsciiFilePath Path of the file, ASCII encoded
@param[in] FileSize Size of the file in number of bytes
@param[in] BlockSize Value of the TFTP blksize option
+ @param[in] WindowSize Value of the TFTP window size option
@param[out] Data Address where to store the address of the buffer
where the data of the file were downloaded in
case of success.
@retval EFI_SUCCESS The file was downloaded.
--
2.17.1.windows.2
next prev parent reply other threads:[~2018-10-08 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 3:03 [Patch 0/2] Correct comments to align with the input parameter Jiaxin Wu
2018-10-08 3:03 ` [Patch 1/2] NetworkPkg/UefiPxeBcDxe: " Jiaxin Wu
2018-10-08 3:03 ` Jiaxin Wu [this message]
2018-10-08 14:47 ` [Patch 2/2] ShellPkg/TftpDynamicCommand: " Carsey, Jaben
2018-10-08 3:11 ` [Patch 0/2] " Fu, Siyuan
2018-10-08 6:07 ` Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008030325.4188-3-Jiaxin.wu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox