public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Eric Jin <eric.jin@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.
Date: Thu, 11 Oct 2018 10:29:24 +0800	[thread overview]
Message-ID: <20181011022924.14052-1-eric.jin@intel.com> (raw)

GetNextSlot() returns the slot number on the controller,
but the SD card specified by Slot may not exist on the SD controller.

Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com>
---
 .../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
index 6b001cd..05005a0 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
@@ -1,7 +1,7 @@
 /** @file
 
   Copyright 2017 Unified EFI, Inc.<BR>
-  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest (
                      (UINTN)DevicePath->SubType,
                      (UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8)
                      );
-    } else if (Status == EFI_OUT_OF_RESOURCES)
+    } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND))
       AssertionType = EFI_TEST_ASSERTION_WARNING;
     else
       AssertionType = EFI_TEST_ASSERTION_FAILED;
-- 
2.9.0.windows.1



             reply	other threads:[~2018-10-11  2:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  2:29 Eric Jin [this message]
2018-10-12  7:56 ` [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot Supreeth Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011022924.14052-1-eric.jin@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox