* [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.
@ 2018-10-11 2:29 Eric Jin
2018-10-12 7:56 ` Supreeth Venkatesh
0 siblings, 1 reply; 2+ messages in thread
From: Eric Jin @ 2018-10-11 2:29 UTC (permalink / raw)
To: edk2-devel
GetNextSlot() returns the slot number on the controller,
but the SD card specified by Slot may not exist on the SD controller.
Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com>
---
.../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
index 6b001cd..05005a0 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
@@ -1,7 +1,7 @@
/** @file
Copyright 2017 Unified EFI, Inc.<BR>
- Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest (
(UINTN)DevicePath->SubType,
(UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8)
);
- } else if (Status == EFI_OUT_OF_RESOURCES)
+ } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND))
AssertionType = EFI_TEST_ASSERTION_WARNING;
else
AssertionType = EFI_TEST_ASSERTION_FAILED;
--
2.9.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.
2018-10-11 2:29 [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot Eric Jin
@ 2018-10-12 7:56 ` Supreeth Venkatesh
0 siblings, 0 replies; 2+ messages in thread
From: Supreeth Venkatesh @ 2018-10-12 7:56 UTC (permalink / raw)
To: Eric Jin, edk2-devel
Since this was already present in
https://github.com/UEFI/UEFI-SCT/commit/c2a650dd1c39ed653f8f94e436def51b5edf6c71and
it is just migrating over to new repository.
Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
if commit msg is changed to uefi-sct/SctPkg instead of uefi-sct\SctPkg,
while pushing upstream.
On 10/11/2018 03:29 AM, Eric Jin wrote:
> GetNextSlot() returns the slot number on the controller,
> but the SD card specified by Slot may not exist on the SD controller.
>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
> .../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> index 6b001cd..05005a0 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> @@ -1,7 +1,7 @@
> /** @file
>
> Copyright 2017 Unified EFI, Inc.<BR>
> - Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest (
> (UINTN)DevicePath->SubType,
> (UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8)
> );
> - } else if (Status == EFI_OUT_OF_RESOURCES)
> + } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND))
> AssertionType = EFI_TEST_ASSERTION_WARNING;
> else
> AssertionType = EFI_TEST_ASSERTION_FAILED;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-12 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 2:29 [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot Eric Jin
2018-10-12 7:56 ` Supreeth Venkatesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox