From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::32b; helo=mail-wm1-x32b.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EDE3321173C85 for ; Sat, 13 Oct 2018 02:22:47 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id z204-v6so15057257wmc.5 for ; Sat, 13 Oct 2018 02:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JA9jL9W7x2qBZ/WREtx5mOJKcA08RYjstXvU2Ai+YIE=; b=Gm/KtZqJKaxm67eAufGlqSlNC2VEmFhQiBZ2/IxgZf9hUP/xpv1Yb5y7iMkdalHW/j 0w3avePkvuzPwLbvIZHt6dwq2M66gG08fKQzJPa0hMKsGBqqGcsQP1KQTtqU+mTnfzT1 VuUXwAA1SPIpOL5gUjDNvkFdBcQqXYtg8Yh3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JA9jL9W7x2qBZ/WREtx5mOJKcA08RYjstXvU2Ai+YIE=; b=SwS4X11oIkTEI+bPXauqGRMQDeVkXIlqi5agalgiQy2ARATNTPdq/AdUt+BIu8XPCa YqMT0T9i01x2Ts5CyMqhmpoq7LIFFvvQHTVMdxi2ksbf3MbELKXQn67tC7FHOqv9DexB Zr+snvzeUHxfiaXeouraI1HUESllGe2dRo5Kc92EGml2Qe8v+tQQD2a9pTHKQdAdlMyO NBvrm19Us1gfxnrToRhjBrvt1fWG28l1aiw/f0putNxjwy/QcOJASvotnVkmE10a/Syr f/scZD/PtUavJ/mhzPSdotlPt9AJLAAoQLvLVs0+tof+L4uYb2d91UDqEyHG0LvEUz24 Cleg== X-Gm-Message-State: ABuFfohPg8CdzuKpl9Y81Fb3C4kCaXVTBBBm/sXv+bd9isNth0miygEE nXOHqJZfKJO19JV8jVK26R+upA== X-Google-Smtp-Source: ACcGV626XVW1/NheksQZRxZxBnvnCM9FFBUfngU2ep/BvPqLtC5gD2b9alHKKvz4MZH0RcprWO4HVg== X-Received: by 2002:a1c:3ec3:: with SMTP id l186-v6mr7249408wma.84.1539422565836; Sat, 13 Oct 2018 02:22:45 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e142-v6sm10042414wmf.20.2018.10.13.02.22.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Oct 2018 02:22:44 -0700 (PDT) Date: Sat, 13 Oct 2018 10:22:42 +0100 From: Leif Lindholm To: "Gao, Liming" Cc: Ard Biesheuvel , edk2-devel-01 , Laszlo Ersek , "Kinney, Michael D" , "Zhu, Yonghong" , "stephano.cetola@linux.intel.com" Message-ID: <20181013092242.2t6drhdcudeeaghe@bivouac.eciton.net> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339880@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339880@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: BaseTools/ build broken due to unreviewed patch - PLEASE FIX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 09:22:48 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Liming, The fact that the set includes unreviewed patches[1] should be sufficient argument for reverting it immediately. [1] ea787b6b55499e8f931201f8f49daaaeb2e4409f But beyond that, a set this invasive should only ever be pushed in the days after a stable tag has been created - not 2/3 through the period. This particular one breaks builds using the instructions from https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions With the new set, it is mandatory that edksetup.sh is sourced before building BaseTools. That was not previously the case, meaning existing CI jobs following the documentation example now fail. Please revert this set for now. We can revisit and plan a suitable way forward after that. Regards, Leif On Sat, Oct 13, 2018 at 08:44:39AM +0000, Gao, Liming wrote: > Ard: > I pull the latest edk2 code. I can find RunTests.py in > BaseTools/Tests. The below error message shows RunTests.py is not > found. But, this file is in BaseTools/Tests. I also run Make > command in BaseTools directory. It can work in my Ubuntu > machine. I install Python37. Do you install Python36 or Python37 > in your machine? > > Yonghong has sent the mail to notify BaseTools Python3 migration > is done. Python3.6 or the above is required. > > > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > > Sent: Saturday, October 13, 2018 4:18 PM > > To: edk2-devel-01 ; Gao, Liming ; Laszlo Ersek ; Leif Lindholm > > ; Kinney, Michael D ; Zhu, Yonghong ; > > stephano.cetola@linux.intel.com > > Subject: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX > > > > Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f > > > > "BaseTools: update Test scripts support python3" > > > > [which has never been sent out for review to the mailing list, as far > > as I can tell] is breaking the BaseTools build > > > > make -C Tests > > make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' > > /bin/sh: 1: RunTests.py: not found > > GNUmakefile:17: recipe for target 'test' failed > > make[1]: *** [test] Error 127 > > make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' > > GNUmakefile:25: recipe for target 'Tests' failed > > make: *** [Tests] Error 2 > > make: Leaving directory '/home/ard/build/edk2/BaseTools' > > > > I tried reverting that patch alone, but that gives me > > > > make -C Tests > > make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' > > Traceback (most recent call last): > > File "RunTests.py", line 36, in > > allTests = GetAllTestsSuite() > > File "RunTests.py", line 33, in GetAllTestsSuite > > return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()]) > > File "RunTests.py", line 30, in GetPythonTestSuite > > return PythonToolsTests.TheTestSuite() > > File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py", > > line 27, in TheTestSuite > > import CheckUnicodeSourceFiles > > File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py", > > line 25, in > > from Common.Misc import PathClass > > File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py", > > line 27, in > > from collections import UserDict as IterableUserDict > > ImportError: cannot import name UserDict > > GNUmakefile:17: recipe for target 'test' failed > > make[1]: *** [test] Error 1 > > make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' > > GNUmakefile:25: recipe for target 'Tests' failed > > make: *** [Tests] Error 2 > > make: Leaving directory '/home/ard/build/edk2/BaseTools' > > > > Breaking the build for everyone with an unreviewed patch 2 days before > > the plugfest is NOT OK. > > > > Please fix or revert ASAP > > > > (I suppose that the failing test is a false negative in this case, but > > that is not really the point - my CI jobs are broken due to this and > > so are many others, I imagine) > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel