From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F3C4A21164EF7 for ; Sat, 13 Oct 2018 13:40:27 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id i8-v6so15182057wmg.0 for ; Sat, 13 Oct 2018 13:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l7kJSN3Wdpm0qf26CowhXRfIMnSCz40rPeAf4AEZRPQ=; b=GQh8qX+2souxRxZJrmwIPddAq1TEy+ML77OsHpMFxdKvCCGqXf0sXyBXz6qOTgxAQG tlp8NfZZwwj+ss7soekPQ313Na2ON1+plviu97GjKwqtBXdPseHBdDZbMiULFXkDX61l CG9bMJVtabRqk7dpiR0nnJQTQcFm6RtPep7+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l7kJSN3Wdpm0qf26CowhXRfIMnSCz40rPeAf4AEZRPQ=; b=ZnLjqBVHPJugj6PQNc9OMN+LEd5ab7oKRbQS1L5e+w5UFJhZ5zU72R/JufDAC2fVtj Jeh0orvx6aVmC1foA3F2peBUVyATzigiRorIe0LKRHHWPZJrJ8Cz3f1aGjyPbV2Df70R 4+XJzMu45noYOY4NtY3bZq1jxZzWSUTK00v/pSKY8FROh8suGksaj2FgUPL6la3z8EIu TRIteMHJGCcVeAtnIzzcg7naaAqe9zKezYy5ZF79pjnzdJHNGBDq5H6/pXi1IVCYXPu1 s1qPobelHtymPN1A2IE7PUYDRM6/mkcavuQS9aOBB5/YhdHHfT3o/4VImIj54OIRkxMx AbEA== X-Gm-Message-State: ABuFfogeH18k5+Ju9BkkpfNyvJ26UWqPEz0lMg/sgEV8gvY1KqDNUXHk 7qLhSO48K670kLGgoh4phx/Evg== X-Google-Smtp-Source: ACcGV62qxzT5mLTcRSCZgvRCRvO+Sm6/q7bQCheNA/Or1LRP9kJ8hrur3L8fJe1WXWh8TXowFBE67A== X-Received: by 2002:a1c:8a55:: with SMTP id m82-v6mr8435414wmd.70.1539463225906; Sat, 13 Oct 2018 13:40:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y4-v6sm8982501wrd.25.2018.10.13.13.40.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Oct 2018 13:40:24 -0700 (PDT) Date: Sat, 13 Oct 2018 21:40:23 +0100 From: Leif Lindholm To: "Zhu, Yonghong" Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Liming Gao Message-ID: <20181013204023.tz4bomxz7ds26du2@bivouac.eciton.net> References: <1539448829-13824-1-git-send-email-yonghong.zhu@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 20:40:28 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Yonghong, Please revert this patch. The broken state of the master branch must be undone, not hacked on until individual bits seem to work. Plese do no further work on the master branch until the contents of the tree is identical to what it was at 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a git push -f, I am talking about a git revert.) Best Regards, Leif On Sat, Oct 13, 2018 at 04:53:21PM +0000, Zhu, Yonghong wrote: > Hi Ard, > > Thanks. I pushed this patch since it is critical block issue. > Version SHA-1: 678f85131238622e576705117e299d81cff755c9 > > Best Regards, > Zhu Yonghong > > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Sunday, October 14, 2018 12:44 AM > To: Zhu, Yonghong > Cc: edk2-devel@lists.01.org; Leif Lindholm > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > On 13 October 2018 at 18:40, Yonghong Zhu wrote: > > Cover the case use do make -C BaseTools before run the .edksetup.sh > > file. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Yonghong Zhu > > Reviewed-by: Ard Biesheuvel > Tested-by: Ard Biesheuvel > > > --- > > BaseTools/Tests/GNUmakefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > > index af334a8a..536f0b7 100644 > > --- a/BaseTools/Tests/GNUmakefile > > +++ b/BaseTools/Tests/GNUmakefile > > @@ -12,10 +12,10 @@ > > # > > > > all: test > > > > test: > > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > > + @if command -v python3 >/dev/null 2>&1; then python3 > > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > > > clean: > > find . -name '*.pyc' -exec rm '{}' ';' > > > > -- > > 2.6.1.windows.1 > >