[PATCH] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName

[PATCH] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName

[Eric Jin]

Ensure the HwErrRecVariable could be deleted before the test exit.

Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com>
---
 .../BlackBoxTest/VariableServicesBBTestFunction.c              | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
index d1064cec..1be1720a 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
@@ -1,7 +1,7 @@
 /** @file
 
   Copyright 2006 - 2012 Unified EFI, Inc.<BR>
-  Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -3052,6 +3052,7 @@ HardwareErrorRecordFuncTest (
   //
 step2:
   DataSize = 255;
+  HwErrRecVariableName[12] = L'\0';
   SctStrnCpy ( HwErrRecVariableName, (CHAR16*)(RecoveryData+2), 12 );
   Status = RT->GetVariable (
                         HwErrRecVariableName,
-- 
2.18.0.windows.1

Re: [PATCH] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName

[Supreeth Venkatesh]

On 10/14/2018 02:31 AM, Eric Jin wrote:
> Ensure the HwErrRecVariable could be deleted before the test exit.
>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
>   .../BlackBoxTest/VariableServicesBBTestFunction.c              | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
> index d1064cec..1be1720a 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
> @@ -1,7 +1,7 @@
>   /** @file
>   
>     Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> -  Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
>   
>     This program and the accompanying materials
>     are licensed and made available under the terms and conditions of the BSD License
> @@ -3052,6 +3052,7 @@ HardwareErrorRecordFuncTest (
>     //
>   step2:
>     DataSize = 255;
> +  HwErrRecVariableName[12] = L'\0';
Magic Number 12.
>     SctStrnCpy ( HwErrRecVariableName, (CHAR16*)(RecoveryData+2), 12 );
>     Status = RT->GetVariable (
>                           HwErrRecVariableName,

Re: [PATCH] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName

[Supreeth Venkatesh]

FYI

On 10/15/2018 03:23 AM, Supreeth Venkatesh wrote:


On 10/14/2018 02:31 AM, Eric Jin wrote:

Ensure the HwErrRecVariable could be deleted before the test exit.

Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com><mailto:supreeth.venkatesh@arm.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com><mailto:jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com><mailto:eric.jin@intel.com>
---
  .../BlackBoxTest/VariableServicesBBTestFunction.c              | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
index d1064cec..1be1720a 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestFunction.c
@@ -1,7 +1,7 @@
  /** @file
      Copyright 2006 - 2012 Unified EFI, Inc.<BR>
-  Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
      This program and the accompanying materials
    are licensed and made available under the terms and conditions of the BSD License
@@ -3052,6 +3052,7 @@ HardwareErrorRecordFuncTest (
    //
  step2:
    DataSize = 255;
+  HwErrRecVariableName[12] = L'\0';
Magic Number 12.

    SctStrnCpy ( HwErrRecVariableName, (CHAR16*)(RecoveryData+2), 12 );
    Status = RT->GetVariable (
                          HwErrRecVariableName,


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.