From: Eric Jin <eric.jin@intel.com>
To: edk2-devel@lists.01.org
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Jiaxin Wu <jiaxin.wu@intel.com>
Subject: [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()
Date: Sun, 14 Oct 2018 09:58:58 +0800 [thread overview]
Message-ID: <20181014015858.3852-1-eric.jin@intel.com> (raw)
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com>
---
uefi-sct/SctPkg/Library/SctLib/Print.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/Library/SctLib/Print.c b/uefi-sct/SctPkg/Library/SctLib/Print.c
index c25aff11..e523073a 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Print.c
+++ b/uefi-sct/SctPkg/Library/SctLib/Print.c
@@ -2,7 +2,7 @@
Copyright 2006 - 2015 Unified EFI, Inc.<BR>
Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.<BR>
- Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -676,7 +676,9 @@ _IPrint (
}
ret = _Print (&ps);
- SctFreePool(ps.fmt.u.pw);
+ if (fmt) {
+ SctFreePool(ps.fmt.u.pw);
+ }
return ret;
}
--
2.18.0.windows.1
next reply other threads:[~2018-10-14 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 1:58 Eric Jin [this message]
2018-10-15 2:24 ` [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint() Supreeth Venkatesh
2018-10-15 13:09 ` Supreeth Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181014015858.3852-1-eric.jin@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox