[PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()

[PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()

[Eric Jin]

Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com>
---
 uefi-sct/SctPkg/Library/SctLib/Print.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Print.c b/uefi-sct/SctPkg/Library/SctLib/Print.c
index c25aff11..e523073a 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Print.c
+++ b/uefi-sct/SctPkg/Library/SctLib/Print.c
@@ -2,7 +2,7 @@
 
   Copyright 2006 - 2015 Unified EFI, Inc.<BR>
   Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.<BR>
-  Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>   
+  Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>   
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -676,7 +676,9 @@ _IPrint (
   }
 
   ret = _Print (&ps);
-  SctFreePool(ps.fmt.u.pw);
+  if (fmt) {
+    SctFreePool(ps.fmt.u.pw);
+  }
   return ret;
 }
 
-- 
2.18.0.windows.1

Re: [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()

[Supreeth Venkatesh]

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>


On 10/14/2018 02:58 AM, Eric Jin wrote:
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
>   uefi-sct/SctPkg/Library/SctLib/Print.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Print.c b/uefi-sct/SctPkg/Library/SctLib/Print.c
> index c25aff11..e523073a 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Print.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Print.c
> @@ -2,7 +2,7 @@
>   
>     Copyright 2006 - 2015 Unified EFI, Inc.<BR>
>     Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.<BR>
> -  Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>
>   
>     This program and the accompanying materials
>     are licensed and made available under the terms and conditions of the BSD License
> @@ -676,7 +676,9 @@ _IPrint (
>     }
>   
>     ret = _Print (&ps);
> -  SctFreePool(ps.fmt.u.pw);
> +  if (fmt) {
> +    SctFreePool(ps.fmt.u.pw);
> +  }
>     return ret;
>   }
>   

Re: [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()

[Supreeth Venkatesh]

On 10/15/2018 03:24 AM, Supreeth Venkatesh wrote:
Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com><mailto:supreeth.venkatesh@arm.com>


On 10/14/2018 02:58 AM, Eric Jin wrote:

Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com><mailto:supreeth.venkatesh@arm.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com><mailto:jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com><mailto:eric.jin@intel.com>
---
  uefi-sct/SctPkg/Library/SctLib/Print.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Print.c b/uefi-sct/SctPkg/Library/SctLib/Print.c
index c25aff11..e523073a 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Print.c
+++ b/uefi-sct/SctPkg/Library/SctLib/Print.c
@@ -2,7 +2,7 @@
      Copyright 2006 - 2015 Unified EFI, Inc.<BR>
    Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.<BR>
-  Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>
      This program and the accompanying materials
    are licensed and made available under the terms and conditions of the BSD License
@@ -676,7 +676,9 @@ _IPrint (
    }
      ret = _Print (&ps);
-  SctFreePool(ps.fmt.u.pw);
+  if (fmt) {
+    SctFreePool(ps.fmt.u.pw);
+  }
    return ret;
  }



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.